From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30CB41B4123; Thu, 5 Dec 2024 07:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733384707; cv=none; b=gOfWFUXaq6SeIVyNFE8gvNFINRHtD1TIOABRt2IlxSHJ5Cdkb+SW11sF2dSvTLbQIW6z36uSqNpM+T3JUKHq832g83IXyEolOsLBSyzovYtVpEQlTHymQLzWCERfR/ksEyZURO8dY+1rthnpewF9qsZAgHpOFukXSGwOghDV0us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733384707; c=relaxed/simple; bh=97hThSuPVWzZ9pr/MZVasityF+cJQ+fGhUX+4hk4DEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UmU9GbRC83ahroY0kdO9QtNx+P9C0dh35SsR2bavFKELEqfFDE1Wq91QLPW4U4BbciMftlMViFpDPARh4czgsqgBxVEt8K/d/gMfwpS9QigXaCbUwBV+ymvfCBWpCXqGQBKXpdr8AVjEEVXz8RNKUSgvx/3NwBuJPNwrquaqPnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Uer+sSHL; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Uer+sSHL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733384706; x=1764920706; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=97hThSuPVWzZ9pr/MZVasityF+cJQ+fGhUX+4hk4DEY=; b=Uer+sSHLN2W1Myq8e45jkGKnc03OXx2bup6E+8K8oS2g1ysxvWCnflqz NiwzfKFMpiihbbY7yRl2QgvUkxM02dXGGJCCVe30uTZ5I4nEq1bHrWH7d VJPQjZIjJhBSGf1jKyaPsUTNe6kislkUWMuGpQu/qQ9osbhzWq8MNtnze 1aVcR2RhXLAfrWMkr15TgUreObw1tvRMleF6zO/n6WK0PEzlXvuu4tY9O QXuY43XJBVkDJppyiLR/8U+vpEJPbU2lVwtZkGY7XHIJL3D/Bf0uTJvuj pCvQmI0RLyfoDmiPiSZKM2u52cenz0iFk2fnIAmF7UA+KKxTvsTjGSU1G Q==; X-CSE-ConnectionGUID: uqfQmuKuTzGN72UaTXthYQ== X-CSE-MsgGUID: 5NKcSkzWQo69AKprp09ZfQ== X-IronPort-AV: E=McAfee;i="6700,10204,11276"; a="51215323" X-IronPort-AV: E=Sophos;i="6.12,209,1728975600"; d="scan'208";a="51215323" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2024 23:45:05 -0800 X-CSE-ConnectionGUID: 0TcOPYQKR5W0L5QBkVXADA== X-CSE-MsgGUID: jX684qnHQEKA759rclA1NA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,209,1728975600"; d="scan'208";a="98466092" Received: from smile.fi.intel.com ([10.237.72.154]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2024 23:45:00 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tJ6Xf-0000000411f-28rf; Thu, 05 Dec 2024 09:44:55 +0200 Date: Thu, 5 Dec 2024 09:44:55 +0200 From: Andy Shevchenko To: Ian Rogers Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , "Liang, Kan" , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v1 1/1] pref/x86/rapl: Remove unused function Message-ID: References: <20241202182815.639124-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Dec 04, 2024 at 03:56:03PM -0800, Ian Rogers wrote: > On Mon, Dec 2, 2024 at 10:28 AM Andy Shevchenko > wrote: > > > > get_rapl_pmu_cpumask() is unused, it prevents kernel builds > > with clang, `make W=1` and CONFIG_WERROR=y: > > > > arch/x86/events/rapl.c:165:37: error: unused function 'get_rapl_pmu_cpumask' [-Werror,-Wunused-function] > > > > Fix this by removing unused function. > > > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > > inline functions for W=1 build"). > > > > Fixes: 9e9af8bbb5f9 ("perf/x86/rapl: Clean up cpumask and hotplug") > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Ian Rogers > > nit: s/pref/perf/ in the commit message title Thanks, the analogue change is already in the perf tree. Just hadn't made the rc1. -- With Best Regards, Andy Shevchenko