From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16D212336A1 for ; Wed, 11 Dec 2024 13:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733925476; cv=none; b=qLmmbpMpaMFKOz/huRfru9W4YCYc/MaQCxI3U/nt3cSiBU7lbjfu8b3cEPsBMbKY/Cpt8C0z1hh7XE7cle1zPSNL91NnXISxTu7iO1Yi0lPgMInA3MMa+Wk14zDqCMTUTDZZbWlrVmlF4/uqdKidOzfTunUHFfjohAUwVPUNdxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733925476; c=relaxed/simple; bh=zhm5/qneWDtFKip5gZc5Ug51qbj4ZyGlCNuuB0VT+aQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W4GKja2yBUOdyCzCGgRELM0eYvnRMTfrlDbAoUkcN/rC7pI63FuKR4jXSMfd++pKn0BOczIr4Fo/3OhnDbC/So8w+uuYxRkYhdoYHSEegzxCCepbqh31vEvYVSn9CVRgud4bRZPYgQo4d6vJd0D/avDZiGtOGxauvtcB6MbIkkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IwpKKNai; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IwpKKNai" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4361c705434so5281955e9.3 for ; Wed, 11 Dec 2024 05:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733925473; x=1734530273; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n+Nq0JPihsIDotmBgK7j9oUK4hXd8/xtAenPkWmVRYY=; b=IwpKKNaivrfAl7DAvLkboGqSQldDQDYOxPkLhfHMGObrTYp94v3gxZYKeHana3kUp5 80hOVvQB84pAcoNh5RAMnJaUFk/jZBywtQ5VGk1UhtPapWh/pvER8rOiNkC7T31xd1bq BxQSil+kipx1emxVHkWLTwfrcCz5zEjWBGPiUpRSXlvqoyyVL2bdUYuSRw3zPdNsv/gK T51MXKE63TQhmP1w6/qZ7w+Ab6FIRGGl6C+A0ociKVYIHyvBMdyLcAA3t686ca1YSS2j JXVpS8IHe0ZFgMA6kGKWYeAztbvJZtRcDvGcL8cUIJcNL+C8d0W3AsA4vNhY3WAbeAPC EYVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733925473; x=1734530273; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n+Nq0JPihsIDotmBgK7j9oUK4hXd8/xtAenPkWmVRYY=; b=IEqvKH5leczq2prM01MODXTH5XE6c8yNfqjUYD6ufVltHWT9TbWbarKyyi3T/l6g1x Mn+W37hkdMsZTgnxCY2ZtKU9IC3IPkEHimvt0RrYFbdlHUEdC3sFCSFzjb+Vzgqt3rB8 ecRDGE74lmoutPzF/wIBXQP6vSgWhUjynYKS3iWQAoWNvmViKLTjxl2unGH7UmqIMHHh kCmr9vNbxK/aUT+tzkJxSgYEMyK/Npn3trQJaCM76YoQpt5jy6d1wWvwWwr3w3QuSR/B I/ivWSmsowqhtkGzkqIElV0ujFEvrIcGj1WoPV1uJ/xxiImY1f7AyDm34sb2j7WYznPr K0Jw== X-Forwarded-Encrypted: i=1; AJvYcCWpqSdsGcv+IkHheM9g9Aml7ETwjyGIZS2EVvPhF7+GJ4JEg0FS6G+ubPBRRFNAU5RJf8UnzDSAZJHdk10=@vger.kernel.org X-Gm-Message-State: AOJu0YyxhuBuvTwost1rUSykjKgZjJKNEiE+YHeza6fAIegg+uwXEdLU Bsbe6YG9HQC9PJHRtFdnf5uir3m7GzALfo1+Lwo5beIhjwaIArKqN/GjxyWyYV0= X-Gm-Gg: ASbGncvQx2eR7wSqDJx8Eowxiq1u99WEk8w8t6tgk91slhLRI7J6RMuzhQEas7uHQul tys8paNVAk2QJl58ClUB/3rlIsQTavueJE8DYaxQHT/j6X3ZjGXJ2tQz23XWNh7AbB6qBE9Xs2v U8MaxAd/9cJdp1YA3kYlsha757QkFtcUBGiVIGv7u1WyK97C+KqL01F/60yDVHKuAFJdiKJiPYH 8fg02T7f8yGOZk2Aq68Yg/t0u3yVfM3fBNyafZqSgpxkGhjD+zu X-Google-Smtp-Source: AGHT+IGJCYJTlBedjQm+GK+uiVv40a+NR20VpMjki58l34sVua7BTMisnr0pAsT6vjoKEaDgR/Mj5Q== X-Received: by 2002:a05:600c:35c9:b0:434:a929:42bb with SMTP id 5b1f17b1804b1-4361c3a336dmr23180715e9.18.1733925473454; Wed, 11 Dec 2024 05:57:53 -0800 (PST) Received: from linaro.org ([82.76.168.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43621ebf8e8sm1879635e9.32.2024.12.11.05.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 05:57:52 -0800 (PST) Date: Wed, 11 Dec 2024 15:57:50 +0200 From: Abel Vesa To: Johan Hovold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Jonathan Marek , Stephan Gerhold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [PATCH v3 1/3] Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports" Message-ID: References: <20241210111444.26240-1-johan+linaro@kernel.org> <20241210111444.26240-2-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241210111444.26240-2-johan+linaro@kernel.org> On 24-12-10 12:14:42, Johan Hovold wrote: > This reverts commit 1a48dd7b9ac809d1bd0fd2fef509abba83433846. > > A recent change enabling OTG mode on the Lenovo ThinkPad T14s USB-C > ports can break SuperSpeed device hotplugging. The host controller is > enumerated, but the device is not: > > xhci-hcd xhci-hcd.5.auto: xHCI Host Controller > xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 3 > xhci-hcd xhci-hcd.5.auto: hcc params 0x0110ffc5 hci version 0x110 quirks 0x000080a000000810 > xhci-hcd xhci-hcd.5.auto: irq 247, io mem 0x0a800000 > xhci-hcd xhci-hcd.5.auto: xHCI Host Controller > xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 4 > xhci-hcd xhci-hcd.5.auto: Host supports USB 3.1 Enhanced SuperSpeed > hub 3-0:1.0: USB hub found > hub 3-0:1.0: 1 port detected > hub 4-0:1.0: USB hub found > hub 4-0:1.0: 1 port detected > > Once this happens on either of the two ports, no amount of disconnecting > and reconnecting makes the SuperSpeed device be enumerated, while > FullSpeed device enumeration still works. > > With retimer (and orientation detection) support not even merged yet, > let's revert at least until we have stable host mode in mainline. > > Fixes: 1a48dd7b9ac8 ("arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports") > Cc: Jonathan Marek > Signed-off-by: Johan Hovold Reviewed-by: Abel Vesa > --- > .../arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts > index 5a4a72a030d4..b4b6260c670c 100644 > --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts > +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts > @@ -1515,6 +1515,10 @@ &usb_1_ss0 { > status = "okay"; > }; > > +&usb_1_ss0_dwc3 { > + dr_mode = "host"; > +}; > + > &usb_1_ss0_dwc3_hs { > remote-endpoint = <&pmic_glink_ss0_hs_in>; > }; > @@ -1543,6 +1547,10 @@ &usb_1_ss1 { > status = "okay"; > }; > > +&usb_1_ss1_dwc3 { > + dr_mode = "host"; > +}; > + > &usb_1_ss1_dwc3_hs { > remote-endpoint = <&pmic_glink_ss1_hs_in>; > }; > -- > 2.45.2 >