From: Dave Penkler <dpenkler@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Dan Carpenter <dan.carpenter@linaro.org>,
Rohit Chavan <roheetchavan@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: gpib: fix address space mixup
Date: Fri, 13 Dec 2024 14:08:58 +0100 [thread overview]
Message-ID: <Z1wx6pzVdh0y9w4d@egonzo> (raw)
In-Reply-To: <20241213064959.1045243-3-arnd@kernel.org>
On Fri, Dec 13, 2024 at 07:49:51AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Throughout the gpib drivers, a 'void *' struct member is used in place
> of either port numbers or __iomem pointers, which leads to lots of extra
> type casts, sparse warnings and less portable code.
>
> Split the struct member in two separate ones with the correct types,
> so each driver can pick which one to use.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> .../gpib/agilent_82350b/agilent_82350b.c | 4 +-
> drivers/staging/gpib/cb7210/cb7210.c | 12 ++---
> drivers/staging/gpib/cb7210/cb7210.h | 4 +-
> drivers/staging/gpib/cec/cec_gpib.c | 4 +-
> drivers/staging/gpib/common/gpib_os.c | 2 +-
> drivers/staging/gpib/eastwood/fluke_gpib.c | 12 ++---
> drivers/staging/gpib/eastwood/fluke_gpib.h | 4 +-
> drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 25 +++++-----
> drivers/staging/gpib/fmh_gpib/fmh_gpib.h | 4 +-
> drivers/staging/gpib/hp_82335/hp82335.c | 21 +++++----
> drivers/staging/gpib/hp_82341/hp_82341.c | 16 +++----
> drivers/staging/gpib/include/gpib_types.h | 3 +-
> drivers/staging/gpib/include/nec7210.h | 5 +-
> drivers/staging/gpib/include/tms9914.h | 5 +-
> drivers/staging/gpib/ines/ines.h | 4 +-
> drivers/staging/gpib/ines/ines_gpib.c | 22 ++++-----
> .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +-
> drivers/staging/gpib/nec7210/nec7210.c | 16 +++----
> drivers/staging/gpib/pc2/pc2_gpib.c | 16 +++----
> drivers/staging/gpib/tms9914/tms9914.c | 8 ++--
> drivers/staging/gpib/tnt4882/mite.h | 4 +-
> drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 46 +++++++++----------
> 22 files changed, 123 insertions(+), 116 deletions(-)
>
[ skip ]
Hi Arnd,
Thank you so much for these valuable patches.
I have successfully tested them on the agilent and ni pci boards
on an amd x86_64 system.
This exercises the agilent_82350b, tms9914 and tnt4882 modules.
Your patches have also fixed the i386 build issue as far as I can tell.
Link: https://lore.kernel.org/all/f10e976e-7a04-4454-b38d-39cd18f142da@roeck-us.net/
cheers,
-Dave
prev parent reply other threads:[~2024-12-13 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 6:49 [PATCH 1/3] staging: gpib: fix pcmcia dependencies Arnd Bergmann
2024-12-13 6:49 ` [PATCH 2/3] staging: gpib: use ioport_map Arnd Bergmann
2024-12-13 6:49 ` [PATCH 3/3] staging: gpib: fix address space mixup Arnd Bergmann
2024-12-13 13:08 ` Dave Penkler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1wx6pzVdh0y9w4d@egonzo \
--to=dpenkler@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=prarit@redhat.com \
--cc=roheetchavan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®