From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CC6157E9F for ; Fri, 13 Dec 2024 18:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734113989; cv=none; b=hIQikO17BXNF6gA6+gI69/dNRhwHtgP6sZCJrDy9gwI5Amr0zq3nJzBvs25tgw1+k2Yobp1c9YUrD4GYvkiE3YQkVW+zFW4kBVn8KQB+/HUHqOvIN8HVj6xzPUkbyFKsaIyZM5p3+wTFBNLZn0KEfIfHxsAxsO7xyGQI5dekqnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734113989; c=relaxed/simple; bh=pBRhGkgZxX0zvUoQiesXTl3MbXRcnvzIGjRjrAAWVBo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pBN7+qtyMQwAQhptoTrxz6aEBfI8WflaF9FKNp+8VXiV/OoBYmtrB2Z1+Il7sn9Qh0FXFjr8T1rT7j0meAqmVUvi5j4UIP/O49V7/wGxxBpFSBrOvHakc5Q2w8Vuc51OFcYDyJy9wGbnOWlpeVpHDBLPSh0BDTezNnMEA0rgft4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Szo36KE7; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Szo36KE7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pBRhGkgZxX0zvUoQiesXTl3MbXRcnvzIGjRjrAAWVBo=; b=Szo36KE7ZNhm73wXRKShO7e9ux UDSS8PZfynPyyw1R4y3/X9qj73BvIXwPMen1+yE+HLxQvmj47oMq/hjcgUY8+FQXFG2DwnI0O3AkA L+Svbl+w82guGUZxmYEhyx3MgDetTHMXrEO1x/2onPFMDQCqp0fZEwHqnouJWXyYk408NBgl10J7K m6wl9OwNsN68fikh8vkVMNGDHLtKUJG1QlPmAupZfZ6kq9fFxpf+Ft0DEJiFYtA0kgfbB6rTuniRv IlXKeE+v2DSD3P37ylahyUXQzo2jbARUu5lR5wRMM+ui7OoNdglN/JRcrYHFgh+xeWm2UXg3iAMVG KQerXNXA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tMAG7-0000000EtDL-0PtS; Fri, 13 Dec 2024 18:19:27 +0000 Date: Fri, 13 Dec 2024 18:19:26 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: Peter Zijlstra , akpm@linux-foundation.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 3/4] mm: replace rw_semaphore with atomic_t in vma_lock Message-ID: References: <20241211082541.GQ21636@noisy.programming.kicks-ass.net> <20241212091659.GU21636@noisy.programming.kicks-ass.net> <20241213095729.GC2484@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 13, 2024 at 09:45:33AM -0800, Suren Baghdasaryan wrote: > think the simplest way would be to move the definition of struct > rcuwait into a separate header and include that header in mm_types.h. > That, with some uninlining like you suggested, should do the trick. I'd suggest struct rcuwait should live in types.h alongside list_head, rcuref and so on.