From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E3FA3F9CC for ; Thu, 26 Dec 2024 17:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735234266; cv=none; b=uf1IPnW6MuzEMirYWNqnaRubDF2t3ft0cVjkFT2JTcbc90VHPNjct5E11ili1nIlpSLbk/lVlZetU0x2J/okav/u/dQ9/nbAu9jydZbAyVqpFFW5sErUFBYaQ8wM9wKGJRQPQtg6kKMvgCxgbf9qfY1+HMQJbH8C1u86RkSKZyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735234266; c=relaxed/simple; bh=MQT//z2Wu44VlEXRV4yVNgPQ7JEgbiqZDnefWFzQiDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tvuYbDIdtLy8s8Fo1m78p8uCGQMngZUEL1wsmy5MsDBwU6Xyzf8sjQH9/bgJqF/btH5MHHkdq9rln38yETqukQaBFZn8w71gMKk48gjHakopZAEoB9iDSj24cS6QvHy+iclsDXZu+coBxSFb3Z7egof/ivQduM/TZEClZVLt/II= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nUI/H2sb; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nUI/H2sb" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-216426b0865so75304695ad.0 for ; Thu, 26 Dec 2024 09:31:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735234264; x=1735839064; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=xcUZWE3ppguCfT0Ghk6RY8lNJANWnC8EbI6p5AXiKeg=; b=nUI/H2sb1ht/SUn0+I+AZmHp+JXhR5+i8btbVjpEhjmuGrFVeKTRn4pnByQaQw9YfL Zms0hbpmMoJclnOZzWBUej3iQ7w3HafJu0ftx7e5Zz2XRBb0oaVp0yTUTkyrD0nYrB7f YDo0oWN66TftFRQwIZPrrWhouvkqleCol5csBA5dm9TnxtuuQLK5q0sDRJAOHFgOrFvW FE5iQ+/wcS7lgS9PtY3FIQq4/JzNM/h0KPFWI8VdRK2Wefo8C6dPVW3r2pWpgZa+TO5y RyhlZ9kkMHu2s0zmnscsKNRcTBjLUdyATnhZsGI/xbfZrq1T6hew4pvEi364mDUd9ksj bB+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735234264; x=1735839064; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xcUZWE3ppguCfT0Ghk6RY8lNJANWnC8EbI6p5AXiKeg=; b=oSiWfW0g0KrgvUSrAvZDuI+impa9qzBINd+4GdMBjKWLss6QJLnNz06SYOplr06ySQ DsDuuARe30WwAJZVVFMi4OjNwvpJmL0cNWHhjJD3usls2khDiOCHyQaxFqcO6IXAoykJ vb3U+oqHjYngfxcu3cG2237LcuQNRog4WicRMrFDCXa+4lgwMxHyi86XCKox9z3X7S3R XZcmos2r87fe7F9OGVUfc3UgzCK0zXwlClfGx7TdEjgORFk2V/rf8cMed8Ih/yJ3dOOt 6i4NdvD0CHvsqtU0cecOwTSTkRER/de3J3EwAm/xHrl0JadEXH9clE9wNyc26hLNjT07 2+VA== X-Forwarded-Encrypted: i=1; AJvYcCWTRoakHpZg2W+qDIgJc2S5shgWvm32O7saPIPnpjoahq0eb5tXWQIHw4Ygrp7ek1F4Hwfx7g4I+PFw+mY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2OrGBZyhGrHHI6gUyQJ3CHfcTVvi22XJhUhciF5goLzB611QU Mm/rKMPI2rI2O86nl7TRBH2kI6Bcq8kZfelzlejrsHHEe1omYYrRaM16Gxxkhg== X-Gm-Gg: ASbGncuTVq5k9upszWlGW6mG08N3USzp7De3ChIkrJkhi90W2/h/jMX0+7nRdggTGxy 54uETZsOwwOou8af/GNJCcbJaOC25obGzyEfv61DHYS9IewRkg1fD2Ho9eGiH/wiKOT3H3JGfiE 6oQ/p8s2+/6ISs3jNWUR5CXdQnsiPvEcNlDmD35KauxIBR8X0WV9P2cR/CaAWJRBW/vcrYcEfLB zPbHZdoLt5yhArvVAjAmDptGaOfE6XGXX7oVcp+wPCYidwvWOzUp0NF2nhr/kphksmKkRvwXBqA lfPUFzEMFtWIkgsO9OTMphQA X-Google-Smtp-Source: AGHT+IHAfn46MsITOFrPVZJ4vXZEH6EHEc/IQOmoCmQiapMunnWTNeZzpppaV467WwIqrvzfz6A1dA== X-Received: by 2002:a05:6a00:414a:b0:725:96b1:d217 with SMTP id d2e1a72fcca58-72abdd7e0e5mr28935333b3a.9.1735234264082; Thu, 26 Dec 2024 09:31:04 -0800 (PST) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8dbbf6sm13136269b3a.111.2024.12.26.09.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 09:31:03 -0800 (PST) Date: Thu, 26 Dec 2024 09:31:00 -0800 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Peter Griffin , Tudor Ambarus , Sam Protsenko , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v4 4/7] phy: exynos5-usbdrd: fix EDS distribution tuning (gs101) Message-ID: References: <20241206-gs101-phy-lanes-orientation-phy-v4-0-f5961268b149@linaro.org> <20241206-gs101-phy-lanes-orientation-phy-v4-4-f5961268b149@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241206-gs101-phy-lanes-orientation-phy-v4-4-f5961268b149@linaro.org> On 12/06/2024, André Draszik wrote: > This code's intention is to configure lane0 and lane2 tunings, but for > lane2 there is a typo and it ends up tuning something else. > > Fix the typo, as it doesn't appear to make sense to apply different > tunings for lane0 vs lane2. > > The same typo appears to exist in the bootloader, hence we restore the > original value in the typo'd registers as well. This can be removed > once / if the bootloader is updated. > > Note that this is incorrect in the downstream driver as well - the > values had been copied from there. > > Reviewed-by: Peter Griffin > Tested-by: Peter Griffin > Signed-off-by: André Draszik Verified on my Pixel 6 Pro. Tested-by: Will McVicker Thanks, Will