From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6303D2BD11 for ; Thu, 26 Dec 2024 17:32:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735234322; cv=none; b=OMwRfiqrhl13onmOn2vHbE4cSbjkArr8sJmXwkQGXQ7LK0k7Jo4SKytykkdoCR9Ev9uhKbpOs5rfXr6rJ7fI7+Px3Tr91jZukSwbSeMS1rkHEwTw+RNa+L4Ip4oYrKCwu8i7wjLmgGhwDYK+vZqZDSpZQWNUjjNb32UYfxZb13c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735234322; c=relaxed/simple; bh=Gjg9UKzv9LuFKKvRutPMZcvVc5g/BOCV0ghr9SuGXE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qde//wpLJAyqFAWxKDmnQJBIvJU2MmzLoe/0XqujXtDWAgtOp2KMf2mdpnJXVPXSK6lbh5cHbhQNV33sfgf44+DKTidENYSupDXd8n8gFovbZbLNsT4/xnZjP1LhlgkBRDxtzoa0pnS18vv1KjY4tGc+0+3Pfw1zZy9lkWms4sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dAzV0VrH; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dAzV0VrH" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-21661be2c2dso69266195ad.1 for ; Thu, 26 Dec 2024 09:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735234321; x=1735839121; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fZq8gTOhd/HrF2N/ypBV//FltCA9lQr1B5nofEk6FbE=; b=dAzV0VrHLNkBl+j4otwJ7aUvs8XcBokA1ppWk4oLQLYU+sPtyIdu6PS2SFY78YfOW9 fxpb3NFATphIp3IfZGSQtThxmsAhhzCp2XkfrxRjZSgR2RclH+4G4AXCI5PfVvI0RUOG 5iMdHtCFCTMpRhbYxKx6NxQ7T0z38gshnIVu6iHVcY7Ug0RCCQGDWirwzJuWBYnlBdXs RQ+jDXpdYM8A4H0rpg0F/qGFIozRIR3dhUYQqkyANMz4e3OvsjjeNLMfay/Wa/Sbv9Ak BX/S7W3nbDIR7sJ5iaJC6gfEB2vG7C94L4DjD1HFOImy8Wl7jk6CYFw4E/5QY/+m9DCN PZJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735234321; x=1735839121; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fZq8gTOhd/HrF2N/ypBV//FltCA9lQr1B5nofEk6FbE=; b=YObrHEAxrUwidWa1+yG1QF8wbScYtqHsK8vajrLVC0l3C8Z0yWiqLZ2eLvWXDBidkA 8Xrh9rNPri3ldcKtTq/GaoBcrrpxLGuizytnWrwspw04zqa4QpC610hb1hvYIpz4OM3J NbRfweSXlkcsTFxTwH/+PmsYvrlv402YA2LCZjFkEDPc8N69WxtH0WyRT+pq5o7Y0Oek vKq03tJXDCbyoRQ+eMJbSbgjFB+CjHJL8TtLM3jCWr7kyKuITTUabSVd6LKsBQb9TeFR +jUPhRiB8mqdrparjJcuAKqjhaVJ6YSl7QQWClLSzkyFBP7xydd3Roke+lQiqRgj4iv+ bv3Q== X-Forwarded-Encrypted: i=1; AJvYcCWFr5yLcPDfu1gLoo0A90LGxhYPxH0acb0Q54ARY6Z5qSlAZI+pTadSJ6EGfoDx+TWfaVp2Fg57QFjkbuE=@vger.kernel.org X-Gm-Message-State: AOJu0YxDEeUq4KVOb/re2zNS6KVWw1xYMCtc+kS0heQqr4iE8x6YJtcM ydmWp8msgbgyvSyz86ad0MCuqM71EvV7mnkfQksLlnjayKnHWi5YYh6ppdnoOg== X-Gm-Gg: ASbGncurssP1Pc8YFz5qlV6VhuH9tqGXZ5d/cqtmW12DP1u7DDTHE1SiwHX8CNhVcOO cdzqZg8oy2YkQGJfhK/DEC7aIdXyxNlnScN0tI9uODWdtKODnGJKxnQEgN7G0kWofYifrtbHcWL mceN0+xRD6D0nEhiCj10YAzl/BTR7fiehE9Z39DMdb2/Iejdgu1nPNqR12UQkrfOb3dk9DPQ41Z Y3uhPNVilnYOc5CCnBLPBjtaIH6Vi9frmrkzAf8ARs52YncD8T/dzYUZXkhG0FtnKSkfNImjtpD H37bfk/HIfkqqXA+6+705xhj X-Google-Smtp-Source: AGHT+IGMiawar/mU5KvWb2BzVuABUtr4oiv5toBR6JEErmfnPl/aBnhoZzQMhDzJD2wfGufTegEhmw== X-Received: by 2002:a17:902:e802:b0:216:5e6b:e23 with SMTP id d9443c01a7336-219e6eb6305mr303933895ad.30.1735234320475; Thu, 26 Dec 2024 09:32:00 -0800 (PST) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96e94dsm122897285ad.67.2024.12.26.09.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 09:32:00 -0800 (PST) Date: Thu, 26 Dec 2024 09:31:57 -0800 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Peter Griffin , Tudor Ambarus , Sam Protsenko , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v4 5/7] phy: exynos5-usbdrd: gs101: configure SS lanes based on orientation Message-ID: References: <20241206-gs101-phy-lanes-orientation-phy-v4-0-f5961268b149@linaro.org> <20241206-gs101-phy-lanes-orientation-phy-v4-5-f5961268b149@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241206-gs101-phy-lanes-orientation-phy-v4-5-f5961268b149@linaro.org> On 12/06/2024, André Draszik wrote: > USB SS lanes need to be configured based on the connector orientation - > at most two lanes will be in use for USB (and the remaining two for > alternate modes like DP). > > For the USB link to come up in SS, the lane configuration registers > have to be programmed accordingly. > > While we still need a way to be notified of the actual connector > orientation and then reprogram the registers accordingly (at the moment > the configuration happens just once during phy_init() and never again), > we can prepare the code doing the configuration to take the orientation > into account. > > Do so. > > Note: the mutex is needed to synchronize this with the upcoming > connector orientation callback. > > Reviewed-by: Peter Griffin > Tested-by: Peter Griffin > Signed-off-by: André Draszik Verified on my Pixel 6 Pro. Tested-by: Will McVicker Thanks, Will