From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5039C1F2C55 for ; Fri, 27 Dec 2024 15:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735313873; cv=none; b=Pnn3AYLIpBpvFVOjHQGUkd7xJDa6MW4FdK5nIuAwECdvxfT5tlbfDdwi9YRqZmeSPEnJOTg85gz8m5KUCSdeF3WN5Bvzic69C08VQ4e0tWg73Iq3m0NvnaiUjq9h4chmIGdUkC9UZ1D4Cm30y6hfOus+oBvWSvUI2AqRo9Pd53M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735313873; c=relaxed/simple; bh=x7iBU7fAYI8fxS7DNThFtEhPu3na297dWh7vHXIfDkg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=svqtbKAyOpIRiRI96S/hCV8+t3n2yxF9Nn0JXChDn4yJTvZV1+tgNmhhlwIH2CsvKrGIaFcdZc52upaBghcx62E1sD8/gtcwPmsuYjcXdVyOcwGEswc/FXswaZ5U2zuWopLRFJ2luSui7mNTAm4BRtDMTV2WxpnDmcLcigJTsMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=S0/mBd12; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="S0/mBd12" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6d92cd1e811so71856356d6.1 for ; Fri, 27 Dec 2024 07:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735313870; x=1735918670; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=wjgnwQaaUqsMHMMeaH4EeULRZg8SFG+sYNaSJWvGTI8=; b=S0/mBd12ItMN8HSEK/cYOq+/hbRYN8cuOaxDA512+XG/STxO9WA/eVDfFQp6KW0RsV fhFmNZURc0vCf4xm/IWVX+Z9CRL+8BxMlLrF0WKNWWS7viHWUza4zI+Y9kk08mBqQRbu xWZTt47QVqk25BpUx1uugj+AmJFAN68eW1SOa33XSfMTjtaFIbLoAtUcYfyRtxtzFMix A+LU4eYbFxIkBMNtWxoeBEYkRSWTZb62m7FbIldOyvIwQ3VxC9jF53jJs535gCJIiNHN qWNAwbo0wtOt7DgkWwGpo997tBNpFo+kFmu1DyNRsPMX24I0OBCT79tTBs6GANdGd1gZ 8u9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735313870; x=1735918670; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wjgnwQaaUqsMHMMeaH4EeULRZg8SFG+sYNaSJWvGTI8=; b=SRFm0hJXBhvVerPT9kqV6Q4/6ZwiD/W+MMVNechJtsp5O1HQfTXe5vkyOxYWmxQuxr MiSD47l9E+uqdvldzU1odHMWhn4aUTVN/pkmemP8lOI6Hg/4xpWatM3iO3dcBivJHEZC 6UceqjGr8vpU+a4MBI4W8GoNaiSJgeJrIbdmgy3ndOOblGNjwrisDe1IuLeoJ0pAmWbh uN3J3S8f7jieoSbK1p3owD9w9iJi2Qn9PHqNR8AlNCGMHkbzQnhtYwpmKcpIJA74dcVq EHN9mdPp4aiFrOUzFaDUtDbQfPTug+SVRJK7U8j7+d5EzYKgWNB5PVVmxoTDKq9ifnbM YUEw== X-Forwarded-Encrypted: i=1; AJvYcCUF0HOgO10nuzeCPcNKe2JaVuVU76uDA/hAVAf1hHo/tdyUgmTMT5xeCy/f3bUkm3mDMVEF2yzCmb8G6RE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5UMH9Zm7eUdoSfNjycduiMlAM7xvKGr5pzd8SjlYZbFI9Y4m5 POqrOJG4c8Gwfcxlom97HspC9kjRPQoy4oMPHTg6IDMWBdqs2RUUS85JaEaeXyM= X-Gm-Gg: ASbGncv+KqykIeF31AMtuoVMLppztWoECIhJBCsE/7z7qOoGzS6mv6w96lNM4neXvdd Qx9TD0dgquWP3DEUThJ6+PUEtQLjM2N8Sg4Zt9h/TrHAg4QhgsIogW++XpErOIJddQht2xCftHp osLBE0ZOVmGzjId75rxlVebfVbGXP0rMnBeVvnLg559WINd4cRJl9rX8OPKdsB1yHrI6dzfkEYN d2vAemKxITMec7r6eSTzbYhvfpHQTdqsxWv+N8FTuPcrzN45Rlhcxp7ptLYm+lk5fDME+j/wEqp E9R0z/y35+b3pC8nvcDdhZagWsOuKJLzYRlxrw/IfXOi2CCsKZb4erk= X-Google-Smtp-Source: AGHT+IEGvkvAlHWK5MVULJmFCQCKo0kqeWoccs22ihU897t9HZ/OARJlYqw4ShCIrK5b0ups/dCY/Q== X-Received: by 2002:a05:6214:19e7:b0:6d9:fb5:d496 with SMTP id 6a1803df08f44-6dd155f4ba4mr541245416d6.24.1735313870164; Fri, 27 Dec 2024 07:37:50 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181a7fcbsm78872726d6.91.2024.12.27.07.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 07:37:49 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 27 Dec 2024 10:37:47 -0500 To: Honggyu Kim Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel_team@skhynix.com, Andi Kleen Subject: Re: [PATCH] mm/mempolicy: count MPOL_WEIGHTED_INTERLEAVE to "interleave_hit" Message-ID: References: <20241227095737.645-1-honggyu.kim@sk.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241227095737.645-1-honggyu.kim@sk.com> On Fri, Dec 27, 2024 at 06:57:37PM +0900, Honggyu Kim wrote: > The fa3bea4e1f82 introduced MPOL_WEIGHTED_INTERLEAVE but it missed > adding its counter to "interleave_hit" of numastat, which is located at > /sys/devices/system/node/nodeN/ directory. > > It'd be better to add weighted interleving counter info to the existing > "interleave_hit" instead of introducing a new counter > "weighted_interleave_hit". > > Fixes: fa3bea4e1f82 ("mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving") > Cc: Gregory Price > Cc: Andi Kleen > Signed-off-by: Honggyu Kim > --- > mm/mempolicy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Gregory Price