From: Frank Li <Frank.li@nxp.com>
To: Carlos Song <carlos.song@nxp.com>
Cc: andi.shyti@kernel.org, o.rempel@pengutronix.de,
kernel@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, festevam@gmail.com,
linux-i2c@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: imx: switch different pinctrl state in different system power status
Date: Wed, 18 Dec 2024 16:25:51 -0500 [thread overview]
Message-ID: <Z2M938ZSobeYk+1G@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20241218044114.143358-1-carlos.song@nxp.com>
On Wed, Dec 18, 2024 at 12:41:14PM +0800, Carlos Song wrote:
> Switch different pinctrl state in different system power status.
>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change for V2:
> - Add Frank reviewed-by. No code change.
Needn't send v2 if only add review-by tags without any code change.
Frank
> ---
> drivers/i2c/busses/i2c-imx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index b6ed270dd04b..350346a7892c 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1871,6 +1871,7 @@ static int i2c_imx_runtime_suspend(struct device *dev)
> struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev);
>
> clk_disable(i2c_imx->clk);
> + pinctrl_pm_select_sleep_state(dev);
>
> return 0;
> }
> @@ -1880,6 +1881,7 @@ static int i2c_imx_runtime_resume(struct device *dev)
> struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev);
> int ret;
>
> + pinctrl_pm_select_default_state(dev);
> ret = clk_enable(i2c_imx->clk);
> if (ret)
> dev_err(dev, "can't enable I2C clock, ret=%d\n", ret);
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-12-18 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 4:41 Carlos Song
2024-12-18 21:25 ` Frank Li [this message]
2024-12-19 6:02 ` Oleksij Rempel
2024-12-19 7:02 ` Carlos Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2M938ZSobeYk+1G@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=andi.shyti@kernel.org \
--cc=carlos.song@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®