From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 101DA86345 for ; Thu, 19 Dec 2024 16:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734626014; cv=none; b=kklJa2ezRMVqiIa8aAJ255m1gxHN3F+L9M9nL73ifrZiqkfhBGVwivXXAF5TOrQqOVujYx+t86mTHKzGFvqbMCvV4xr4kvK7jlniqSpesE3clxvrosq0jEpEDOlSb5aZ5DgZWOHR0eBI7INUXLqXW9Dx8wZurzbvZKAIeucSgoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734626014; c=relaxed/simple; bh=fzIrFOzCxlnPSF+My9GYRN5gCFNQCpEWgEyFAunja1A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qijIzcO4GcOkQhiCfmYN9svKl2fjayUcS66qnNsspaA5wTKOMqygnfA+NwQaOYBjVhQPzuR+T5ef4aZwtEgmjJ626Gw5m9/Ptsk54r55sQrehVVOdTqiPrKpj0Sxr9w8U2/kIcoXXBLpv9H7TfbRxC3SMUUguPHU/G5GjxC4/Yw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=XCL2gX5N; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="XCL2gX5N" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BJDIYGd025275; Thu, 19 Dec 2024 16:32:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=TcPTvfwqM7u7CKWKVuI4kHjT7dxBSr dnkpU9Qv1a7fw=; b=XCL2gX5NX0oqJuA3wOOs5oS8h3LJTkdu/f/AfEJPJsKnVR nrtDUbFx6HtU8zEH6kdG94Z06/5Wz9nReLaCU5SyXuSpesc3TGraEWQTZnB2Hyuj XMH1JEKVrtCb+2aXjollXPOu2CRHZdOPCZvXzYOX5Fzki4xO4ldgj5M4hbhl8k7v 0BNEQj9r52ZlR8i2MdlBt9nVTTogpHAONIubv6FzEYpf8ZKm7cF48w56L5ZsHgM/ RRO4b71pv9rRyz3OAJtlRxoOp1g39vUo0ifeULVmtWscCfdlKwYOyCg7ulFf91c9 Xcx9919pyKLtWi9Q6PPz3CUx4AGNQEZNTEyqQwug== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mbyhuarn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Dec 2024 16:32:46 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BJGW1qF008150; Thu, 19 Dec 2024 16:32:46 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mbyhuarj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Dec 2024 16:32:46 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BJDKN12024022; Thu, 19 Dec 2024 16:32:44 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43hnuknwxk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Dec 2024 16:32:44 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BJGWgLQ55116142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Dec 2024 16:32:42 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ABC8420043; Thu, 19 Dec 2024 16:32:42 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 68FB320040; Thu, 19 Dec 2024 16:32:42 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 19 Dec 2024 16:32:42 +0000 (GMT) Date: Thu, 19 Dec 2024 17:32:37 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/15] mm: pgtable: introduce generic p4d_alloc_one() and p4d_free() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: g2Lk5szcAk0nRKvYG5-DaIC9sPIAONs9 X-Proofpoint-GUID: l8R-xB1U3F3wOz25pRmxmKnppbEc3euC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0 clxscore=1011 phishscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=369 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412190132 On Wed, Dec 18, 2024 at 09:04:38PM +0800, Qi Zheng wrote: > For these architectures, provide a generic implementation in > asm-generic/pgalloc.h and convert them to use it. And like other levels > of page tables, add statistics for P4D level page table. FWIW, introducing the generic implementation and adding ctor|dtors look as separate changes to me. ... > static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) > { > - if (!pgtable_l5_enabled()) > - return; > - BUG_ON((unsigned long)p4d & (PAGE_SIZE-1)); Or maybe? BUG_ON(!IS_ALIGNED((unsigned long)p4d, PAGE_SIZE)); > - free_page((unsigned long)p4d); > + if (pgtable_l5_enabled()) > + __p4d_free(mm, p4d); > }