From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69AD51CF8B for ; Sun, 22 Dec 2024 05:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734843841; cv=none; b=STYbvw/OyIEVRgbj1hQA3qMr4UKIB3JpjlKIhnWM26UNonOYeipNWoTqKYiI+zIqCpTdZAp159WKKr/dxVTtnklvLI5e0JvPTjyyGgP2S+ypNgLSSdCj39rSJyIIPkdSp/F3qeDr9CdXEUyTsEopIp6h9nYd9AYBjKNHi8BEDYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734843841; c=relaxed/simple; bh=5t7THXeYLUSycCBIfcIjI9AFeum3p8DXxikqHy9ZaHM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qkSdhFXNqD3ZnL0f21Poc5BbUL9XPKTcz3ZZmf4Q1Hn9W5qebz+gK97QB3wMJatgqVdAxeZqU6clNM/Nm3+f1LtwXsrjhwJWtqo/i7x+MChGaignW62CrofPBGanQFaff0OJ+LRKgv+5Q41k/jKpX+BQKoiirMzkjAVKgeb/EMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=EgT2JZqg; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="EgT2JZqg" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7fbbe0fb0b8so2057937a12.0 for ; Sat, 21 Dec 2024 21:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1734843840; x=1735448640; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=aRqCUQOlRgtZiRc2AC0vsaNCGW6lWCvjfZ2K0ekwaBA=; b=EgT2JZqgSnDa3jNbgSKubfCidXRBQO/djx0s5jlkVzbd7F1jq07Lsie5FpxYja4rYf rizS66cHY60SO7rlIacC1NNJVwxPtyXlVipVIQKHlxBOFFU05GbAX60Yi19wH+CZHODW 2DX8yvYpiM4fkHTetAtlgnVqNLHMgEV/6byeZg8xwCGqvPdOBKorIAryXmsqn3wrLDfK VJHwluc9PCS+LLgsxAztSJOdvbtLWa1RTirRvSDwtuCB3KEnoVYNS55znWXY2gxdVgQi KSMRt5MwQ4AnPl/RU0CMZG+C5qtiVQgTRMvUN5s7vHKY1w7raZDSYykWUx05ROBfvvqH ziSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734843840; x=1735448640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aRqCUQOlRgtZiRc2AC0vsaNCGW6lWCvjfZ2K0ekwaBA=; b=GQGLOBmZ6Lc+hImVRwkeyAumuXUkQyIeDD8NyH/mRjKK7mP/crVautbPY7pqJUdBre uifj+C2HC9KUafuUCq2err88tjOf9l7OXfUhEYaSrQEa9riLfkzfvaFjPsAwk9Gu6dC9 V94wThhQv2lfsQV655oo250FJyCRtUY4wp+il/tWZhXIs7DupAMJ6h9BRUVf3aDaeK+y Uuio5YV/N0yRI+l4S1Re9R2pmWUzJCt2f366CI0AcFFgmS8ixczLPaAE6Ex6tGGZERxW GSvmvch6D4NKoCeCLuKxjABmeesXwqSptnUZ1DpO5LQajZgv0q4Xfbb9Q6jlG63mMOvo XqKA== X-Forwarded-Encrypted: i=1; AJvYcCVtWHIpobMeCpRe6o3zTg1wOxVu+Ji/i6F7T9vgCTRtYzL7GEE0zvaSsjnhC8sQtV5bEY580s71ZKuP808=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl8Iuw7+V94znH2jLGTNoKOWYC3NN8VwUnAyKSRJO2zRGE1nlD yz5JGnhDCEIdwTYxeGEC/ntoKpHXTK9bCJ7W7ffVPvfzzVUoANMSAwPMNkvM77w= X-Gm-Gg: ASbGncuS/GjmdheQ3BTrQJJRb+1bUjw3cyK+VjgqC26vW3hAhPsLMFf53V4cqwSxwUe 0Hr7Uf4RMT3U7ONCBd4rIIZhMpR7N7wEjAHRuHQ7iR4zmRZJszNqBGcOdaKdLYCfak6HuQWJM4M mVkhaMbs+HnrMN6deIonl5nptRoBm4jAIYQCmdVqulkciiLicmFc9EhEF4XqsRH6EcpJH/h9DOP Tb1gKAs6qtlLCDY6U4kGElKe4uhKSH7Gg649co6gv2tM3p7Zd52wQofAzwCVjzpKnU5+hUANbFi yp0ACbU= X-Google-Smtp-Source: AGHT+IEz6nqPahLXccgfO9cSrt88CcjDjg2Jbhh4D2ThWhv0YE8dqXggljaBjhQgpLKbihe32IQpgQ== X-Received: by 2002:a17:90b:2e06:b0:2ee:ba0c:1718 with SMTP id 98e67ed59e1d1-2f452ee8cd4mr13567612a91.37.1734843839761; Sat, 21 Dec 2024 21:03:59 -0800 (PST) Received: from gourry-fedora-PF4VCD3F ([75.167.163.61]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ed52dfffsm7819678a91.5.2024.12.21.21.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 21:03:59 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Sun, 22 Dec 2024 00:03:56 -0500 To: David Hildenbrand Cc: Gregory Price , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, kernel-team@meta.com, corbet@lwn.net, osalvador@suse.de, akpm@linux-foundation.org, chenhuacai@kernel.org, kernel@xen0n.name, gregkh@linuxfoundation.org, rafael@kernel.org Subject: Re: [PATCH v3] mm: add build-time option for hotplug memory default online type Message-ID: References: <20241220210709.300066-1-gourry@gourry.net> <5e958aaa-b1ac-4512-a592-0e1612032861@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e958aaa-b1ac-4512-a592-0e1612032861@redhat.com> On Sat, Dec 21, 2024 at 04:30:21PM +0100, David Hildenbrand wrote: > > > -config MEMORY_HOTPLUG_DEFAULT_ONLINE > > - bool "Online the newly added memory blocks by default" > > - depends on MEMORY_HOTPLUG > > +choice > > + prompt "Memory Hotplug Default Online Type" > > + default MHP_DEFAULT_ONLINE_TYPE_OFFLINE > > help > > + Default memory type for driver managed hotplug memory. > > We should call it "hotplugged memory" consistently, which it is from a pure > core-mm perspective ("add memory"). > > "Driver managed" reminds too much about add_memory_driver_managed(), which > is only one case. Maybe just drop the "e.g., page tables" from the examples > below. > I suppose it's accurate that this also affects VM-hotplugged memory, which may not necessarily be "driver managed" in that regard. So it's more accurate to just say "hotplugged memory" - although even that's not quite completely accurate according to the definition in the docs. Either way, will change it to "hotplugged memory". Probably at the point where you have multiple sources affected by this change, you need a udev/systemd setup anyway. We may have to revisit this later, but I doubt it. ~Gregory