From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544921FDA for ; Sun, 22 Dec 2024 09:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734859177; cv=none; b=m36cOruv/BmgHGqDjVS6vHOCvpxjl8N04UVAtHF6pd+jOIdRdDTIcWfF/IxlJ1AOczihCbiKCNO64NuRFXd6Qo8UjzRtmT6KU6Te/3fJYPI/4p0svIMmuDoAqpCrWj7uKd5KjSJzOjktYBt5B/qtLWxBzbi6Gjm30msToDxDrJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734859177; c=relaxed/simple; bh=lwTCsvXR48QIFcbi0uTIMNj9W18+iV2nZJOPQVJGIVg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=blK7JTGQ/lbpH+YBhag+V/0qqwNQVYBQ1NAuE6PFgx+BPjyE1bDF74PlGv6ChElc6VsFk0ntwcwqPdgwwgOjW8Q6v0cwwPq1l+2O8dx6w/Q90xJU3YucGYb/+FyI0qfEzU63I9OI7mmOUhF6NDNJ6wxq074sGuW2TIt8OW7KiKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Whh7YUlO; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Whh7YUlO" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aa543c4db92so321363166b.0 for ; Sun, 22 Dec 2024 01:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734859173; x=1735463973; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pv2LhoQ9a83s98dbiPnH5RnEeAsvfWOy8DtIJXOkHCM=; b=Whh7YUlOXncNY82z63iWq8gHRzHrwHmekb75l5Jx+7wFrLlVutmdNaw3ck4bEi3WAX w4PISTHrY6hFwinTeeVxQSGuMXUPIoNw0jHv4Xwig8HmQlgCBMRzuuvwKi/RnKbyuTxJ P7ToIsRhintNrUttZiGCDyEuC/GBNcnm/KffO2K5Nu4wQ81tiP8SHpacU/d+fLJ274zF H672k/zBn9MLafMub+umHtjpUpUQPNZwuAl32GEuSiO3i/dKerfd2Vk9dFldi5ndruDX KwUIOIt1MBn09IOtSICbzLtIUc+xFdGePVWiN8BxxytDM9rh95evhbJOcCDyhdrTFtXB 18cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734859173; x=1735463973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pv2LhoQ9a83s98dbiPnH5RnEeAsvfWOy8DtIJXOkHCM=; b=X8K1PayrDQBcEaZFglq2ltY4Lt1B6lI4VK4/fLxMMdfLl8oWtZpWuSZEd9C/M4G0IE ITED5r/RKiFSCmJweLgMuEz907kguykvknM5Hx0OYp1iGkSEeG/aALoMWUuHqdbkf70u ib21Reouh+kMPCnP4NWxLBcQ0C9r+oKD4cqVYPtzPPukTFg4I1htHA2r3JLLwwWfKHlb HU6CVFJ+18eoU/Qewl9o3GydKAasWQfaGE3bm9JHueY6aDJ1OUqezliObHds3t5hD3HA JoBP6y8etpnNbp0+Bo9TMD+UVEKe5RDsx0lHcFsGGlnhCiAm6axw2YtEgOeE7YNyD8YN 9nmg== X-Forwarded-Encrypted: i=1; AJvYcCVFCcx0lopsuRJtjS/aPMPnO2wUqEobeC2bFV0/MSaLeBGxKUj6V2G4UF7RVGFIQA52PByedy+3Eq0ncS0=@vger.kernel.org X-Gm-Message-State: AOJu0YyQUOkpZ3UWZfcJZTbyc9HnWNaBbOsKz60BSbxA68KYVTrq0Lic FkFUH2wtPhWpJRbbEV82l7xqPhSRYoq5fqbI9WSkyfUwfgLsUgjjc+icRQ== X-Gm-Gg: ASbGncv4/IUcHqlcu8tqUCwtytE931CHvJYGgDm8Zlbktjm1ZoqAuy6Znu4pEnu6c9s bQGQZMe4eU/TqBYARsfgAtSTslECmaIrfRf/CSrwtGPT+qN0K4RXgVdxczX34Oj4qF3l5SL7Mki iYbfEriWKhRAdMWAMVjShfYWOZX1M7we7dFEGAO6S4ubQykHsO4Rqd6bF5+dIpf0zRYwywPTXIe HiubXsV/L8mpNgf8RVSMJuCLvfFmy/SDQwHFTjIx/n/nbEa8it3MuZVnxXr72tASND7GTUf X-Google-Smtp-Source: AGHT+IHiWQ9hq87j7hXmIKd3v/a0Fs89hk1J2Km9/tLBNVrPl8JLfvm86yU3IGTUohkt2AEmUuVZFg== X-Received: by 2002:a17:907:7f0e:b0:aa6:c169:4e21 with SMTP id a640c23a62f3a-aac27028286mr752417366b.6.1734859173373; Sun, 22 Dec 2024 01:19:33 -0800 (PST) Received: from egonzo (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe4988sm373058666b.124.2024.12.22.01.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 01:19:32 -0800 (PST) Date: Sun, 22 Dec 2024 10:19:28 +0100 From: Dave Penkler To: Greg Kroah-Hartman Cc: Antonio Riccio , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gpib: Rename variable ValidAll Message-ID: References: <2024122201-uncivil-footnote-f584@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024122201-uncivil-footnote-f584@gregkh> On Sun, Dec 22, 2024 at 07:11:40AM +0100, Greg Kroah-Hartman wrote: > On Sat, Dec 21, 2024 at 08:01:23PM +0000, Antonio Riccio wrote: > > --- a/drivers/staging/gpib/uapi/gpib_user.h > > +++ b/drivers/staging/gpib/uapi/gpib_user.h > > @@ -114,7 +114,7 @@ enum bus_control_line { > > ValidSRQ = 0x20, > > ValidATN = 0x40, > > ValidEOI = 0x80, > > - ValidALL = 0xff, > > + VALIDALL = 0xff, > > Why are you only changing one of these? And are you sure that these > values aren't coming from a specification with this type of naming? > > thanks, > > greg k-h I prefer that we keep the camel case definitions in the uapi includes as they are for now so that they remain compatible with the current user space includes. Over time I will release a version of the user space includes that provide compatability definitions for the checkpatch clean version of the uapi includes. This includes the camel case definitions and the typedefs. I will submit a patches for this in the new year. -dave