From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CA0C8BFF for ; Tue, 24 Dec 2024 20:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735073815; cv=none; b=HsM/l4y6nrHVtF66qC0hWCUWfM+MrTLUX375ju2TvAnpWisEkW3O5y/Z/YrZvdEfJoa8dKc9f1HkPpIB3OFMjC0UDSDBJWgsLqBN2kSceHNbMugY8NHLtoCpJKZsOvsmoVRwUZDoQh12RQ03vMOCxHzOYfyqF8Rlm8bNop5sPXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735073815; c=relaxed/simple; bh=iGmiTIKd+yHt0kyFtvujN/5o8bSr6zE1jkdUN6iYd90=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BI+y0Dbx+4c/P+XQ4nWdRoPoew2toMzUL7uDubJGKDtxxB+eHhDcsfWe9dHRQF3oNm3O9x1+zyON3lVDevcZAugImBjEzYXp0EhDXHXD7EiussNprSKzx/Bk/kofdj5UWHjA5IEAYJMoFcBRQ5ry2437BZiMSgXia5Rz3EiPEGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aDWSuQf/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aDWSuQf/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5750C4CED0; Tue, 24 Dec 2024 20:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735073815; bh=iGmiTIKd+yHt0kyFtvujN/5o8bSr6zE1jkdUN6iYd90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aDWSuQf/7e3j9texyQQdkx94qDDZ0cboDzNRBmvCXPHHDMLkaySJ5kvJVVjyH56u6 PgPkSxPSVvLifuCm6obop1sI0Tc2wOxtM/MsbWz/BoMMud2TjHEYngnadoJQYiraFs GxSe4beB4b4Beua0wgmkSDlJuU6aoX5PGLxO+0LERtkgAHrn2BT2yO5XSnUOpMt13D 9g0Dswhrqt1Q2LQpS2RdeJeUiRETNsSwJaPkpiGHqZT+Vdf5EldQbXuaezmTIPlk2b UJpSJT9NJDezXZEqBt73/uGwakmg0gdOvqJE1XLQP/4XVeBKz5NpW1VubTaclYPd4C wmByXigIY5YJQ== Date: Tue, 24 Dec 2024 10:56:54 -1000 From: Tejun Heo To: Henry Huang Cc: void@manifault.com, =?utf-8?B?6LCI6Ym06ZSL?= , "Yan Yan(cailing)" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] sched_ext: initialize kit->cursor.flags Message-ID: References: <20241222154316.67077-1-henry.hj@antgroup.com> <20241222154316.67077-2-henry.hj@antgroup.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222154316.67077-2-henry.hj@antgroup.com> On Sun, Dec 22, 2024 at 11:43:16PM +0800, Henry Huang wrote: > struct bpf_iter_scx_dsq *it maybe not initialized. > If we didn't call scx_bpf_dsq_move_set_vtime and scx_bpf_dsq_move_set_slice > before scx_bpf_dsq_move, it would cause unexpected behaviors: > 1. Assign a huge slice into p->scx.slice > 2. Assign a invalid vtime into p->scx.dsq_vtime > > Signed-off-by: Henry Huang Applied to sched_ext/for-6.13-fixes w/ Fixes tag and stable cc added. Thanks. -- tejun