From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E5DD17C60; Thu, 9 Jan 2025 13:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736430770; cv=none; b=I7JrLRJCIM6crvvK5KxWcTqJkJBl0kHUGEfYlaf3YCUj7QAjtBbY2MIeAR0vysRFc2X4qoJF91oeRMU0qorDuSKEt5VIK0isRXH2stB/6hghZkncpm8hir6MwMNey5dFAjYMqv1EkyV/xm+NLQVgO7KQDPJskVLD4C/0VfX2hiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736430770; c=relaxed/simple; bh=JFYyZToHH6eltx3HQ06c8sjSsRFqTsRJh67eLjM1IqQ=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e9ongkOZYfdHudGjSYP45w8ClrQAbSclrzcLZ99wlsdeUFzImwiG9/sxhdZ+Owm+25m1zzKh/uhTBqX7Wq/ABivxuRhFA1LDlqxbonteIIiZ159RBv4o9OiJMmxeka76yU9VkFe0Ndm59LSFRTyEko3M3eIdXvcKCi1SkITLNSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=pNNPWm8Y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="pNNPWm8Y" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 509Bcvs5000945; Thu, 9 Jan 2025 13:52:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=k8c8+K7xNdhKN6ObZDvGKYyU JWrTBdBVGuHiMj38LUo=; b=pNNPWm8YjpDRQH8HFBp9A11N5kMUWUgxKQD5eY/f ffn7MdFIcDRqDEZjNQ8KmZ6xlqD9yXQ6s/KfaDYs6K2AZ8zONsstC7poCFUVPEvN 1cC+qcAdo/sLtWjHR0IsNexXX6um2A290PmtX0Lge2W1abAk0tw7h4eic/RtzITj dMS3M6G7Ke32QU8HfZ+8Fqm3ZTkakClWbabUi7xssdwnMzvPYFr5f6YkWzXYWpmF RyMLkJbuVMLUHJ08A5i+7SoSoxj2NMFa/p1qhI5X25lvzOXBDbgt9bKbh28d+LTq oFW/unVE4RMJ5QvGFxfOncJpC5SBAS3k/dNfKeZEtr2w9w== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 442drwra3j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2025 13:52:43 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 509DqgUU030445 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Jan 2025 13:52:42 GMT Received: from hu-wasimn-hyd.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 9 Jan 2025 05:52:35 -0800 Date: Thu, 9 Jan 2025 19:22:31 +0530 From: Wasim Nazir To: Dmitry Baryshkov CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Subject: Re: [PATCH v5 5/6] arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 Message-ID: References: <20241229152332.3068172-1-quic_wasimn@quicinc.com> <20241229152332.3068172-6-quic_wasimn@quicinc.com> <4wmxjxcvt7un7wk5v43q3jpxqjs2jbc626mgah2fxbfuouu4q6@ptzibxe2apmx> <37isla6xfjeofsmfvb6ertnqe6ufyu3wh3duqsyp765ivdueex@nlzqyqgnocib> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <37isla6xfjeofsmfvb6ertnqe6ufyu3wh3duqsyp765ivdueex@nlzqyqgnocib> X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: L8tROaV_HNWGSCoNYZAYaW79L5pem04Z X-Proofpoint-GUID: L8tROaV_HNWGSCoNYZAYaW79L5pem04Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 impostorscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 clxscore=1015 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501090111 On Fri, Jan 03, 2025 at 09:58:40PM +0200, Dmitry Baryshkov wrote: > On Sat, Jan 04, 2025 at 12:29:07AM +0530, Wasim Nazir wrote: > > On Fri, Jan 03, 2025 at 12:31:55PM +0200, Dmitry Baryshkov wrote: > > > On Fri, Jan 03, 2025 at 12:37:50PM +0530, Wasim Nazir wrote: > > > > On Fri, Jan 03, 2025 at 07:50:43AM +0200, Dmitry Baryshkov wrote: > > > > > On Thu, Jan 02, 2025 at 02:37:39PM +0530, Wasim Nazir wrote: > > > > > > On Mon, Dec 30, 2024 at 05:45:39PM +0200, Dmitry Baryshkov wrote: > > > > > > > On Sun, Dec 29, 2024 at 08:53:31PM +0530, Wasim Nazir wrote: > > > > > > > > Add device tree support for QCS9075 Ride & Ride-r3 boards. > > > > > > > > > > > > > > > > QCS9075 lacks the safety monitoring features of Safety-Island (SAIL) > > > > > > > > subsystem which is available in QCS9100, and it affects thermal > > > > > > > > management. > > > > > > > > > > > > > > > > Also, between ride and ride-r3 ethernet phy is different. > > > > > > > > Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > > > > > > > > > > > > > > Your board files duplicate sa8775p-ride-r3.dts and sa8775p-ride.dts, but > > > > > > > include them. Existing qcs9100-ride-r3.dts and qcs9100-ride-r3.dts just > > > > > > > include corresponding SA8775P files. > > > > > > > > > > > > > > This is not ideal for the following reasons: > > > > > > > - The approach is not uniform (between QCS9100 and QCS9075), which might > > > > > > > lead to mistakes. > > > > > > > - The approach ends up duplicating DT code unnecessarily, which can lead > > > > > > > to issues being patches in the one board file, but not in the other > > > > > > > file. > > > > > > > > > > > > > > If there are any reasons why you want to follow this approach, they must > > > > > > > be a part of the commit message. > > > > > > > > > > > > > > > > > > > Hi Dmitry, > > > > > > > > > > > > Initially, we included the DTS [1] file to avoid duplication. However, > > > > > > based on Krzysztof's previous suggestion [2], we change to this format. > > > > > > > > > > > > Please let us know how to proceed further on this. > > > > > > > > > > Krzysztof asked you to include DTSI files instead of including DTS > > > > > files. Hope this helps. > > > > > > > > Are you suggesting that we should also modify the 9100-ride files to > > > > include DTSI instead of DTS for consistency between QCS9100 and QCS9075? > > > > However, this would result in the duplication of Ethernet nodes in all > > > > the ride board files. Would that be acceptable? > > > > > > git mv foo.dts foo.dtsi > > > echo '#include "foo.dtsi"' > foo.dts > > > git add foo.dts > > > git commit > > > > > > > We cannot convert sa8775p-ride-r3.dts and sa8775p-ride.dts to .dtsi as > > they represent different platforms. In patch [1], we included these DTS > > files to reuse the common hardware nodes. > > > > Could you please advise on how we should proceed with the following > > approaches? > > > > a) Previous approach [1]: > > Include sa8775p-ride-r3.dts and sa8775p-ride.dts in the qcs9075-ride > > platform DTS, similar to the qcs9100-ride platform DTS. This approach > > avoids duplicating Ethernet nodes and maintains uniformity. However, it > > involves including the DTS file directly. > > > > b) Current suggestion: > > Include sa8775p-ride.dtsi in the qcs9075-ride platform DTS and also > > modify the qcs9100-ride platform DTS files to maintain uniformity. This > > approach results in duplicating Ethernet nodes. > > > > Please let us know your recommendation to finalize the DT structure. > > sa8775p.dtsi > `__sa8775p-ride.dtsi > `__sa8775p-ride-r2.dtsi > `__sa8775p-ride.dts > `__qcs9100-ride.dts > `__qcs9075-ride.dts > `__sa8775p-ride-r3.dtsi > `__sa8775p-ride-r3.dts > `__qcs9100-ride-r3.dts > `__qcs9075-ride-r3.dts Thanks Dmitry, we need slight modification to the above structure as we don't have any ride-r2 boards, so we want to go ahead with this structure: sa8775p.dtsi `__sa8775p-ride-common.dtsi `__sa8775p-ride.dtsi `__sa8775p-ride.dts `__qcs9100-ride.dts `__qcs9075-ride.dts `__sa8775p-ride-r3.dtsi `__sa8775p-ride-r3.dts `__qcs9100-ride-r3.dts `__qcs9075-ride-r3.dts > > > > > [1] https://lore.kernel.org/all/20241119174954.1219002-6-quic_wasimn@quicinc.com/ > > > > > > > > > > > > > > > > > > > > > > > [1] https://lore.kernel.org/all/20241119174954.1219002-6-quic_wasimn@quicinc.com/ > > > > > > [2] https://lore.kernel.org/all/8cf9edc0-a0cb-4fd0-b10e-2138784dfba3@kernel.org/ > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Wasim Nazir > > > > > > > > --- > > > > > > > > arch/arm64/boot/dts/qcom/Makefile | 2 + > > > > > > > > arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 46 ++++++++++++++++++++ > > > > > > > > arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 46 ++++++++++++++++++++ > > > > > > > > 3 files changed, 94 insertions(+) > > > > > > > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > > > > > > > create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > > > > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > > > > > > > index 78613a1bd34a..41cb2bbd3472 100644 > > > > > > > > --- a/arch/arm64/boot/dts/qcom/Makefile > > > > > > > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > > > > > > > @@ -118,6 +118,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > > > > > > > > dtb-$(CONFIG_ARCH_QCOM) += qcs8300-ride.dtb > > > > > > > > dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > > > > > > > > dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > > > > > > > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > > > > > > > > +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > > > > > > > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > > > > > > > > dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > > > > > > > > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > > > > > > > new file mode 100644 > > > > > > > > index 000000000000..d9a8956d3a76 > > > > > > > > --- /dev/null > > > > > > > > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > > > > > > > > @@ -0,0 +1,46 @@ > > > > > > > > +// SPDX-License-Identifier: BSD-3-Clause > > > > > > > > +/* > > > > > > > > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > > > > > > > > + */ > > > > > > > > +/dts-v1/; > > > > > > > > + > > > > > > > > +#include "sa8775p-ride.dtsi" > > > > > > > > + > > > > > > > > +/ { > > > > > > > > + model = "Qualcomm Technologies, Inc. QCS9075 Ride Rev3"; > > > > > > > > + compatible = "qcom,qcs9075-ride-r3", "qcom,qcs9075", "qcom,sa8775p"; > > > > > > > > +}; > > > > > > > > + > > > > > > > > +ðernet0 { > > > > > > > > + phy-mode = "2500base-x"; > > > > > > > > +}; > > > > > > > > + > > > > > > > > +ðernet1 { > > > > > > > > + phy-mode = "2500base-x"; > > > > > > > > +}; > > > > > > > > + > > > > > > > > +&mdio { > > > > > > > > + compatible = "snps,dwmac-mdio"; > > > > > > > > + #address-cells = <1>; > > > > > > > > + #size-cells = <0>; > > > > > > > > + > > > > > > > > + sgmii_phy0: phy@8 { > > > > > > > > + compatible = "ethernet-phy-id31c3.1c33"; > > > > > > > > + reg = <0x8>; > > > > > > > > + device_type = "ethernet-phy"; > > > > > > > > + interrupts-extended = <&tlmm 7 IRQ_TYPE_EDGE_FALLING>; > > > > > > > > + reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>; > > > > > > > > + reset-assert-us = <11000>; > > > > > > > > + reset-deassert-us = <70000>; > > > > > > > > + }; > > > > > > > > + > > > > > > > > + sgmii_phy1: phy@0 { > > > > > > > > + compatible = "ethernet-phy-id31c3.1c33"; > > > > > > > > + reg = <0x0>; > > > > > > > > + device_type = "ethernet-phy"; > > > > > > > > + interrupts-extended = <&tlmm 26 IRQ_TYPE_EDGE_FALLING>; > > > > > > > > + reset-gpios = <&pmm8654au_2_gpios 9 GPIO_ACTIVE_LOW>; > > > > > > > > + reset-assert-us = <11000>; > > > > > > > > + reset-deassert-us = <70000>; > > > > > > > > + }; > > > > > > > > +}; > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > > > > > > > new file mode 100644 > > > > > > > > index 000000000000..3b524359a72d > > > > > > > > --- /dev/null > > > > > > > > +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride.dts > > > > > > > > @@ -0,0 +1,46 @@ > > > > > > > > +// SPDX-License-Identifier: BSD-3-Clause > > > > > > > > +/* > > > > > > > > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > > > > > > > > + */ > > > > > > > > +/dts-v1/; > > > > > > > > + > > > > > > > > +#include "sa8775p-ride.dtsi" > > > > > > > > + > > > > > > > > +/ { > > > > > > > > + model = "Qualcomm Technologies, Inc. QCS9075 Ride"; > > > > > > > > + compatible = "qcom,qcs9075-ride", "qcom,qcs9075", "qcom,sa8775p"; > > > > > > > > +}; > > > > > > > > + > > > > > > > > +ðernet0 { > > > > > > > > + phy-mode = "sgmii"; > > > > > > > > +}; > > > > > > > > + > > > > > > > > +ðernet1 { > > > > > > > > + phy-mode = "sgmii"; > > > > > > > > +}; > > > > > > > > + > > > > > > > > +&mdio { > > > > > > > > + compatible = "snps,dwmac-mdio"; > > > > > > > > + #address-cells = <1>; > > > > > > > > + #size-cells = <0>; > > > > > > > > + > > > > > > > > + sgmii_phy0: phy@8 { > > > > > > > > + compatible = "ethernet-phy-id0141.0dd4"; > > > > > > > > + reg = <0x8>; > > > > > > > > + device_type = "ethernet-phy"; > > > > > > > > + interrupts-extended = <&tlmm 7 IRQ_TYPE_EDGE_FALLING>; > > > > > > > > + reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>; > > > > > > > > + reset-assert-us = <11000>; > > > > > > > > + reset-deassert-us = <70000>; > > > > > > > > + }; > > > > > > > > + > > > > > > > > + sgmii_phy1: phy@a { > > > > > > > > + compatible = "ethernet-phy-id0141.0dd4"; > > > > > > > > + reg = <0xa>; > > > > > > > > + device_type = "ethernet-phy"; > > > > > > > > + interrupts-extended = <&tlmm 26 IRQ_TYPE_EDGE_FALLING>; > > > > > > > > + reset-gpios = <&pmm8654au_2_gpios 9 GPIO_ACTIVE_LOW>; > > > > > > > > + reset-assert-us = <11000>; > > > > > > > > + reset-deassert-us = <70000>; > > > > > > > > + }; > > > > > > > > +}; > > > > > > > > -- > > > > > > > > 2.47.0 > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > With best wishes > > > > > > > Dmitry > > > > > > > > > > > > > > > > > > Thanks & Regards, > > > > > > Wasim > > > > > > > > > > -- > > > > > With best wishes > > > > > Dmitry > > > > > > > > > > > > Thanks & Regards, > > > > Wasim > > > > > > -- > > > With best wishes > > > Dmitry > > > > Thanks & Regards, > > Wasim > > -- > With best wishes > Dmitry Thanks & Regards, Wasim