From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97BC11A83E1 for ; Thu, 9 Jan 2025 12:14:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736424867; cv=none; b=MiJ6NAZv9ihGbtVz9yAryiNUdWIgKjQYBNI7ae4Di7pj40ch7BYAlvGVm4rNfLcEyrzi+Ypts5pJTDzFpFVsUe1tSzjJnWyFe6pN7aDeW39oYLXeONlipE2Wyk2h3ZUT6BzeWFZbeoyXfgs0KtMtEd+spN0kEXUIcczIbe95tyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736424867; c=relaxed/simple; bh=8Vv2C9JrNlsK2WjWmy3HhCT7El+dsWz+YiIQGAZv1Cs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KHJ47JwsZGKl7EVajv6ZN8K7t1C38omFsmMJSnjdBOgVY6ETLA5ZV4iQQfsNjDbUY+uAgNdK3WYo6rvWzQapMCm96+dgNKn5E1wawQd3NDqe8rYUxWSTXdhYQbINYI9nIzMvh2nUxjrieUvMmj4djTdrPgC8ty0FLKhZ+8XgqII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hGQcPTj5; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hGQcPTj5" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4363ae65100so9371335e9.0 for ; Thu, 09 Jan 2025 04:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736424864; x=1737029664; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qgi4e6BoGIUkq88BVzT7YBbI2Ar0NhYklw/AGMjsAlg=; b=hGQcPTj5OD9dr8icYh3aUe8YZzGY5BLBWeiq3C8BW64bbwyrj80rkGOrkoXCHFboN3 YcJXgvHM52xjTgM8mTFuxpJEIGEsm0k+EKNpQs7WpWeYhy1jHpY339/dEGlqO89xrDcR lsQi9cRczh2+0eJnutu/nLsGmoqBH3nC7LRj0Bsn++VNllRz5yy7B3EsdcFBsLbfA3gC qsZDleTZmI+iDyRl2GTm9MuDzbQah6X/Dplx/uS0Rm2wTFlsm9Mo7kXMdRrYG/wcKRqO 5+BQJT+i5uy6sjBHQq3p9p5SEyJAPbdofNa9tCPzlQ4E0yu+Cz92/MSzAnVMCAgo+kcj dFmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736424864; x=1737029664; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qgi4e6BoGIUkq88BVzT7YBbI2Ar0NhYklw/AGMjsAlg=; b=G/QK1qDwsoZAsv+w8fZzYoZNgK5TSpfGDJmStTwkVpiWO0HHFapvqt1uHpcceymw0G bXVAsbytHUR3URdOFd4xzEsxGzbfC2cI4DVpcQyAxRqZevz+ZIS1YHQJ/nVsrQWZzieL XrZgHY4U/GnSKGdSrelC2GcTBWwt8wOH3EA26J7C1H8Z/bgldMs5ckoy+/f6XR9NQgMP LiZ0HFnc0frNA8dHHleIFIt3y+Zo2iifNx9m//TE9JwTACXMldloGwyXG4RZERFu5CUf batLHvSrBqYvGhMwg3okj9XImst//s6jq01dA0X2exGb6nv7M3ocmyboxjbqLb2J6wpR J3nA== X-Forwarded-Encrypted: i=1; AJvYcCVv8keuFu7X2j9iFHTUkrUZvnlqryV5GYMvAWlUnQyGh3dLXV5atd3UquK9GfIeuaojly835ghoIT2oDNM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5H/JTSzNBoJj8/p6JHLfwI2jigcatvsc490OOKi9JJteXb76W FS9L5LSbOSaf1jpYn2mo2i7YSkbLgDjJCljBbP0hJg01n5a6dbi2Q2/HTQAxTMU= X-Gm-Gg: ASbGnctc0oARHGUTvn/nJpbtqELe5V+LmoTKubo6ZNS17dLhV2yIoSMh2L8bqB8AEfq MBrnFIqAItJ6XHlZs2uhNBH4/cfEdbWWTEGPTX6toUl2Fe5zfQpQFsR5nrBbNsRfyifmVJQ4eNf JvXp2hgrEVeZ/sWGLTiUf4W2mHkoDEMjIFv6YXGk9REHQbG4cPY+dJ18z2qyGDj2Ur8g+JMyl6f Lf5JzhXYFVYHbsF2AFMQ0ByN3epjRnuttDdJdovsjNArZ+jcBNG4Tw= X-Google-Smtp-Source: AGHT+IFZfJfwssLNpBYM5MjiXFRSaZImZ4dWDIr4RYjQoPZfimRRPYITmNGGjTmVo8KU+9ieJp1Ivg== X-Received: by 2002:a05:600c:6b6f:b0:436:e86e:e4ab with SMTP id 5b1f17b1804b1-436e86ee529mr33625975e9.30.1736424863901; Thu, 09 Jan 2025 04:14:23 -0800 (PST) Received: from linaro.org ([86.121.162.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2da6401sm53853955e9.2.2025.01.09.04.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 04:14:23 -0800 (PST) Date: Thu, 9 Jan 2025 14:14:21 +0200 From: Abel Vesa To: Bjorn Andersson Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Johan Hovold Subject: Re: [PATCH v4 1/4] drm/dp: Add helper to set LTTPRs in transparent mode Message-ID: References: <20250108-drm-dp-msm-add-lttpr-transparent-mode-set-v4-0-918949bc2e3a@linaro.org> <20250108-drm-dp-msm-add-lttpr-transparent-mode-set-v4-1-918949bc2e3a@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 25-01-08 16:17:47, Bjorn Andersson wrote: > On Wed, Jan 08, 2025 at 04:31:43PM +0200, Abel Vesa wrote: > > According to the DisplayPort standard, LTTPRs have two operating > > modes: > > - non-transparent - it replies to DPCD LTTPR field specific AUX > > requests, while passes through all other AUX requests > > - transparent - it passes through all AUX requests. > > > > Switching between this two modes is done by the DPTX by issuing > > an AUX write to the DPCD PHY_REPEATER_MODE register. > > > > Add a generic helper that allows switching between these modes. > > > > Also add a generic wrapper for the helper that handles the explicit > > disabling of non-transparent mode and its disable->enable sequence > > mentioned in the DP Standard v2.0 section 3.6.6.1. Do this in order > > to move this handling out of the vendor specific driver implementation > > into the generic framework. > > > > Tested-by: Johan Hovold > > Reviewed-by: Dmitry Baryshkov > > Reviewed-by: Johan Hovold > > Signed-off-by: Abel Vesa > > --- > > drivers/gpu/drm/display/drm_dp_helper.c | 62 +++++++++++++++++++++++++++++++++ > > include/drm/display/drm_dp_helper.h | 2 ++ > > 2 files changed, 64 insertions(+) > > > > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c > > index da3c8521a7fa7d3c9761377363cdd4b44ab1106e..fa7eff94d408718a1762834597f0cd51376d2596 100644 > > --- a/drivers/gpu/drm/display/drm_dp_helper.c > > +++ b/drivers/gpu/drm/display/drm_dp_helper.c > > @@ -2817,6 +2817,68 @@ int drm_dp_lttpr_max_link_rate(const u8 caps[DP_LTTPR_COMMON_CAP_SIZE]) > > } > > EXPORT_SYMBOL(drm_dp_lttpr_max_link_rate); > > > > +/** > > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > > kernel-doc functions should have () suffix Yes, will add. > > > + * @aux: DisplayPort AUX channel > > + * @enable: Enable or disable transparent mode > > + * > > + * Returns 0 on success or a negative error code on failure. > > And this should be "Return: ...". Will fix as well. > > > + */ > > +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable) > > +{ > > + u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT : > > + DP_PHY_REPEATER_MODE_NON_TRANSPARENT; > > + int ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, val); > > + > > + if (ret < 0) > > + return ret; > > + > > + return (ret == 1) ? 0 : -EIO; > > +} > > +EXPORT_SYMBOL(drm_dp_lttpr_set_transparent_mode); > > + > > +/** > > + * drm_dp_lttpr_init - init LTTPR transparency mode according to DP standard > > + * > > Documentation also explicitly says not to leave a blank line here... Will drop the blank line. > > Regards, > Bjorn > Thanks for reviewing! Abel