From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 239591DF725 for ; Tue, 7 Jan 2025 14:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736260716; cv=none; b=sh+RnEu1cJRGDlrnhAjgvx8CSe2r2n7DD+rvXyLTsy6tboTEMNflkZlTrhwWqREIZ7VzZ4SVsKDVg6WA102DASlBucj7aRPjrSHPVPZ/FDGLAC2HX8fVEmnalUwrtwXv2sUj7QEWEyHT2S3NjQ8xfeBsbCS+9Dxd8ZfJ8H+Rp1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736260716; c=relaxed/simple; bh=EAOJ9Cy4whUatGc01tErXLm3u1bA9IGZtdlzgfVjk20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lGPADo/xLDyWwKAiHttX3t8cwY7p0gqvmdnye5BPyq3BSJjRDsZq5Box8M2LWMpprTAB9nakKCeMVn5qnbymz9O3aK+Z3BYAQhUyP9J4mnKiQ12B5NyiMz3F5gORlNCpBQLtFIEzPDNuF7O3pIZzvLY3j3hmTJKFZRJl5PsGiyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jhbVWt/P; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jhbVWt/P" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-436326dcb1cso104414955e9.0 for ; Tue, 07 Jan 2025 06:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736260710; x=1736865510; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qo9P0YtQuqJXCqr05Qb0Bv72irxJaHvuePVGR1s+GJw=; b=jhbVWt/PCJUaK4jCxtfVQcf/BqyhKHT1mcv/XIzkoA+pKCBd+kbyD2timM2jWDmKmt h32X3FdDoyFb/IpWQV3BY+zV8QJ3Fv2PECWFtSnueoyDe/xtsm1JZzTtASshXUkXRdqX uxuQZnHcs8va5viV5jlcO0NF9ZAoCTs39ZYAuT7pqPx54TBFc5eClGCdPLeOW8YYOtBy 1FiSvzhj3aPmGWRWkvdtosm0UM9XE606VmP8myXSC5N2e9UeeEzPNeMcjOudu+Q6Cm95 VU9q4NqZ4od6BacY9QNS9JLAri5TGpstkHHaWIYm4Ufx3YQJqqEZ0dWXpiW40SRQN/sb u+Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736260710; x=1736865510; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qo9P0YtQuqJXCqr05Qb0Bv72irxJaHvuePVGR1s+GJw=; b=hTZCG+QptQs0f4Ih1r+ZP65r08iZFSZnV2BP4tpWSKSXwgc7cipY0M9DO6VkdhTwrQ u1CLjvfT84tBWF7vNsYmDzF0W6oVCrpl4wwo/5M3V8Bpz1ju/hPsgpBaIaCZv8leIDO0 8GrvAiBrBffL3DYzOPE19dNOBX2/SU+7sr2aIQ+ePiJCtfOcYFtHbmQQAyOKN5aP4w43 wnXGdAlAIoy32u7BLFyAJGTorR+GMCPsCTB5jbIRW3BaPuESFJl6LnR/KcHih8fRkjH4 UTfKsInpSMMo0bA+AOiPgPM6DnN3jF/+EEK2lRVYwiSkbmUSfo5YHqA1gVOK9k57hilB UYGg== X-Forwarded-Encrypted: i=1; AJvYcCVUFJvWIjVycmmoNWbWYF9AXyVC8ZTOeeIcex0bV1eLhCkuosnSSHau55a/b1tPJvteiHE/5zxrqMhy+Z8=@vger.kernel.org X-Gm-Message-State: AOJu0YypYDus+ZQvyP5oDIHByqEeV8x616vUYOMM2pBgP7YwBoUOXUQh 5IUVDbM7FXhE6F9jqI6xCOHeb1rYoLMq9SLdNuELMEUjL3UTue4gK0/qdsesgyxtrqW+tjxyhw7 i X-Gm-Gg: ASbGncte617emSijC3F3msAbkbbOtL77rA5XwR2YPGT+V4IQzELprKz+JLNeWWgxczJ v3eJMh71cuFDzfDUG0G4EmZhbTWPkjG6MEvScJAaOoRUBj+n7eDYabd4AS2tIp7nNd3eM/oeFaz QTIDSSlukXhEnITROlYHA/lOrsZH+eR+eAivKrNN8/JwVnQ9SH5DfNoPOzgWp0E3rbCVT5kuvNH kk90+SGXIXvaa5H0TV/2ws82j9pbHUD+/kG+FI6sPf3ZXr0X+usDC0= X-Google-Smtp-Source: AGHT+IFIF4I4xKP46VS5zqZ0+vproNT/iu73lhD9pH8Af1WZX6MRdbruwQE3ujvVRC8CO0SgR54++A== X-Received: by 2002:a05:600c:68d7:b0:434:f270:a513 with SMTP id 5b1f17b1804b1-4366d357401mr499304255e9.29.1736260710425; Tue, 07 Jan 2025 06:38:30 -0800 (PST) Received: from linaro.org ([86.121.162.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8acadcsm50023052f8f.105.2025.01.07.06.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 06:38:29 -0800 (PST) Date: Tue, 7 Jan 2025 16:38:28 +0200 From: Abel Vesa To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Johan Hovold , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: x1e78100-t14s: Enable fingerprint reader Message-ID: References: <20250107-x1e80100-t14-enable-fingerprint-sensor-v1-1-8fd911d39ad1@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107-x1e80100-t14-enable-fingerprint-sensor-v1-1-8fd911d39ad1@linaro.org> On 25-01-07 15:35:07, Abel Vesa wrote: > On Lenovo ThinkPad T14s, the fingerprint reader placed in the power > button is connected via the usb_2 controller. The controller has only > a USB 2.0 PHY which is then connected via a NXP PTN3222 eUSB2 repeater, > which in turn is connected to the Goodix fingerprint reader. > > So enable all the usb_2 controller and PHY nodes, set dual-role mode to > host and describe the eUSB2 repeater in order to get the fingerprint > reader discovered. > > Signed-off-by: Abel Vesa Turns out that on resume a couple of things are broken w.r.t. to the usb_2 controller: [ 41.104913] arm-smmu 15000000.iommu: Unhandled context fault: fsr=0x402, iova=0xe2010600, fsynr=0x110001, cbfrsynra=0x14e0, cb [ 41.104936] arm-smmu 15000000.iommu: FSR = 00000402 [Format=2 TF], SID=0x14e0 [ 41.104950] arm-smmu 15000000.iommu: FSYNR0 = 00110001 [S1CBNDX=17 PLVL=1] [ 51.420689] xhci-hcd xhci-hcd.6.auto: xHCI host not responding to stop endpoint command [ 51.420702] xhci-hcd xhci-hcd.6.auto: xHCI host controller not responding, assume dead [ 51.420720] xhci-hcd xhci-hcd.6.auto: HC died; cleaning up [ 51.420836] usb 5-1: PM: dpm_run_callback(): usb_dev_resume returns -22 [ 51.420864] usb 5-1: PM: failed to resume async: error -22 So do not apply this yet. Sorry for not testing this properly before sending.