From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9A7E1E25FE for ; Tue, 7 Jan 2025 12:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736252652; cv=none; b=GeyZNfWQLsVy+nhJ7hedBZHtRO/9zC4FgPj2uxGuqj9QbPWElDFX7Ff46fvbF6HabFhiae+4LABfY0KhGwH8c+20w4i9APex5M9LtBr4yycm3GHMCdrKM9z0+P4E0RV0QT61HEaF1FNFBkuNOtbqw7REqp5IfeoVxz7xc2/oVEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736252652; c=relaxed/simple; bh=+KWLGuLsXgAN/9S79qObo2k7wzmj+uimF75O9TxmWjo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cWEuUs3L1n7jVE6O2ogJOl2r1wGsckWp6GMaymVPDBPnDXaE7ASzXkDByfLn9a1o1QPc0TVOL8y5q5H6K8LRokPD9Q+w+yFWLBFjppEf6VC92efWlHiZXn8IJ1Luicdx6UxZOQYpk6hPFUEZj0Isigwlrh9pHn54w6UmlrBbxHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0701FC4CEE1; Tue, 7 Jan 2025 12:24:10 +0000 (UTC) Date: Tue, 7 Jan 2025 12:24:08 +0000 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Ard Biesheuvel , Ryan Roberts , Mark Rutland , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/mm: Rename pte_mkpresent() as pte_mkvalid() Message-ID: References: <20250107023016.829416-1-anshuman.khandual@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107023016.829416-1-anshuman.khandual@arm.com> On Tue, Jan 07, 2025 at 08:00:16AM +0530, Anshuman Khandual wrote: > pte_present() is no longer synonymous with pte_valid() as it also tests for > pte_present_invalid() as well. Hence pte_mkpresent() is misleading, because > all that does is make an entry mapped, via setting PTE_VALID. Hence rename > the helper as pte_mkvalid() which reflects its functionality appropriately. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Ard Biesheuvel > Cc: Ryan Roberts > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Acked-by: Catalin Marinas