From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C291118B494 for ; Tue, 7 Jan 2025 18:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736275961; cv=none; b=dRfDJTnhm0D5R0dObhDKIXVWphTWcDUSPuPGfBnJdW/lxy3OXx6iDa5t157nAN38t8S8AdanULKQfBvit1Qi/6h9iASKZ5qW4d4gfXwSObaEXM71ejjIm485+jCSaD4tbO73W8a/arQs3/UMVMAA/gHv8CmT71/XrjSUP9B7Fm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736275961; c=relaxed/simple; bh=1hHQ0ZILH6tu2KB07pQZUQRpZcZzQcqluQrI2htZvYA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sx4EleQNU2trZgJYk0VCUw4OVOjeRDExQA8cVJ3Qb44GL3SuxQgZhIJlynW4I+4y01vp/OWqG6YF3zaqLSJvhxUE2AQ+cebJdLIW/YFDndWJ8mmAVeQA8M+B/JCOxKwWxiGCB+tG/yNL5JPDWE8poG9wylmy2j5nOGMuF1JVyOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JCbioXui; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JCbioXui" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2163affd184so9335ad.1 for ; Tue, 07 Jan 2025 10:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736275959; x=1736880759; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WKYDPoJDf5G97ixoaLVA9VDa5ofJjl1G+c8UFWYhtHY=; b=JCbioXuif5RzjFrqpYr8QTV0Lc4XuTaXr2EMdhbZlUye0zvIavAjskx8J2/1VVP28g 2d6FsXA6O50LsC70OW1Bgxs+FH0o63XbczwuqTSKZEbOxTGxw56C39PWn90xbhURudt6 xvZDdrNOTfaknae9luT/qjVdDG9NUHmjbU+3b+EMhSsJUae0CJaVjGQyspLfzuIVMN5Q nzW5Kxjq7FveiE/177YXjkq/CS7tpIi03FrwNCS8rp2pozi41PnW0cDXGWhOtZ82K8y4 xymDu0fcROo2Tia37XedJGqPoWgRwdIIw+vnJbBs6LDcXhYZK/zIpTB2xOio2oMNy0rc owVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736275959; x=1736880759; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WKYDPoJDf5G97ixoaLVA9VDa5ofJjl1G+c8UFWYhtHY=; b=a1S2pGhe4NT0HqnbcQXACeEPhKLg8c5GxOw6rnWaQWx0N8W8kAhy9kuZ2KhjSCLJ+f iazsdpyH07o6EDMx7NSZZuH29UyxR4tFqjvi45NNXk7ZGdbBwRdhdT719GaHbYOJZk/G jvsq3itmIUDqigd7x2GCj1ljMsYv60vgChTjzna4MhP2tnqiqaYXrvwyeFHk2AeMIBfS Ry9p4+MJVBmB4p4olLo/JHIh5r+52KGrJ/FVnrHrQk0bTtPJxczio4NpZVVB6r1MVaDZ 0pVuNzSTdt2a6IJHFWSuejRa+xEX73p9jBdrmY/VUT96OibP151ZMOoiogfBmjMJ0eD0 FOJA== X-Forwarded-Encrypted: i=1; AJvYcCWen6SuEjjWLflr5UXNZvWplIYVh/svcISKAlJ0CA7neNjg3ywA/1Pw66JeFv7mJa8uxmfqNgM8yOlBArc=@vger.kernel.org X-Gm-Message-State: AOJu0Yya8x569EH+F71Edp2Cq0qRSx7tV4zRE92DE4VDXL3S50kNANjJ sHhA/zHdevaxiYE+gcdaqxPSMYXe5YNnPLN53KXjyF8SQYbD5jLgrFjk/Rzn7A== X-Gm-Gg: ASbGncsDdQ/hH1hBAR5VbsyjyBdgOLw7MiNbH5hLEad8CkkysktWy9jGDdhJsu+Bj8U S6spmNTFx1hRT300Y+m2UOKokO8nCWFgqPDz02BGIY8BIBylgegVAQtNbCZPLt1GTaP93qGIbWR RLKZDOBPAOVqcxbYOW6Gkl4F0bDuI1alOdEIIUTvb4Vz1xkPm9DqYS+p04VY3XeelNKNvKuJ8O7 /03ebanAAcIU0l5pTrAiq7LPkvX3Kd788kenJdzdFXbJNlo06BpmL5+ X-Google-Smtp-Source: AGHT+IHYa3h3hF3pQ/cbQJnbO0VppeiwjRz7wH+8tSVibTYQBeWBH2bqNQmCQx5+KIvI+cU46YzkVg== X-Received: by 2002:a17:902:c406:b0:215:44af:313b with SMTP id d9443c01a7336-21a83fe0bcfmr127435ad.0.1736275958764; Tue, 07 Jan 2025 10:52:38 -0800 (PST) Received: from google.com ([2620:15c:2d:3:be5c:2ec2:68e6:cb66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc962d53sm314249785ad.33.2025.01.07.10.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 10:52:38 -0800 (PST) Date: Tue, 7 Jan 2025 10:52:34 -0800 From: Isaac Manjarres To: Lorenzo Stoakes Cc: Andrew Morton , kaleshsingh@google.com, jstultz@google.com, aliceryhl@google.com, surenb@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/2] Cleanup for memfd_create() Message-ID: References: <20250102230658.1112261-1-isaacmanjarres@google.com> <9ee67338-b0af-4fdf-b8d6-bab4e6c4ccc3@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ee67338-b0af-4fdf-b8d6-bab4e6c4ccc3@lucifer.local> On Tue, Jan 07, 2025 at 03:09:49PM +0000, Lorenzo Stoakes wrote: > On Thu, Jan 02, 2025 at 03:06:53PM -0800, Isaac J. Manjarres wrote: > > memfd_create() handles all of its logic in a single function. Some of > > the logic in the function is also somewhat contrived (i.e. copying the > > memfd name from userpace). > > > > This series aims to cleanup memfd_create() by splitting out the logic > > into helper functions, and simplifying the memfd name copying to make > > the code easier to follow. > > > > This has no intended functional changes. > > > > What is this against? I tried b4 shazam'ing it against mm-unstable and it > didn't apply. Could you rebase on mm-unstable? > > Thanks! > Hi Lorenzo, I had uploaded this against Linus' master branch. However, I've uploaded a second version that is just a rebase on mm-unstable, as requested: https://lore.kernel.org/all/20250107184804.4074147-1-isaacmanjarres@google.com/ Thanks, Isaac