From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8E3C1E47AD for ; Tue, 7 Jan 2025 23:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736291503; cv=none; b=HWxgwA8QFXPULqk4Je2iFWnCdSJndQ8MPpDiC+Hsfk+E+LsZBSRIQpWIGNDFC3tvWUpyYx8rj3RMWpVwoFZooMeaJ7Skh2kposlfbm64PR3lFVB8//uIJo3SfTSz2y1pBjjXqVaHZGUEUmHJEMY0yiaJ1Alsafb2+po8zMFs+Rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736291503; c=relaxed/simple; bh=00ACdWSAWfIoDJD4HhgYq5Fv+ZbqeR8pjfbXt1Dkg1c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bLDIv4sNQJwF5ddhTFf22K+ptTMJMiLxQc6N2ZkkIJytmV4zL2v3htzurz5LUkR5it1NkEQoZqneUQuerevX8hl+fEg8KmfMmIQKCqccakQVwiHHtdsmSU97yFpixewq+tLBLfmAd16gGzPP/0RwdZ4YO9TqpkJdEPmpA3tmmwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=YlZeB3PC; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="YlZeB3PC" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7b6ed0de64aso28641885a.0 for ; Tue, 07 Jan 2025 15:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736291500; x=1736896300; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VRfHwEhGh+uv5N1vGfQEk1M7/smo5R9vzYPolDrrP8A=; b=YlZeB3PCxFJuebNq3f227ohpFL4Lk8BXsmhv3naais9QXJ20mmCQ8sI+wiBDYkO+zp KKyDKPPd0Gx+cT/oiqxJCYPDyGOT+4lrwJkCq9rQr4tt/jZ70WIkrnbNYtwRNlDyvc6V qh7x6kR8GzG4YitGUWK8FK+y+/QKPrMUI7fP7tKcFa7jRkxfMfow2c4w4+ylzS3B2O5N 0ejaYXKbqKxqs37oN/zI8ba+8mx3gN6gCbUki+BQsQwPvMz/1B3eMsGNmb2lGOYTa86r UQ3a5dzsO0MV3siU9FSeU/tBcLBBmRwrhMKqdEEPL+1e1HaN3w6RZoj+UaU8k4j2kyGe S1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736291500; x=1736896300; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VRfHwEhGh+uv5N1vGfQEk1M7/smo5R9vzYPolDrrP8A=; b=LgqfvDQ1gWdW6YE/IKb8q+iLnSUMlcJ9o0F9hwgMJgMpo3J9wx0oRxDpzdGpVEqqeL 7fXwKDq1I6DXlvS1EEIROTG+kAsCaC/XOdsDQhSG2x1qvUx4/8kcjZuepn6tH6sJpDNl YmPBUbs6Gk/TapvFwkqcO3jTUan/iiCah9KlYBlsrUr0KAiti+hWtMYdoC/XduYGFRsS 1kRrjjIK6MRRtHnX/SxGK1+5oCcThapWYm/WiXyJVjagge7JiK38Za853XtcPITkEpYB 6iIBuJFfKqNTrXpNxu5g2Auj17NOuwL2NXFyLkd7yADeNpoFpOQovFZC2o5KMZM8R0/5 JWMA== X-Forwarded-Encrypted: i=1; AJvYcCVNYMOs5Rhlcf3Px0uavz5gF46Iawa8GElfM+HQgA3w/JZNesFGami7N303qEYbL55fNAnfhALsehmBSO0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmpBp44XHVlIbzDSv4wYkv7e7umOBEnopNlRkC3KrKfFVKJCyN LTbtBp6HmyFVtT4Gp4H1X40m/xyfwM69KcWyz8a992ZRUbllWEFE/FFKfYPiQxY= X-Gm-Gg: ASbGncs+M7iDayRzMS9xq+8WMDBZgcQ2Kf+J1Gwqd9jQk5ImH7GTerYiOIH+BdkHVEy 9O836hLgxL+UteAV0kku4esfuKOOpJj9LwQYuC+aHtHZmQmw18xtbxComDxrUyKjFbnbw2UTmml oQgLZ7tqT++HtQoxsTTN0JAKH2pk9efwYRobxu8L3SSS9rEQHoKuSDWWMwy7bgVX7QG4dELGi0N OikWEnqDTiHZTAetjsoH+BkRcTa8ufjUX+AC5cU2PFGdOSElNK8A1XsTjaXWZTEXR4bQvLg6lEA /K16Uh/JojT5z3d5qvcw8Gb1LkMNcsEQm7c5PjQ= X-Google-Smtp-Source: AGHT+IEVUJvTzflm/kX6K/z/f2lJ3/GIdOO3tryrrQft3fqQp3S0N1VCLoQxCSQqBetJUDiEErzFDg== X-Received: by 2002:a05:620a:4513:b0:7b6:d5b2:e58 with SMTP id af79cd13be357-7bcd8cf0696mr188374685a.18.1736291500485; Tue, 07 Jan 2025 15:11:40 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac2bc8cbsm1630280285a.11.2025.01.07.15.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 15:11:40 -0800 (PST) Date: Tue, 7 Jan 2025 18:11:38 -0500 From: Gregory Price To: Robert Richter Cc: Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Jonathan Cameron , Dave Jiang , Davidlohr Bueso , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio M. De Francesco" , Terry Bowman Subject: Re: [PATCH v1 27/29] cxl/region: Show message on registration failure Message-ID: References: <20250107141015.3367194-1-rrichter@amd.com> <20250107141015.3367194-28-rrichter@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107141015.3367194-28-rrichter@amd.com> On Tue, Jan 07, 2025 at 03:10:13PM +0100, Robert Richter wrote: > Esp. in complex system configurations with multiple endpoints and > interleaving setups it is hard to detect region setup failures as its > registration may silently fail. Add messages to show registration > failures. > > Signed-off-by: Robert Richter Reviewed-by: Gregory Price > --- > drivers/cxl/core/region.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index 1dae7d36d37c..775450a1a887 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -2240,6 +2240,12 @@ static int attach_target(struct cxl_region *cxlr, > rc = cxl_region_attach(cxlr, cxled, pos); > up_read(&cxl_dpa_rwsem); > up_write(&cxl_region_rwsem); > + > + if (rc) > + dev_warn(cxled->cxld.dev.parent, > + "failed to attach %s to %s: %d\n", > + dev_name(&cxled->cxld.dev), dev_name(&cxlr->dev), rc); > + > return rc; > } > > -- > 2.39.5 >