From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17D2318D for ; Wed, 8 Jan 2025 17:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736355933; cv=none; b=QSgW8OD2bwof/puJ4yj0vs+IXMaInCohZwm3InxZA6JHRvRHZYu8nztFxOxZTTJne8RAq2hwJ3Ls+in0cIuD876hgqbc/nCr9AF5B+/7rnHzOtK4VGJTtc1YUjZ7I3U+q8mAVbjL4XcepZvruUPIwrHLlm+BHbYdrsl40ezakas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736355933; c=relaxed/simple; bh=9JT+ZDoAZ4iNRNoY0HJ1Su4PdVAt0nVZ6qmmMaDoW4I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dBlBnLRPsY8/g2sGhtlzY4VOHeDmgWpSY42J73ZkOQ3+0cFn1pywEFIdvPEGADELWlaTVLA9YFc8zg7hzYLJc0RtYTeP+6Ur7jm4BY1hU855nDqzMZ58Ly7xo4NKaMgrQyrwITHH+tE+F2W8EylSmMkKRqyg8WYjxQOvEYIymS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=AgqM3I12; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="AgqM3I12" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-385e0e224cbso2279f8f.2 for ; Wed, 08 Jan 2025 09:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1736355930; x=1736960730; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=rKvx99e6g4Z0rpqLB9wRUAqjWOH2T8CbRV87JKLyuz8=; b=AgqM3I12oRtv4HhE+I2pV31W1hYXSw/QPvIoZMcJKpuL+37bCFp6tkzcBjOl0EtmoM SgJvGHgvq5JRO7KeT3dkdK67F4Mtdf7RUI1TWH19jOzisivrIa7VUeB6h0oJomIXrEB9 GUsLbWaWBnXXzXrhXug1IGKc0LUlZ/tye5kpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736355930; x=1736960730; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rKvx99e6g4Z0rpqLB9wRUAqjWOH2T8CbRV87JKLyuz8=; b=H3b0voDVujVrfcOsEO/p0IxHY365VUE/xTBDPwEvFiBXnwXZJkBfDvVLHABySxNOuZ f4SybymVQm+v0NSdNBbF+7sasOye7m9xR9oXyJc0T1HNi1F4XUI1BTRblIs8PfN7DTbb x0QD1iOxncQYQBO0+yv2IvecKbOOEnAzfB9FQxyi4i5+KdwbY6UuZOnB8QBSGAn+nZ8j rEtrNBOo9snwPhw08Z/nrjVyLAjD0rNkObHTZm+Hem4KJTIcdyNjgKNtPayIlObjNFkH wV8DR1k2B07RgJPPIqJQvvf+8yZr8KFNYnS/L3aV4mM6F0e4sjKwGrB2tnFYB4owYCTc jG6g== X-Forwarded-Encrypted: i=1; AJvYcCUpZuCioWFZX4nY3d6Dyf/DpebKMiggEZrajYnaSsgJQEpG+7YXTKrtsKrbi4rHnfdXvAvbwAPoC1IepMQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzlW/ctlg0q1xDU8+DcA9qT5DHWXsByZhgTmJ13zkfXkNjDvWLk aUd/Zw1hv2HdS+UUNle/jMFZd3cUaR6AaqU3+RTVZM2cqHZaZKLNtd2xC2/Iajs= X-Gm-Gg: ASbGnctYjaFlNgSfW77PcmnxxyVA6ZMlKFSLtsZBou1W2ha01ROY7O/7Zf7HYreW+2J iZCW2aEWIYsrehMs/2AX+4PVUqwTdZLDdPtyTOEOeRrPUFTkuf164yVKOibcaxjeN8wqLqbJfkX x/NQWvtO3KpXf0qK4Z5wDr7VnMmwAFyBpbPLc88H+b+4IxLES6tbPAMW57Z0+igWhBHYHpdH7ts w6LyZiw3g0ZYjg3wJFYzFDKjxzRgbdnhAzDmLbqRpHZOc8r65zGi2lL7t5vidA/0ZSS X-Google-Smtp-Source: AGHT+IEvX8sJF+22nN0j17naG8VSCjm7ShZTKBpfpfH1JpRjytMJdmQiTcsKEjTDhwAIeG3CgHjK7A== X-Received: by 2002:a05:6000:156c:b0:386:1cd3:8a0e with SMTP id ffacd0b85a97d-38a8731007fmr3232471f8f.48.1736355930091; Wed, 08 Jan 2025 09:05:30 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e357sm54692891f8f.72.2025.01.08.09.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:05:29 -0800 (PST) Date: Wed, 8 Jan 2025 18:05:27 +0100 From: Simona Vetter To: "Huang, Honglei1" Cc: Demi Marie Obenour , Huang Rui , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Dmitry Osipenko , dri-devel@lists.freedesktop.org, David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Akihiko Odaki , Lingshan Zhu Subject: Re: [RFC PATCH 3/3] drm/virtio: implement blob userptr resource object Message-ID: Mail-Followup-To: "Huang, Honglei1" , Demi Marie Obenour , Huang Rui , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Dmitry Osipenko , dri-devel@lists.freedesktop.org, David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Akihiko Odaki , Lingshan Zhu References: <20241220100409.4007346-1-honglei1.huang@amd.com> <20241220100409.4007346-3-honglei1.huang@amd.com> <2fb36b50-4de2-4060-a4b7-54d221db8647@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 6.12.3-amd64 On Fri, Dec 27, 2024 at 10:24:29AM +0800, Huang, Honglei1 wrote: > > On 2024/12/22 9:59, Demi Marie Obenour wrote: > > On 12/20/24 10:35 AM, Simona Vetter wrote: > > > On Fri, Dec 20, 2024 at 06:04:09PM +0800, Honglei Huang wrote: > > > > From: Honglei Huang > > > > > > > > A virtio-gpu userptr is based on HMM notifier. > > > > Used for let host access guest userspace memory and > > > > notice the change of userspace memory. > > > > This series patches are in very beginning state, > > > > User space are pinned currently to ensure the host > > > > device memory operations are correct. > > > > The free and unmap operations for userspace can be > > > > handled by MMU notifier this is a simple and basice > > > > SVM feature for this series patches. > > > > The physical PFNS update operations is splited into > > > > two OPs in here. The evicted memories won't be used > > > > anymore but remap into host again to achieve same > > > > effect with hmm_rang_fault. > > > > > > So in my opinion there are two ways to implement userptr that make sense: > > > > > > - pinned userptr with pin_user_pages(FOLL_LONGTERM). there is not mmu > > > notifier > > > > > > - unpinnned userptr where you entirely rely on userptr and do not hold any > > > page references or page pins at all, for full SVM integration. This > > > should use hmm_range_fault ideally, since that's the version that > > > doesn't ever grab any page reference pins. > > > > > > All the in-between variants are imo really bad hacks, whether they hold a > > > page reference or a temporary page pin (which seems to be what you're > > > doing here). In much older kernels there was some justification for them, > > > because strange stuff happened over fork(), but with FOLL_LONGTERM this is > > > now all sorted out. So there's really only fully pinned, or true svm left > > > as clean design choices imo. > > > > > > With that background, why does pin_user_pages(FOLL_LONGTERM) not work for > > > you? > > > > +1 on using FOLL_LONGTERM. Fully dynamic memory management has a huge cost > > in complexity that pinning everything avoids. Furthermore, this avoids the > > host having to take action in response to guest memory reclaim requests. > > This avoids additional complexity (and thus attack surface) on the host side. > > Furthermore, since this is for ROCm and not for graphics, I am less concerned > > about supporting systems that require swappable GPU VRAM. > > Hi Sima and Demi, > > I totally agree the flag FOLL_LONGTERM is needed, I will add it in next > version. > > And for the first pin variants implementation, the MMU notifier is also > needed I think.Cause the userptr feature in UMD generally used like this: > the registering of userptr always is explicitly invoked by user code like > "registerMemoryToGPU(userptrAddr, ...)", but for the userptr release/free, > there is no explicit API for it, at least in hsakmt/KFD stack. User just > need call system call "free(userptrAddr)", then kernel driver will release > the userptr by MMU notifier callback.Virtio-GPU has no other way to know if > user has been free the userptr except for MMU notifior.And in UMD theres is > no way to get the free() operation is invoked by user.The only way is use > MMU notifier in virtio-GPU driver and free the corresponding data in host by > some virtio CMDs as far as I can see. > > And for the second way that is use hmm_range_fault, there is a predictable > issues as far as I can see, at least in hsakmt/KFD stack. That is the memory > may migrate when GPU/device is working. In bare metal, when memory is > migrating KFD driver will pause the compute work of the device in > mmap_wirte_lock then use hmm_range_fault to remap the migrated/evicted > memories to GPU then restore the compute work of device to ensure the > correction of the data. But in virtio-GPU driver the migration happen in > guest kernel, the evict mmu notifier callback happens in guest, a virtio CMD > can be used for notify host but as lack of mmap_write_lock protection in > host kernel, host will hold invalid data for a short period of time, this > may lead to some issues. And it is hard to fix as far as I can see. > > I will extract some APIs into helper according to your request, and I will > refactor the whole userptr implementation, use some callbacks in page > getting path, let the pin method and hmm_range_fault can be choiced > in this series patches. Ok, so if this is for svm, then you need full blast hmm, or the semantics are buggy. You cannot fake svm with pin(FOLL_LONGTERM) userptr, this does not work. The other option is that hsakmt/kfd api is completely busted, and that's kinda not a kernel problem. -Sima -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch