From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 969091172A for ; Sun, 29 Dec 2024 18:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735497183; cv=none; b=L7QQlbhRlUHcl3c6kkkMT6CxAVWD0VA1sjE9j2PnNo+avkLbCEZMJhnhq4y84SIzucyeMsOOTfhDhepvJoAcSlfusaa8cr/w9/nnV12j2N2LyBDMcxqEvPQyAb33uj0O/fuaCKvsBfJZmUrvH4NW1hCSwH2yPKs90p2NuYXp8gE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735497183; c=relaxed/simple; bh=+Bk3CDnsQ4lwr3gK/0rkwCFEefMhNul9J3Rc0v4bXfQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aSY99Ph9HR7hyaKObTZP6mNWHfF+3k12Pz0mTqFqEx703u7buJsoJS7jPJgjrM4E99+tM6OxiUiKzzKczhnE6bomfDWry4kKgiyyvbzjclWC0aeKB5FpeXDw7jCaqHslhROngw6Uf12lSO4M/0rP4zLYTDdQJkSN8HBZrag2NoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=philpotter.co.uk; spf=pass smtp.mailfrom=philpotter.co.uk; dkim=pass (2048-bit key) header.d=philpotter-co-uk.20230601.gappssmtp.com header.i=@philpotter-co-uk.20230601.gappssmtp.com header.b=obPLkkxk; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=philpotter.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=philpotter.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=philpotter-co-uk.20230601.gappssmtp.com header.i=@philpotter-co-uk.20230601.gappssmtp.com header.b="obPLkkxk" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-385dece873cso3161327f8f.0 for ; Sun, 29 Dec 2024 10:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20230601.gappssmtp.com; s=20230601; t=1735497180; x=1736101980; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j9k0WyCFtJUUGJx3nACS/lXhC2L4wH/HCywIN38QWIg=; b=obPLkkxklzrfvizSX5nqopRQqIPkw4MiuNK5Iili1DuTXqwDB8t7z9XyFj+Rz8F935 LDvShsDAceWXmV1cK/eV8ZaX/qUt0MuL4tdFFlySDF965tEJ4l2BuX6aK3g2BRRgy//s GjY0zDwnadgJdAxckPUqkKtjVLq6d9YAztmacgpPBXY8wQRBbX8dvY+1rl6m5S/3s6if keQFHIsqzdm5hKUYSp2zAziSDsg7axD5YGt5TYXxD0OvvaP5z/mjnXtWVQmS/uYZ+Y95 K62syO8pn7WCcYUlE/kkQ2O198RMZaR27zjP3gtos8ICmBDsgPe7ToyhM+F+lkT/PHAq z2aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735497180; x=1736101980; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j9k0WyCFtJUUGJx3nACS/lXhC2L4wH/HCywIN38QWIg=; b=ARvm/sSWFGnyUwJBMusVvGgWDIralrSnJfqQBdMuUiiB71aa2l++KZbtOXcCvSDXh7 sTx1Z1K0CXcA6i1qvzD3hJ8XBPYfJ24t+CC/JAG9LwQ5SDqh5XD2uX+1/o2JUfqsc6pg yzu/+U9v0RI1qXWaAeilyQdi+9Sc6v1xIo8/ri8b22Pw5zEtJ/c0WYmkAmm0kAGUCz5+ BoDPZyGf8q1sNi97sA/dfrtm8PQlD4JcoTY1UvkKc/eP4Q7wDkfLgYPUQX0WLJiyUAT3 1xX+0cf4lZNcFPEKu9rYW8nX4lQC3s0MgQ0JGgzjzMwcqCzDCy1l7XRJ9L9qkC24NNFD XvdA== X-Gm-Message-State: AOJu0YxQEEPZ5jPwRM34UEp/WKkGhKGH/qnc2K0WlAB20Y/XE8smlRJn NZ4klwb/jgDtHQr/rFCgBdnYGm53g3mQvEGSbqqWd4+1OngY8zihZPAfXUQUr+s= X-Gm-Gg: ASbGncs1QcIrwTFQ+m63JTySpwbTcNgJEPYz9+SEojUTX++a1to1VsDztydqJ9J/6xt rtNiud6wwHqp3K4mBfqO6J/6QYDjOjr2593xdx3OR0yjKSd+CkGQdbiAYPdTOA2VSJGhb5R92jV dlnEFQyghnngYKCMgoXOfEVVgX/EGIHa2lz+dVkRWtLxAjgwvzNUar/Bj+zb12T8QfqCxt9rjvf y/8ir1QfYA5fimuUktsIXfYIPkTQiac8QXtZzAQdi6Ow1cb1N5XfRe1A8O3V1Wcz3reyHf0R3Eq gpwKN8Sqn44lwDfsq8aJmpKaf4paIyQmPuZG4UQ= X-Google-Smtp-Source: AGHT+IHyyca6QfMSzWLjBV2V2IlLDxv0TaeaEiXLjADSqpm4xqSjWRiR9xpHfub1TZ8SxmDXBJdd2g== X-Received: by 2002:a05:6000:188e:b0:382:5010:c8de with SMTP id ffacd0b85a97d-38a223fd729mr28824191f8f.46.1735497179721; Sun, 29 Dec 2024 10:32:59 -0800 (PST) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.6.1.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:df16::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e357sm28728760f8f.72.2024.12.29.10.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Dec 2024 10:32:59 -0800 (PST) Date: Sun, 29 Dec 2024 18:32:57 +0000 From: Phillip Potter To: Steven Davis Cc: linux-kernel@vger.kernel.org, phil@philpotter.co.uk Subject: Re: [PATCH v2] cdrom: Fix typo, 'devicen' to 'device' Message-ID: References: <20241229165744.21725-1-goldside000@outlook.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241229165744.21725-1-goldside000@outlook.com> On Sun, Dec 29, 2024 at 04:57:54PM +0000, Steven Davis wrote: > Nothing big here, just a typo that really bugged me. :) > > I assume whoever wrote this was trying to make a new > line, so I went ahead and put a back slash in it. > > Signed-off-by: Steven Davis > --- > V1 -> V2: Add directory I changed to subject > > drivers/cdrom/cdrom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > index 6a99a459b..2863e5db2 100644 > --- a/drivers/cdrom/cdrom.c > +++ b/drivers/cdrom/cdrom.c > @@ -1106,7 +1106,7 @@ int open_for_data(struct cdrom_device_info *cdi) > } > } > > - cd_dbg(CD_OPEN, "all seems well, opening the devicen"); > + cd_dbg(CD_OPEN, "all seems well, opening the device\n"); > > /* all seems well, we can open the device */ > ret = cdo->open(cdi, 0); /* open for data */ > -- > 2.39.5 > Hi Steven, Thank you for the patch, looks good to me. I will forward onto Jens for inclusion upstream. Reviewed-by: Phillip Potter On another note though: The raw patch submission e-mail body seems to have some encoding issues, evidenced by the presence of extra content on empty lines: =20 - cd_dbg(CD_OPEN, "all seems well, opening the devicen"); + cd_dbg(CD_OPEN, "all seems well, opening the device\n"); =20 Also, it triggers checkpatch for the same reason: ERROR: patch seems to be corrupt (line wrapped?) #165: FILE: drivers/cdrom/cdrom.c:1107: =20 total: 1 errors, 0 warnings, 11 lines checked In this instance, happy to send on from yourself with this corrected, but please do look into why this is happening - it is possibly related to your e-mail client. Many thanks. Regards, Phil