From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC2B01A8F80 for ; Fri, 3 Jan 2025 19:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735931961; cv=none; b=h1ib39F2n0e5rqnI4X3GctpZ11QGMkeoDZC1bdwUw3qRCVwfCjf+lc2Mn2IcPvIwFlnxVLlxxqZD8bdfknQz/O2CM7XU0B3iynJr92fR+pYWegIaOritU0vyfcevd355rs2agT+ZZ2a8fuMqgF2R7KwMbpKn5Qjk/yKsvxMoCmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735931961; c=relaxed/simple; bh=bjz/ED3JJDyDfHAtIY7u8MeF9MthCbokXmP/zpQCi2A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jjStYw7l5RUnx8tOnlfqTxIaZ22E0NgJ/Knkz+Lh0PeyYqgLGF/MPOslX8CqO38R/H4aTAQc6rD5FPh9A0098iGDmt5+g+z95oTtFeNw4cBe+u1T3N4/ito/eDvQeh9KdxZaTdfVnFyYhU9n/7w0OXBKlP88AHrjBX8ROQIszPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=PNoZS8zh; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="PNoZS8zh" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6d89a727a19so119371916d6.0 for ; Fri, 03 Jan 2025 11:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735931959; x=1736536759; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LqIcsQa3xQ89k15UvHNpKUF7d2hPkHrES1PrudycnJI=; b=PNoZS8zhj3GbewjKADpQvMCCIixkheifu8E2zUaVcEvH1iAwV5Ous5Tgk+2qMQRhn8 QcDVTtkKJ5sSYcK6uZ0ybfFoH8MUM4jxr2539hG38qRs+8GHJ8X+BVE2CWN5cLIYpPPG NtUNiLPJi2ax0Q516hchE+svCxzBUsKA2KxpFGKtgPXim/Ic0ubD/9t59W3iLzZEjrci DzDfH1YOgAXRpmWTN5wwqGkwqp8DtUsDP5NaBge3Nl5RtQ7rNoPc34NnPWIguqNWkcqm cbaNoCvn1XbsASIjw7pSDosxzlLg9iTe+fvGtInYu2/Oi8JSxvqi394vyPx3C9p6AkYF 8mow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735931959; x=1736536759; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LqIcsQa3xQ89k15UvHNpKUF7d2hPkHrES1PrudycnJI=; b=ozSPx1mwp6ZonmzyruX+0n8ARQ1wyMylCllQhs/YvVaZvYObH5alRVxDyA1iC2onKm 0fwDgfqYq+D59OjbB6E+PI21nzOD71aD/3ypkkZQDKwWuMdLKNblmohDMsa6kPyTAFZy o3Ls/Hg0hbAhmpLO2tyB75R+KjMeNN+TwfiJ5lw0NE3zKI+URvKE+2U//fJNGWDMPeEt VNoZ3HbEcIaldEWkxnJJER43Tt6zg0oA9F882/048jEYHx/D0Uor6Ga/wLtQZxKPbq+w ZdMzy7ryYQTpJhPwY7+nHiKkbgGyboARIdH7SCSsGL4ZKnp6RyhUq8c1KTx+vevoa0Bq 3g6A== X-Forwarded-Encrypted: i=1; AJvYcCXWtLhIVG+hBIg0qN2G46KslgkqFqG+5dULwBOzMQbWbhmA93Vt7dU4vM0q0BMnB4J39wIw6QKNeOFJP3w=@vger.kernel.org X-Gm-Message-State: AOJu0YzXGq0DPgVxTQF7PBWWE6vt4RK4NbDQjcnkQ7WnnOFdKA7XqNx+ S/9HPo4bU4UxhcwzjE5+JdlGsJ2aG2sEIKK12vOIXv1s/cyqGo7Lei62aunwmvQ= X-Gm-Gg: ASbGnctTJVQqgGsRC/DoNkMgtGzpuR3EAZTmIfUo8jh6WYYoeN8YrqKOsuolG60auth BPMJeDirfx/EZEvB/nnSL/HbqlaFjauaNVeYoe7hvsLF5dZhe+yla9lwWD8lf90FVyydTd2rPhu IYKObgxDvMydHBrcpdAC6NiW/vjlbgTx/TS1ca/5Xt0Qgh86zymCFFjoxGbm+Y4WDVRJmTFfQCH 4yNE9f1bXsVHg+f2YwS7K5cM1GmVpFZFJOjUbS4FWLlwgsDiuyJk8Dm3Vzy/hESIHnfXvXVAVDA Dz+MnLYBgX3Xw0Cv+7wB5blF73SLJlu8lkAxK+U= X-Google-Smtp-Source: AGHT+IFXU9YnpCsbuLkPNkBDdSawluQ0vddI2FbCErzICwlopoFOniCDgIP+AcoxPMRkHPraDR2BNw== X-Received: by 2002:a05:6214:124d:b0:6d8:ad28:adce with SMTP id 6a1803df08f44-6dd2360e147mr870358366d6.15.1735931958766; Fri, 03 Jan 2025 11:19:18 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd18137218sm142415636d6.57.2025.01.03.11.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 11:19:17 -0800 (PST) Date: Fri, 3 Jan 2025 14:19:15 -0500 From: Gregory Price To: Donet Tom Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 03, 2025 at 03:48:24PM +0530, Donet Tom wrote: > > On 12/11/24 03:07, Gregory Price wrote: > > Count non-page-fault events as page-cache numa hints instead of > > fault hints in vmstat. Add a define to select the hint type to > > keep the code clean. > > > > Signed-off-by: Gregory Price > > --- > > include/linux/vm_event_item.h | 8 ++++++++ > > mm/memory.c | 6 +++--- > > mm/vmstat.c | 2 ++ > > 3 files changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > > index f70d0958095c..c5abb0f7cca7 100644 > > --- a/include/linux/vm_event_item.h > > +++ b/include/linux/vm_event_item.h > > @@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > > NUMA_HUGE_PTE_UPDATES, > > NUMA_HINT_FAULTS, > > NUMA_HINT_FAULTS_LOCAL, > > + NUMA_HINT_PAGE_CACHE, > Hi Gregory, > > While running tests on the patch, I encountered the following warning > message on the console. > Thank you for catching this, will add to v3. v3 is coming soon with more microbenchmark info, then hopefully moving on to some workload testing. ~Gregory