From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9194D1ABEC7 for ; Fri, 3 Jan 2025 21:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735940641; cv=none; b=hCvNKqwj00qSwCd6KWLBr8QQHZ6PZ0u3wQE2x7xYtEncWIsmu+OXrPuS5uxQEkv2tlfIL9M3J9Q9l4qydb1NZRdyV0v1Yypv/zDTRSgBsj9lHD5DslL95ZLN7ouTo8dNJTy27TlKLZr5wkcN18EuAtR1B34aVBXEVDuERufziZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735940641; c=relaxed/simple; bh=xXlYhpbXoh4/UVyy33RSzKyG+4b2CSGZewNQ4k9f+HY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t4Pfv1KECoiXrOTcsel08m/eR55VPLzeCwkPg4IX6wPzx9VZuhBaxAXRyFh82c34vLcjulpAIcNwpReUwWglv7xRrQ6kisNeeDPxcdUnzi8k+GupThmEMn6g0sJPdrh/tZvEMzyLd/1NP+0GQR696zJNJGk0Ho71ttz1qvdJlTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m1Pgsueh; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m1Pgsueh" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2161eb95317so182458905ad.1 for ; Fri, 03 Jan 2025 13:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735940639; x=1736545439; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YBVjV7oMUvYtGohtGs9sGbVaUItsCP+eOtBsDk5Z1aM=; b=m1Pgsuehs/Y3LqtJTzuoRYY4d7nmWQe/oNewJ/+eqAI9I95NcsKtrOBa1A7dZJt2bv 1/6H42AuCEtlCKRcLPzBLdz+noHM/mvGtH4R+JyMpNQzZpQAoBFM6FTzALjq2ubTAP+X LdhHY9FgA2S0YR2Srf4eTevZyVtLELKy2Yzlmo58CU537z5dIvxMYWSLpy6nu/phn/is Rl0vfE+wYzF1RqZ5ckN9AgK2q2ji9/pyLjA4qvTXFlrHDorUE82jpHDtTQPMcV32nJWY gqIGBwL4thu0kAHj5Ob5tYX9vk41bTa5wcKPIc1AB2rk0FwbPDNb2tiSROCLmj9qDh3O 4oPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735940639; x=1736545439; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YBVjV7oMUvYtGohtGs9sGbVaUItsCP+eOtBsDk5Z1aM=; b=l8YlXMv99gojWiVciSIxf4id/qZR3JuhJn65bFHj63FAXdGBAv7kr5AUbE4rMUDXq+ k2qEnMUpfLzR0dqEawKKzK2DtfH8gIzwaoP2W00bTloVsvjbIXnFV3VGzp7SDGP8E3Mx KtoRUNIDYZNR03Xkdy4Xq2JSK2yuprMid87TidOR3w16UjPzBsaxvUDAs/LQcTNcFpIx Zwm6ROV907bJ47HJbWWQlpnESIisbFpwcIQjzhPd7FELxoYTEMd4dCpsy6Tk8Q66ZUg/ qHpVydHkVVCk7GohTO7AqbzI4gZj7twFsdZd/s54w5wH+xCkmCLEEnM+TY5JDoTqPp6x 6rYQ== X-Forwarded-Encrypted: i=1; AJvYcCVOIdOf6FPFMeK88vK/Cor+fvbVq32nV/clTnfMrgyD19ayDl1kZkFBHcQDk8nzQsPAZhZ603HMgSIcomw=@vger.kernel.org X-Gm-Message-State: AOJu0YzsI5uNiJiErcLnyjYKxdYdNMyOCM/O6e8NqliiOl8P6S56/PMJ nym5VAY8m28lqtICInIE7EMtl+qTBIjk9tkvWFDGFxRtLaJmIgVD X-Gm-Gg: ASbGncs2mR4mTKhoVs0OynLkKUUypFUwumT5NQUBjsMzWr87kEMaCdej9Pgwre9eeuI du57SaTgTuTxBxO+cDpbz/1HIkuvCswpj3V48J5B7l89KU/YDFD7rrZOYI2Ymj9wvQIKg8iw9yH II5TBJGeIyzx5aRIUGyM+zDqN1fU/AfXhhAGdEIyzl9ieK8BDU0wUSl4ZrrGMnojaLhAi8GYzua 4EA0m0/kLLYUMQllsWm6rmf+jWdyzDegqcSso2FPofqoEhDcQGI7+WNIY7SF6CbnZmBJad2fU3c olC9LSPN X-Google-Smtp-Source: AGHT+IGRF4jZAad+rllk07+Vs9S921Nvj1wCkaEBwtQXzDSDaGrFmJY7oFRXjecjSLSV0UZ/0CiPbg== X-Received: by 2002:a05:6a20:9191:b0:1e1:b60c:5bdb with SMTP id adf61e73a8af0-1e5e049f2d1mr79966858637.26.1735940638757; Fri, 03 Jan 2025 13:43:58 -0800 (PST) Received: from visitorckw-System-Product-Name ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-8529e78a55dsm19601743a12.80.2025.01.03.13.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 13:43:58 -0800 (PST) Date: Sat, 4 Jan 2025 05:43:54 +0800 From: Kuan-Wei Chiu To: Dmitry Baryshkov Cc: Yu-Chun Lin , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, ruanjinjie@huawei.com, jserv@ccns.ncku.edu.tw, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] drm/tests: helpers: Fix compile wrarning Message-ID: References: <20250103161758.1097313-1-eleanor15x@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Dmitry, On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote: > On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote: > > Delete one line break to make the format correct, resolving the > > following warning during a W=1 build: > > > > >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a KUnit test > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.O6WY1VCW-lkp@intel.com/ > > Reviewed-by: Kuan-Wei Chiu > > Reviewed where? > Yu-Chun is a newcomer looking to contribute to Linux and asked for my help. As suggested in the last section of [1], she asked me to review her patch privately before sending it to the public mailing list and include my Reviewed-by tag. This improves patch quality and reduces the maintainer's workload by minimizing potential issues. Although I'm not a DRM developer, I have been contributing to Linux for some time and wanted to provide support. [1]: Documentation/process/researcher-guidelines.rst > > Tested-by: Kuan-Wei Chiu > > Signed-off-by: Yu-Chun Lin > > --- > > drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > Reviewed-by: Dmitry Baryshkov > Thanks for your review! Regards, Kuan-Wei