mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] workqueue: introduce WORK_STRUCT_TIMER_PENDING_BIT.
Date: Fri, 3 Jan 2025 12:18:20 -1000	[thread overview]
Message-ID: <Z3hiLCvxC4E2MNG3@slm.duckdns.org> (raw)
In-Reply-To: <20241230064500.1404206-1-imran.f.khan@oracle.com>

Hello,

On Mon, Dec 30, 2024 at 05:45:00PM +1100, Imran Khan wrote:
> Currently WORK_STRUCT_PENDING_BIT can indicate a work_struct that is
> already made it to work list of a worker_pool or a work_struct that has
> not yet made it there because it comes from a delayed_work whose timer
> has not expired yet.
> 
> Use WORK_STRUCT_TIMER_PENDING_BIT to distinguish between these two
> states of work_struct.
> 
> Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
> ---
> I have kept the patch as RFC, because this change is not fixing a bug.
> It makes WORK_STRUCT_PENDING_BIT less ambiguous and helps in debugging,
> by indicating where one should look for this pending work.

But can't you already tell this by looking at the work struct? I'm not sure
about adding more atomic ops for redundant information.

Thanks.

-- 
tejun

  reply	other threads:[~2025-01-03 22:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30  6:45 Imran Khan
2025-01-03 22:18 ` Tejun Heo [this message]
2025-01-06  2:07   ` imran.f.khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z3hiLCvxC4E2MNG3@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=imran.f.khan@oracle.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®