From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Tanya Agarwal <tanyaagarwal25699@gmail.com>
Cc: haren@us.ibm.com, ddstreet@ieee.org, herbert@gondor.apana.org.au,
Markus.Elfring@web.de, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
anupnewsmail@gmail.com
Subject: Re: [PATCH V3] lib: 842: Improve error handling in sw842_compress()
Date: Sun, 5 Jan 2025 09:06:09 +0800 [thread overview]
Message-ID: <Z3nbAftm07ekm2Aq@visitorckw-System-Product-Name> (raw)
In-Reply-To: <20250104184951.3481-1-tanyaagarwal25699@gmail.com>
On Sun, Jan 05, 2025 at 12:19:54AM +0530, Tanya Agarwal wrote:
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
>
> The static code analysis tool "Coverity Scan" pointed the following
> implementation details out for further development considerations:
> CID 1309755: Unused value
> In sw842_compress: A value assigned to a variable is never used. (CWE-563)
> returned_value: Assigning value from add_repeat_template(p, repeat_count)
> to ret here, but that stored value is overwritten before it can be used.
>
> Conclusion:
> Add error handling for the return value from an add_repeat_template()
> call.
>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
LGTM. Thanks!
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Regards,
Kuan-Wei
next prev parent reply other threads:[~2025-01-05 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 18:49 Tanya Agarwal
2025-01-05 1:06 ` Kuan-Wei Chiu [this message]
2025-01-14 3:45 ` Herbert Xu
2025-01-14 14:13 ` Tanya Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3nbAftm07ekm2Aq@visitorckw-System-Product-Name \
--to=visitorckw@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=anupnewsmail@gmail.com \
--cc=ddstreet@ieee.org \
--cc=haren@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tanyaagarwal25699@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®