From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 213BF1F3FD2 for ; Tue, 21 Jan 2025 15:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737472235; cv=none; b=TQkH+iFDaG0+Ju+bYjUHfTFSOb1FB+1eEMqGLGnvt5lRJNJ9u6N/3u4RZ7/6+gqVxiD+nm3OGMYSVka1Tyl2V1ZEUr1N0tpWd6RGCxnlxRD5Qd5LRmiiTcKRWovlsWka9w2gJJz8QjyLZj6YQ4cATepT8xUi/WGXV+rOZVl1eCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737472235; c=relaxed/simple; bh=pRJRz+OpfQpH9KXpwAWeimcyoeUpzCupthx6mDReiKU=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RTA1EefV2Tk4pxGtMFZt/ruL81t0eRyPCeDmatt6miDsJzRoM+z3g2QTYjUn4S5seYHVeva8Hmbh+KpuPBr7bmkj45PrDT2258PcHD3tUbke4uA7gcPxaLRiew5O6dtiz4dJAZNQUei/v0KxmU/DFhrYUgHkwZIPhRR5bLfKfEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=B+8/C1+X; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="B+8/C1+X" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-aae81f4fdc4so1136319166b.0 for ; Tue, 21 Jan 2025 07:10:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737472231; x=1738077031; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=1BIk0mJ4ghFJN5TubUO6JYFTlPsrPupFq1LBuxjGGzk=; b=B+8/C1+XCplkniHMXqE1NF+0AQr8EEyY8u+sdWAqWRWg2Cr/qekJBOu19uL6Gpd8MT 6/FI1/eTkSAzWXN91/enHuZYhnxgxKq9Sq7g2TMe8+nhmdU6BpHUhkkRk5x0/+n8t41e QooBgI1gp8D4ts1KEsp4rmabKYIWgMpJIVmavlXHQ8S31nn3zrjFzfcWg7xC/2XKotzU uKvBEN+PP7dmgiCzXDkPruaZ95jThtIokHiasJ7KvYFCEHseaAoxp7HfnLZK+JmNpvQf hZPSDWI/96kxWkyGjEODokR+e5VMpMKfE+IJeq4mfFdJC9WBqun+FQlkcNKP8K1isjsG GCIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737472231; x=1738077031; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1BIk0mJ4ghFJN5TubUO6JYFTlPsrPupFq1LBuxjGGzk=; b=WBDQHl+Z2oWAEM8IKUvZgjGeTt3vJgZkH/SCtgFQiYR4wRDwKFrYeDqNS5JhI7VPZ2 Ad/c0iq+lpemPNaSGRvAVWHYpfaqeMCB/4ey557eVCGxfjD197kdZTHQkxhZAmZ8WVzT C+EmwunDiN05feWB+8yqQOkwdIkmkIPCRZvKi4B0dwPFd0C7/XYMPojFrVKGGaSY8Ah/ 77S9s/jz9dhz/QjUyTpFTGz48ek55W46pM5ut+WjJ7O0j+blfjffyZCyMnMmKteMioS8 IZz5cn0P9DUK0x4Ej0mvj73uP4gVj6d3MBpURdfGMs1YohS0RhHOb//cUaDzDIj/F/9D fyzQ== X-Forwarded-Encrypted: i=1; AJvYcCVQPpxboe31cHVN6asGYHmrdP7aWHnu+JS0bgA7pYvPs5CJtU3a6K/bvQeqHJtlk+nsaPy5F7xp45E58VU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyc8Vmt1ITWCPRU9PZAH/8D2RLSTt3QJHUS3kqcXEMN/fYB4v6i C/JlQDhzL5LmYxlQtPuzricFFZwYl4PUmDAn+tHCLN6/OdbKn1Bw8THi0bblvb0= X-Gm-Gg: ASbGncumeaNFzGiEJXC/72ZIpd/W3EfvO0KR6esxWWWG8+h+a1Va5DJsGCCWBeIOBaL 1xFPrFfyBT2Utp6DcXHd1Vjng2xiJMQRQKXMAqgXTJbuhd/YDJ8IBLl9CkxwmzFlPJWVekjM2/S lDcWXJdEUlTPtqFzYvHExJZSEQd3u1LnsIaoOQjkBsBlHTlPRYKDQ3je+skV9N4xDPXg7IdW2QC 2Mt3Fvg9tzRHbu2lR4X2GbjDsdHLof4kHdXvsVh3TTkCpnFXwEUCqPvnP0I9ZjJgdaQugY++cTH 6Awt8LiQqUF99lPb9iH8h61JdSB51myaQ1Z1Bu8J X-Google-Smtp-Source: AGHT+IH9FVvcKrRKMRhk26BWOCPbtQyPFCLPBzPFOkLbN63Gck9obXb7zAzQ71TAqafJQA1N8DPwwg== X-Received: by 2002:a17:907:94cc:b0:aa6:85a4:31f8 with SMTP id a640c23a62f3a-ab38b32ad1fmr1524098166b.33.1737472229912; Tue, 21 Jan 2025 07:10:29 -0800 (PST) Received: from localhost (host-87-14-236-197.retail.telecomitalia.it. [87.14.236.197]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384f8d3a0sm759146666b.158.2025.01.21.07.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 07:10:29 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 21 Jan 2025 16:11:22 +0100 To: Andrew Lunn Cc: Andrea della Porta , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v6 08/10] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: <550590a5a0b80dd8a0c655921ec0aa41a67c8148.1736776658.git.andrea.porta@suse.com> <2025011722-motocross-finally-e664@gregkh> <2025012143-rippling-rehydrate-581b@gregkh> <2025012157-bonsai-caddie-19b2@gregkh> <6f16b0ea-ebb7-4692-bfc0-79052f079bc1@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f16b0ea-ebb7-4692-bfc0-79052f079bc1@lunn.ch> Hi Andrew, On 15:53 Tue 21 Jan , Andrew Lunn wrote: > > > Well where are those externs defined at? Shouldn't there be a .h file > > > for them somewhere in the tree if they really are global? > > > > Those symbols are deined in drivers/misc/rp1/rp1-pci.dtbo.S (added by > > this patchset) and created by cmd_wrap_S_dtb in scripts/Makefile.lib. > > Could cmd_wrap_S_dtb be extended to actually produce a header? It will produce a header nonetheless, one which is needed by just one .c file violating Greg's rule about having a header only if referenced by more than one source and the symbol is truly global, IMHO. Thanks, Andrea > > But that might confuse static analysers? > > Andrew