From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC6961DF964 for ; Sun, 19 Jan 2025 16:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737305937; cv=none; b=NgakcxpnhxElKPaWAJawqg6eTeIhbwXNglUvmxHqky14RPNyTZNNsRkpKk1L8F7I80vLEBgNZiWCpjInmpib8GjMRSUHvdTUJ9IiYX+FzwQ2TptFMZUjLC7yN6ruNuQ0U6oHDFbPTJHSJsT3vGa/AnYyMDwp3zLa72AdKOnmo74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737305937; c=relaxed/simple; bh=rTPVX7g6+5V7kg4sL9D2UEKaBuRnihS5beTdkHNdRWQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fBdrOYULy4YkX6Qaskw63xy8E9nl2QmYCzh+FjgukZg88C7nZ8cdRJiAP8yYno0lID+bxlTM502oCngZIqOM7xF+VCDSw0DvosYs9bcA4+WdHbBq7XELFM5wJGZoOVRy7vUgmFMwEJjet3e5JQ6waNShpRG+hjhRePQmYi8bi5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tMZbzl1W; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tMZbzl1W" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-436ce2ab251so24991055e9.1 for ; Sun, 19 Jan 2025 08:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737305933; x=1737910733; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0bUiH3DTtIjUv2h0clSgTW/RbI7LvXj6i+Ro4eU+Pvw=; b=tMZbzl1WN3OtCAP73N51oq8G/peVe4ZYqjo8Mf/+JYNB7sMGU7gzuxYXYldkOjbESW XAnNq8f9a+nhqRfOvcsRQZ+xhAjfiAJqOhF4FvQE5JNE9PTNY7tAxIAb5O5YRm6nxcv7 Kp66qAQKqf8Bqk/T6OgJu+W10ywTPdI//DIaRoYbfRF4t/Q/T3TYtdNikgypTWnBCyvh 2P7UgZvd7Jlu8I66scvJ3wlOMUpkMRnXGSlkV0n01K5zYjUHQuMRQ6TDrICyYrsn4t0Q 2iOLYD3GjorpJWwrOLGiUtg2BzMqgRk5nubRr+4lrTNWWDZq9sO3ofUEOUoTrZuh2xca cH7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737305933; x=1737910733; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0bUiH3DTtIjUv2h0clSgTW/RbI7LvXj6i+Ro4eU+Pvw=; b=hbJ6RpKbTGq9j8Z9bwtGc58Zz7waNF4aTVf04YEI9FZ6qs/BEZ/bPZ+ZJnk1K/t6RU eNP8VephElkk9JwAGEO6zie/RjN+HCzFH5OEY1CZqOhdZI/BSVPKqYW/JXgmOK2Ecrg4 cEWQc1EWC7BIboM1ym6TN2jIhwjnVRBySpu7cBPOcLTyddPww6/8xXo6O+uZ0pPSq/b6 qMhC5KT1b6/ggGSA74qB188ljgL1T75GiqBxdusEb1acH+xm3Znj0QS1SOH2WNkQvTSJ N6tSsYuCdVfsggFu+diDKPwI4MyUyCc4VeQiuC55ccwuhA1tAS9nVisamlEW0fMyvVTW WfkQ== X-Forwarded-Encrypted: i=1; AJvYcCWWGivsjq8LBG63GFyONsN5R1x6YZOzQNkuJzjimhhPclyJNjpIx6c3zqG3R13LDsyaZIXwqMYsQZtO6PA=@vger.kernel.org X-Gm-Message-State: AOJu0YyFrcwco2+5pHIphb8yBX20YHejl9+8q0VWyujDwoKh8nzGsYPY w9MIGO2dR0jh/mykJ1GOTs4ON0By4l0/U2espPmAK05JXE9Wuz7C9PIF4vTc3us= X-Gm-Gg: ASbGncs6bNYKjQfxpURT/jztSU9rkwtpHbyViXJAWEdf1SKEUdyAIrwXojsG/8u9UMJ 2IIBewDbL4XKs08XZbG6qJ9IcGP9U6vrXHMcrcQfcqDZ7cVYagvwzY+VwB+GpYOHr14vbVPb2/f Z7B5OMO2pRa6uXQCBvl6N4o08BDAliPcypkIybBUnFM3VamhXBYmjCvQHPpwo4Pus6MWhEaKTom onoDUCoSTtSJpJ2hpM1UhHKZErfgXqIbcjvE9AJFYEYeezVHH8Djw6TmKr/dvY4hfqN X-Google-Smtp-Source: AGHT+IHeHsXNV4t2dh8Irsrn+bIZjKOPMF25wKOhqLDhufsQpqXA53IvvKG/Hdtl5ztuWuISFWGXDA== X-Received: by 2002:a05:600c:1c93:b0:431:5863:4240 with SMTP id 5b1f17b1804b1-43891429c77mr83819445e9.24.1737305932992; Sun, 19 Jan 2025 08:58:52 -0800 (PST) Received: from linaro.org ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c7527fd1sm169592465e9.31.2025.01.19.08.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 08:58:52 -0800 (PST) Date: Sun, 19 Jan 2025 18:58:50 +0200 From: Abel Vesa To: Tudor Ambarus Cc: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Adrian Hunter , Ulf Hansson , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Eric Biggers , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, willmcvicker@google.com, kernel-team@android.com, Krzysztof Kozlowski Subject: Re: [PATCH v2 4/4] soc: qcom: ice: make of_qcom_ice_get() static Message-ID: References: <20250117-qcom-ice-fix-dev-leak-v2-0-1ffa5b6884cb@linaro.org> <20250117-qcom-ice-fix-dev-leak-v2-4-1ffa5b6884cb@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117-qcom-ice-fix-dev-leak-v2-4-1ffa5b6884cb@linaro.org> On 25-01-17 14:18:53, Tudor Ambarus wrote: > There's no consumer calling it left, make the method static. > > Signed-off-by: Tudor Ambarus > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Abel Vesa > --- > drivers/soc/qcom/ice.c | 3 +-- > include/soc/qcom/ice.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index 79e04bff3e33..2310afa77b76 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -262,7 +262,7 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > * Return: ICE pointer on success, NULL if there is no ICE data provided by the > * consumer or ERR_PTR() on error. > */ > -struct qcom_ice *of_qcom_ice_get(struct device *dev) > +static struct qcom_ice *of_qcom_ice_get(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct qcom_ice *ice; > @@ -323,7 +323,6 @@ struct qcom_ice *of_qcom_ice_get(struct device *dev) > > return ice; > } > -EXPORT_SYMBOL_GPL(of_qcom_ice_get); > > static void qcom_ice_put(const struct qcom_ice *ice) > { > diff --git a/include/soc/qcom/ice.h b/include/soc/qcom/ice.h > index d5f6a228df65..fdf1b5c21eb9 100644 > --- a/include/soc/qcom/ice.h > +++ b/include/soc/qcom/ice.h > @@ -33,7 +33,6 @@ int qcom_ice_program_key(struct qcom_ice *ice, > const u8 crypto_key[], u8 data_unit_size, > int slot); > int qcom_ice_evict_key(struct qcom_ice *ice, int slot); > -struct qcom_ice *of_qcom_ice_get(struct device *dev); > struct qcom_ice *devm_of_qcom_ice_get(struct device *dev); > > #endif /* __QCOM_ICE_H__ */ > > -- > 2.48.0.rc2.279.g1de40edade-goog >