From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2AED1DF748 for ; Sun, 19 Jan 2025 16:59:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737305992; cv=none; b=bLtfd+htfBszuTXZ5PNWiAF3sZ3sd6bTfPdCBzQSCj88TED269nh3x/sNv4imFlWOF0a+4dv+NiTRz6tFHfOIZW2Z/8yXp9vfI1Zm4esOvR1w6Hrmd3Wl6JQMjqdWbLWsre9+hpbPVgIwVRvxxp0+5jIQcy1lULJAQr8NuKwmgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737305992; c=relaxed/simple; bh=moQ4Sx1R9uDF15Ros1s1+SmGuBjFhQZ7Ns8wG2ntmxU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B6OsygO/uhEr69ys90O7JktVV/4hKlUzzlv6p1zooqZN+9KDSK2PgDiIsYREq2uoe9L6h1nXZrZDnqkK6qwn31KPBQTaO59jxoS+S10cFsNJHNB6e2ZTwHaB+QyMRZmJYDY/8JSSKoFHGWFcgaaWVx+St/uO5HkzMkiAOJ7FWGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NKaV1550; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NKaV1550" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4364a37a1d7so36499505e9.3 for ; Sun, 19 Jan 2025 08:59:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737305989; x=1737910789; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gU2K4r4ZzM/BRR+Tyo710S/yU02b9d5jbFwsNMfd6eQ=; b=NKaV1550pNQjUbFDK6asjoj7qqXbwZ3MOAucx0FuXEkIQHLix1SuyidZnP9cjtrque URgsqlqYkf/SXwhMB6xyf9d5eHop8jgyWcoy3+Fhk7Xur2023UBq1nfQOrKRkbVOdYN3 3Hd5tkWS8rFwkdlF8ndBkURsYNlFqRtjWJfgHd0nCFLnjhT3gTLZ4Z4UWrKaZP7qJa/z 98r6SruD/3BuHT76vhsgUzGEZR0k9zysLqM6TRWOC/w2CkcEAexcS1DLVZdFZaM0Jfhx KIzMIv7FK4tE/DcDd8VzuAc1Rhs+MJTFAOMZWFAnUmg5jo3nSXjh4UEKRdZLqDac09ly nNFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737305989; x=1737910789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gU2K4r4ZzM/BRR+Tyo710S/yU02b9d5jbFwsNMfd6eQ=; b=kfX/H8Esd7bECH9Uyb88gSS4m2zbmZm6eLwnm+L6WZ2eAzSjndR8kjkIOP/8uo3dcl tqCCQT7JliGBZlp4CN7o5RDy2dhry17nh8+6QEpBbKByvsVeM+zAEyxkwo2dMRDUbwcM AdoFVCu9M5x9UqDQyJAyc6rACW05YrElJgqHe6rWq75AQWozrXqCQyc//NJKinwEPyk0 N2ndC+hYpXHmPK7ySujUBTIom+Hg408cSR1d3B3wGYpcCo10bqhUycjT2uRSBOMFJB1f y5R9ZqvWSc753pZ/bLquJgK3VUa8E1hBAgquyp3KkcDBjYYTRIjwIf/FcSEKkrLs7J6x OvDQ== X-Forwarded-Encrypted: i=1; AJvYcCUNQA7JEu3cB0R4l9gxiras/hb3fB4pwVqidhFID424MKwdCulXtVv5HCzggvIlFZxKjj5jla95dDyWWzo=@vger.kernel.org X-Gm-Message-State: AOJu0YyutRB1FQFCIE7fGw0uOxy74vZmmzo2uvv5ZGI2u9oPzId8X+Rm 5sUOBxkitrbJvfc6irSemtnrpr22AFn4aTBcCN2HYvRYIrXYUBNAXtHK17JxYSM= X-Gm-Gg: ASbGncuL03oOWvjDqVWV0tSYL11OMrLHSxYJJbqxX1n9EdhnbNkBZ+kigTy7hMev/37 f6Z9RUTJ17FTKefchrBKRhybFu0iy8/DmincdyksLjS5JHzwHOJVWe3TOuApiMxQiRxSJxTzq2v j6IoVFKkp6PwAn9VxkoMMSqeF4iEGfJYbaBGrGOmiUk585+V2EzQnXE3I6pgDwbW3P1f13lxIZG sWX4G/ATEregP+ra+fMFMOomFcrKGxhC9XcByqIkz96T345oGVY+l5BPe7oS2AjY4kK X-Google-Smtp-Source: AGHT+IGecv9i+IP+93WZa2OpzfUcrFBdgsvIOe06ZTegWk6SGd3ckOy9AuooWsDdbYCE9mFC7/pmGQ== X-Received: by 2002:a05:600c:4510:b0:434:a30b:5455 with SMTP id 5b1f17b1804b1-4389144f671mr88149435e9.27.1737305989481; Sun, 19 Jan 2025 08:59:49 -0800 (PST) Received: from linaro.org ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3221b5asm7939547f8f.21.2025.01.19.08.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 08:59:48 -0800 (PST) Date: Sun, 19 Jan 2025 18:59:47 +0200 From: Abel Vesa To: Tudor Ambarus Cc: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Adrian Hunter , Ulf Hansson , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Eric Biggers , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, willmcvicker@google.com, kernel-team@android.com, stable@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 2/4] mmc: sdhci-msm: fix dev reference leaked through of_qcom_ice_get Message-ID: References: <20250117-qcom-ice-fix-dev-leak-v2-0-1ffa5b6884cb@linaro.org> <20250117-qcom-ice-fix-dev-leak-v2-2-1ffa5b6884cb@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117-qcom-ice-fix-dev-leak-v2-2-1ffa5b6884cb@linaro.org> On 25-01-17 14:18:51, Tudor Ambarus wrote: > The driver leaks the device reference taken with > of_find_device_by_node(). Fix the leak by using devm_of_qcom_ice_get(). > > Fixes: c7eed31e235c ("mmc: sdhci-msm: Switch to the new ICE API") > Cc: stable@vger.kernel.org > Signed-off-by: Tudor Ambarus > Reviewed-by: Krzysztof Kozlowski > Acked-by: Ulf Hansson Reviewed-by: Abel Vesa > --- > drivers/mmc/host/sdhci-msm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 4610f067faca..559ea5af27f2 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1824,7 +1824,7 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, > if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS)) > return 0; > > - ice = of_qcom_ice_get(dev); > + ice = devm_of_qcom_ice_get(dev); > if (ice == ERR_PTR(-EOPNOTSUPP)) { > dev_warn(dev, "Disabling inline encryption support\n"); > ice = NULL; > > -- > 2.48.0.rc2.279.g1de40edade-goog >