From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2060.outbound.protection.outlook.com [40.107.103.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABC10190662 for ; Thu, 9 Jan 2025 17:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.60 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736444381; cv=fail; b=bAUGOoMuvqgjFsBYHD8h8tZJ1ekaV04FxVi7g6FfxUArenM1O2FuIQGC/0hux+iInKpA3nXZSUU3btSLQvdK+ZOKgOx1/2BlEJml1Pn4TLdbycTz4HqbgH/Isdvs1v8eYi82Cbkq/Q5xZJ/2A/JMEtV5N6o5ccMauaagW0Ol0v4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736444381; c=relaxed/simple; bh=kxoPBG4Vpt094NCbhBZi83tFT/dmeRzBgd6WEYltkeY=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=iR45uRZyyxB727lw2SzxlVxeZyx0WTSTwNDM+C8OlvUNkVS8UgnekRk/e/Y9uWBazHWjmw078VSL8moIwGYHewixqJUEmVCL/HXdP0z6cSVxPaGPnaNhngRGhD7e5YA5ZNcB+xlNpGGPHwEyNbmguN7PGm8lK/JYEagzhSqlo5M= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=T6SHZfC1; arc=fail smtp.client-ip=40.107.103.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="T6SHZfC1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CG1LYjBIQ7V0n7juhPc9Gk9426B/P16Jm+aXwjew9mHW97m4RY8zdz7LnzbwIFN/x1OUiCHQeWyFqp/8NhyybTK2URKy1kofpeiGqQ2os0YfvVnFt5F9e6xt751hpRzxESqTn0D/4Ul5lTePO61k6Uh7uRdfMVUkPGxCqYBwWgsqGKN7mx0d8OL5C7JhQ7HxNuVS8My2NCEve3VJwAoThSGgzU98xHZrJ7UaEUEjcoKXJ9R9Y7TYrbr7qXEd+Tu2DKFOvCNqfVzui0dw80DGz2MCm49xVS/uBp9XyW63H4qmDIyPUx0iyosgD6tOUM5Y5lwfiSNCj+Thmw0KcYLtfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kxoPBG4Vpt094NCbhBZi83tFT/dmeRzBgd6WEYltkeY=; b=F8cUyyyWn6BWZkge1yBqwdaG67QWD8cnaqDh5c03mdz+iMldxI/vwZbrgcDbuWhkCxX0lRSkEZ2SrHZH2cIjvfaZsUowFb20ghwOWpZ/SaJh+SD2fgLHUjQDjqwFE4xi7JIMLTr484cgYazWXcFnD5eIsn8A7xlX62smkpxpm1JrD3/8lAP/KmkHt0T0iXAdpLppyKgfy9CTODM+vVEnG2B2Z2GgyZ0uRX4xYytbwnSJsfqo6hIR1Kd9O1sOm9G0mYSLLqvV+xWmlbH5xTvY1wwYwlFI1Ocvi6CAcqUYIGiJewgzYNLNjR92/+bNz4d1q7Dc7SUczbPAW1UmT8gVgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kxoPBG4Vpt094NCbhBZi83tFT/dmeRzBgd6WEYltkeY=; b=T6SHZfC1aPTl2czP02a2BQDP3M+96PUJQZoYFYqdhEMLaYwRBZwMLPqj2c0UgzoHrgCBLAVobkV73T4eaKQMXHQDToCXkWUEPaCMye4Zmycpyi1jQvd7QO4TEbplUvpP0V2vra4AYVRVK2biM9nMZb4Nw62dxyM22FDI+gHZV8A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from GV1PR08MB10521.eurprd08.prod.outlook.com (2603:10a6:150:163::20) by DB4PR08MB8198.eurprd08.prod.outlook.com (2603:10a6:10:382::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.10; Thu, 9 Jan 2025 17:39:34 +0000 Received: from GV1PR08MB10521.eurprd08.prod.outlook.com ([fe80::d430:4ef9:b30b:c739]) by GV1PR08MB10521.eurprd08.prod.outlook.com ([fe80::d430:4ef9:b30b:c739%5]) with mapi id 15.20.8335.011; Thu, 9 Jan 2025 17:39:33 +0000 Date: Thu, 9 Jan 2025 17:39:30 +0000 From: Yeoreum Yun To: Suzuki K Poulose Cc: mike.leach@linaro.org, james.clark@linaro.org, alexander.shishkin@linux.intel.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] coresight/etm4x: disallow altering config via sysfs while enabled Message-ID: References: <20241221165934.1161856-1-yeoreum.yun@arm.com> <20241221165934.1161856-2-yeoreum.yun@arm.com> <6bbc9b64-3ecb-46c3-8c4e-55dba6301ef3@arm.com> <4f9d2bed-7ce0-429e-83cc-ad6cbcc6085e@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f9d2bed-7ce0-429e-83cc-ad6cbcc6085e@arm.com> X-ClientProxiedBy: LNXP265CA0072.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::36) To GV1PR08MB10521.eurprd08.prod.outlook.com (2603:10a6:150:163::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1PR08MB10521:EE_|DB4PR08MB8198:EE_ X-MS-Office365-Filtering-Correlation-Id: a4f29779-007c-4f85-8ac9-08dd30d49403 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?d4/2TFRGv9cMRrANApmo7J2q/aWwizdPZQ4EwFSthjQYqL6HQpkl2t1qtVn8?= =?us-ascii?Q?OMDGWxm2kUTWxeUhR459D0WZnr5uZRqK8p8RINx26Yk9O1bVw8oe0YxvHkus?= =?us-ascii?Q?ZXzA5uG3RbDwa1DumTaz9rE+/ZYJkUap1vMc7CJYgZPCkfRogmjn1nmkdAKP?= =?us-ascii?Q?ArWWXBhPQIp2htOkUUgHxF/zozOyj2sWFqR+48WDEdNG2zkMW6x/lvRjxqYM?= =?us-ascii?Q?0ROQqv/FyC6qWSwP2t0N2MuoIOOvX036eRAhr8ZBsEoK/rau37nElPcMPKJk?= =?us-ascii?Q?E3+aPqS4W8VPkDf7QRP41NVcUxd8Tge/p/D7QMP2jLkEhCgmHPrxnjhUrAKe?= =?us-ascii?Q?6r71NxTffNYOZgpgbWfeakrsEurpl9oTg7NcuY9UzBj7794Huz46Rq/Zar0L?= =?us-ascii?Q?lyvtzKu6H6ofEzY/xKCNG6k+HTuy1Mq9KxGJbj5ujwNgz6YCdNvQ97hYddsV?= =?us-ascii?Q?sTB/Q9EM9dEGyAw4whzYMWZASeVVGaURXlxZqMVeWOmmmxOOGQ0x4kuNbFTX?= =?us-ascii?Q?Af/JowDOp2mLATouWFimbM1o0FJCGns0Z0ter0AA+1GPYGWqUWJlJwZwZ6sJ?= =?us-ascii?Q?FUraDAFz2s+3UIjDppp4/FXd00ICCLlM9TYMtAS20f35VDcicuQ1ep5oGmi2?= =?us-ascii?Q?uMReaxkjWUJjOdxoOG9VXNpCOUuXfvJh9TIMB3ZRsX45c6K/pb7ImWlonHkE?= =?us-ascii?Q?YL05WVjVL9U4Vpfz/v+vhr/PTrHzx9O5LOo0CLbkH/2qzZARLnS38ydW1j0U?= =?us-ascii?Q?AJqMI0Y4ZDwgeTFOS8C4k6BuE3k2ipKSvGXfHdqPHoowzzLrVLXQaoV3gr+P?= =?us-ascii?Q?TK0VKD70WBXEC8hyajgDOHXrFrtPAkUuT5KLV5tRrcWrv+Qwenk3CmUskA0O?= =?us-ascii?Q?DKtISw4TM3v4aWKRQIerM5R/p2sNUs+6mbyQGPfWmPAAIi66PgW0nycyWJLz?= =?us-ascii?Q?1AkmYnEbc6Fz0yMFQQCyCDTF5gDyOXn6OFgTcu2XKor+9OkETwc7uTjGVhn/?= =?us-ascii?Q?bTxBy221FrabAprVef/390SZG02F8D0FxuRUDNeEdJa29jXWJ5Od19uiKMJi?= =?us-ascii?Q?ZTtX7lLut4nHce9j3r3QjwG+bWRSwzlAp5lGHvLQTnw08sdH3TJOievKUnzR?= =?us-ascii?Q?czGCPKKndX6YohWqTn60k8x0e6Maul27kTYeqsmfgnzhSFYyaImsQizLjp6q?= =?us-ascii?Q?HPWUQc51t4bxcJUfrTs8yxC9+G9gqeYd93pTdbSr9eKO6t+0fH7YlKVUNvjW?= =?us-ascii?Q?9JoF7AhHm80aBkfI2cobI6v2wgO12oMPXEwicmvc+qVMocv0fcBXCXqkcfHM?= =?us-ascii?Q?5olvoubpU7+dZz0jT8ibBePdniZ7SAlOi2O9Z0O7l2obVHnFbQ5T10b3Z/Iy?= =?us-ascii?Q?5xq2PaYhulo1Ii/QxtA1mlkf1uuC?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR08MB10521.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bUDJYXKODAVtudolBblTyn69LREXPD7lLzwnpc6BEEWL7sygxHYlDaAy2dWS?= =?us-ascii?Q?vX71ZQHZxlmVxtFKCud/IdewJuF7oRYcNdkVjLwouEFGLNNSdTwo9i+2/uWc?= =?us-ascii?Q?XSJeQG5mhE7VWdYE2jDq8ap6/ZSYt+PiHqgf8cidLckY4b+sMmLmLbaA9vop?= =?us-ascii?Q?90YQIS+SPG1LLpMFFXs1WAeuM9YQp9wclDkgFZYQI+3j5MgCli8CtjqE4DKV?= =?us-ascii?Q?E4aTv3zPJ5kIE1mtRy7oXnbdE7WYsncQbrEtsJx6dqqjqVMT4VxU4pqYFjwY?= =?us-ascii?Q?Jlx0JJmLmqkf6MeTwA551LFKGIiFT0cdlbc1qE/7srZmqD4RmmbKLQNhqWym?= =?us-ascii?Q?nksJSNRDwfx1D3WDB6clO4b+GSHPv7Oo8q9gYfvDNoaO46oYuaE4+5foud98?= =?us-ascii?Q?5aqDoE3nYUSsvg1SUme2oXIcsHcSCOShS8OYDS2jUrOHgS80EcT/LnbYJAo5?= =?us-ascii?Q?JOLCaWP9oD4TbhrnVJm7KTZ4zziWT0v+7GB6/wQZrEFIkCqjQdToJxERV0Fo?= =?us-ascii?Q?Sh54Jdd1LuQVrFyDtGcZIJB5aKyXBjxgrHN0pO8RXvEKIl72dJfmJF83goG1?= =?us-ascii?Q?YqJgzltL9OH/RVWHt6wDXDJi4DCHrh96pYaWPbNsK99aAl8vWiEwSy1FsE/f?= =?us-ascii?Q?pZdjMVi2OB0ds2An0GxonRAK9cIiOrxdI68Aw0Nq+C5zNmvG/rhBbd2n4rP8?= =?us-ascii?Q?eBpgoGWP9wwT5o2KcWOnpGzY8BBmY/CowGqapLOhGEgcfOyZilvCQcpuBJ2W?= =?us-ascii?Q?Qic5yqZyq/g16R6YtE5lYd1yBcRjs+VcKd//+QVjzJgPvX612dinOVQGaDgz?= =?us-ascii?Q?51Xe5g+6rtwbg3lJHPoeXGnhnFdd8hQAzOFYZRa2bMbl92jeD0C6/9jzrZ1T?= =?us-ascii?Q?77u/Wl5sqCJYYjkSOc2wVPAyR93W14ig8T3imtJoorjUq8JldM0D1mJgw/hB?= =?us-ascii?Q?IoMTAnmYeAOM2DTDgalgSXQUUuWkEHDeBA3c2UPzDS7V3vI8Kz6a92Gv4syI?= =?us-ascii?Q?Aqe40IZwEf91v89fB2ZAQagpLcDOk7ax1p8of+BYtwTaxT852bj0vcVXx/n6?= =?us-ascii?Q?YKbg6Y+CCBYn+ZJQk7nyp2me5d18cnRsReVwRkEDvHwp+vsH4sKHl9aedoNV?= =?us-ascii?Q?2/iiAnM3vBUl8IKkT2/GV5Na0uLgQi6cu2jf37uUUj5CHQYMrbIOh8OwroB5?= =?us-ascii?Q?PbGVIULI44zIDhLHaWDPHxQ61Z7G1I8j/j1xSLqSHIOwwvIgZw3W4LFwyNYT?= =?us-ascii?Q?gwt+3Yu8BFhqxBmiUJqM917xMSs7MjY9p+qQ3MwenE8EDVptEJW+BUZNnmbJ?= =?us-ascii?Q?BaYxr7P10QuKyvKqCl0gBLVdweBHsz18VezjJWxkwiCjH0aZ+Tc/D/GS0QpE?= =?us-ascii?Q?QswlnTZPjCXsmHF7caTMHOdIJSvZWIHtZVZddMUeXPt2+NXJLiD3KJT+lpqR?= =?us-ascii?Q?vNqU2rVbIIZyBUc02543tw3gQ0pWNHN8bAxREc8Zs60S/xF7qtqc56MjZGHE?= =?us-ascii?Q?VxZCqDpJNN7zYEnMYlisJDNt1QEr4+mjdFJlK31YxL3Q+oOGl58ZCnhLnFs7?= =?us-ascii?Q?JMipX4wJbQrpCnclbsmIpWVR+mHkDYNKq/psM0pT?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4f29779-007c-4f85-8ac9-08dd30d49403 X-MS-Exchange-CrossTenant-AuthSource: GV1PR08MB10521.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2025 17:39:33.2625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T2Y1EzN4BMmHzbqQwTl13b2/IOpWeHKGb0S0GO14+XytYEiudcqPow67F0qGJx/+YbFVQia+wN8ExQC9G7/whg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8198 Hi Suzuki, > On 09/01/2025 12:01, Yeoreum Yun wrote: > > Hi Suzuki, > > > > > Is it not better to have separate "configs" for perf and sysfs ? > > > And etmX driver can populate the "running" config, based on the > > > mode specific config. That way, the configs can be updated > > > independently without affecting the running config or the perf one. > > > > > > > That was i've tried but I've accepted Mike's opinion that > > it's enough to check whether CS_MODE_DISABLED via coresight_get_mode() > > in *_store(). > > > > "the .._store functions in sysfs should use coresight_get_mode() to ensure > > this is set to CS_MODE_DISABLED before altering the config, > > which ensures that the trace system is inactive. > > We don't' really care about reading the config if trace is running." > > There are two issues with that : > > 1. Sprinkling the get_mode call in each sysfs stor function doesn't look > good to me. > > 2. Someone preparing for a sysfs session must not be prevented from doing so > just because there is a perf session running. > > > Suzuki > But, when separate the config, it doesn't show anymore the current configuration set by perf. I'm not sure this is okay. IMHO, If perf is enabled, since the configuration show the "perf", I think prohabit to modify config via sysfs while PERF_ENABLE seems valid. and about lossing session, I think this is up to user. That means to use sysfs, user shouldn't use perf to prevent loss its configuration. Am I missing something? Thanks