From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2078.outbound.protection.outlook.com [40.107.237.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09E8B20969A for ; Fri, 10 Jan 2025 21:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.78 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736545259; cv=fail; b=StctHgc2CbYWuaFKI4Uzl60o1kZGcSYCzq8prm+pae5vCmN61lCoCQeihWhCaPzGCcTP+g8lVGAynyDACDFuoEzZjDOl87SHYiuHglxeK/O3BRh2KvvfL5GxMuXu3KCUlWGPjGrbm3rrdE0YQqgvgetkbRUAgErXASGxVjfPKT4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736545259; c=relaxed/simple; bh=XTGuQ+0EdQi2LXRH5iQCp9Rqz9wlWVBWPS0xNGl/Pcs=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=jPx8oaUPCq5td0npoohDWDnBLdqRHHupYA3cX/LHVBIS2tswARPfGdUqdES5fFJ8xNXY3enHWWLDc4fMoME7CMFcpn3w8wu7+tgii5FxngCEZjylpcnSSjCQvQO5EEmC0A1dbafHnhRSdwXfDzdStwU2KVE+20Xp8Sbp+pQYSJ8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TyZyR+6V; arc=fail smtp.client-ip=40.107.237.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TyZyR+6V" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xPBTLTf87YTcpXonUdIyGftHKE7IPWo9OptBjUeDt9UJ3ccc0scvNfmZylUzP4ui+rpwyrymX13+vTxpmxJZXnDf2NzsKlCXSF3qGj2flFZUBXoqdpZwLpDEB6mRbTanNK7r+yKDU1ZPZQEijOPkNi8Hz562pdge4v2vAQug2txcvxb568CTXJgQ/PGRstEDCiqdrVLA6AQL1L6BmlvjfGKMWL4uV9Ks7xG5aJX1S3hyYhRZUDctcTL7YYQiF3qAFaO+zGxDJKZodsEpweYXEqKCxELEsQh8dvgJjhpDAxV0fCuui+y9GZPl9FNqBETx+13wVC0XRHz1O+7dTXb7yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0IC76WFCsF0D+QEJcV93I/ou99GlTLrlNlMub0Qk8A=; b=Bx5zKWhCOcqWhUFl9VCwZmglrY2ghKcdhwldhgLNu52B1569oB9R4x8HZ9Q9rE80Qs5XapY+F1EmvC8i7HIL2JVhJThbvQ8O/M4R+zECim6PM5W0geSAgq57ecnJCQSRA7RP8n2vhJxOylg12yfcnaiKlswlbfD+1ExbDeKdGfLeESIYn9rIR5J2/W/eQ1ergeJIJ6foafVnomH4PQ6vk4AjlSz4XcvwSys2NEwdqNqtmih50BtTBtzTFc77eTs02ovBBOv89WkA/iHF4YEejspZCCjIvcjFvxqUeRi99ql1fw1hXpVbyJcxwzOru9jmGk8f1FNYI7jjEHr3Lgj0nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0IC76WFCsF0D+QEJcV93I/ou99GlTLrlNlMub0Qk8A=; b=TyZyR+6VVZ1jjgGOzm1oEuM+819D6Dghpj9Ga+TofAGgvSv5gcrTCfxuKzUJ8sRXqE5Cx1gpEqYhZ7r0iCxQ40R3TksbuFvXskKoCQmk/3tBOVmCP1O+qUTsfuTQ7Nlo+2FDBZeb0mFu6ZJbEHKeKwut6BwPB5Pmz1iwVp164Hh+gZ6m+h+gPH9TVlUYJdlipZyBIfisodFdJEwSjJ7BnJGHgtB+a72jyPTNGL5XtKN7/k6SZRddIqjDebjEveAmYMnmOK7Z/Sipo/osNCqhUxBpAPkmCvAuDzJLt4PeyAcgnVyoUvpD0hg0rZRB2YZ3yjioUmzpakyFH4rxq4URbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) by DM4PR12MB7741.namprd12.prod.outlook.com (2603:10b6:8:103::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.10; Fri, 10 Jan 2025 21:40:53 +0000 Received: from CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5]) by CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5%3]) with mapi id 15.20.8335.011; Fri, 10 Jan 2025 21:40:53 +0000 Date: Fri, 10 Jan 2025 22:40:45 +0100 From: Andrea Righi To: Tejun Heo Cc: David Vernet , Changwoo Min , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7] sched_ext: idle: Refresh idle masks during idle-to-idle transitions Message-ID: References: <20250110212321.41367-1-arighi@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: FR4P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c9::19) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6405:EE_|DM4PR12MB7741:EE_ X-MS-Office365-Filtering-Correlation-Id: c19c736c-ccd7-4d26-ac16-08dd31bf7564 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gr2+UdaKk2ajf/7DBQqyiGBL3wn9+NXHWMQ4C/Oy+Liu7YiWKAojjoPQvKcD?= =?us-ascii?Q?RseqY/LXkkJL21UkQoV253HembJFdqgS2TJhGpGzoHqzZp2TrqaNDx6Fm1nh?= =?us-ascii?Q?w3unet+iUiKHRmYo6yfrhNVcDQwMleJepPtIho2Vyddm+hPmWzaloyW/1BK5?= =?us-ascii?Q?63IDOZGk5pFbBrOIQ8MEc9WXJO7lRn3OEBpHMY6ZyJ0hJKgqrzvj9XpUIyh2?= =?us-ascii?Q?nWEqfFsu0FbAbaAWd0HiCiiaeS4V7un4K1tVaU5SF1FGhZLL0rHUuZ9bLV5D?= =?us-ascii?Q?UbHEEBpVqo1Ow9rlif5vjLovSu9z1Cvgx6qUEQmsaJfDiX0LFRhNzsdC/Lq6?= =?us-ascii?Q?ZHPgHHszzyBDxFkwD+H0L46lAOGEKQ8CKLlgu/r6dfViugj1pheNvQ90oiUt?= =?us-ascii?Q?W3EmcpUCCIxmKaq1l6Lg+d4Cig+LgB/wcGghOhXKrTfl+mjx4AWzSDvVqSz/?= =?us-ascii?Q?w/z9DoVvN3PGp5WL8/vgUeDeRQN5jUq5sqkerNHuEVhFrBCEv/7fpClviwGm?= =?us-ascii?Q?Kx71rnHzQ5c6Ld1NvtxalxBjHEsrF2yB9AxoJ8TB90gFZIt8CmzWv+IFNRS2?= =?us-ascii?Q?KOlSoroF/H64lIpNNIlHtyEAV+5Hj9EUGRPagb+7lUOyFL0cJtxenRPOB/zh?= =?us-ascii?Q?y4Gho0SknfPjmwsiXrToA4efkTSTVr70rLSl8YEQqdf1UhxGWxZ1aLZ7zI14?= =?us-ascii?Q?IsEUjnNFcHVHg1wsZjA+GH5VzSIBlInRqzIgQydIMjMNT91hFJCYmpnuo1az?= =?us-ascii?Q?degWJLPVRnD0SBnsaOamV6PvSMbQO9S+8V1CpPaNJOlQMgAIFM49zMR2F7fv?= =?us-ascii?Q?bH4yujklleNc4R5XXf1vkPu1Fsf79UEpqnUKkcZ1jCOP2u4LNhWheD3W8qrC?= =?us-ascii?Q?CsYlE0xiuyP192AF0dDDWEMfx5ZPOpl8Ma7ok1nkhQpc9TppfCx/7qZyg7wE?= =?us-ascii?Q?bPzFCwQlRinP9ACT3OHS+/TWa/qL8XuBlc4pSJcRGpDMoTcVniZfNaDN2Q4N?= =?us-ascii?Q?YIMtskb9Ea34jHylCK8/J8HRx3gWGlVwIDFB7iw5rp5aJtBB4sjOLCo6xIdD?= =?us-ascii?Q?arUgSzoa9yTwCMdgTeUUBhtLdI4FzFT+WhW9SS//5O74XhIFDum4LndgjGLh?= =?us-ascii?Q?Jh5BQ64EFq+libibJH2VA/fM7z+WpQImUNMMpPQ4JPQAzXy7qwn1gZIO2DsE?= =?us-ascii?Q?7du14Hx1Su6lvQutz2G6z3vtY72MiuIlmTKO1FXSi1iqqIz6gOS8jo9wiQgN?= =?us-ascii?Q?aOFnlm/IufV9IGLsya5RnqoxWiQuys3apBKEFH2wFaYA/RUQuQH+rUDS/Ego?= =?us-ascii?Q?YQwda3B3nwsijVqcE+TjsCPLNFcZOts66R8rz763r0EL95s1x8Sw6l47ZsWF?= =?us-ascii?Q?aqO5W7DXTlyjr8iz/7QBUrl+dvDa?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6405.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Jxv9L1eQRX1kMBaZn+08yieVO8XxbWpIwwf15zXYo2PcpBhAG8tEzDjf7Xwt?= =?us-ascii?Q?xXhdqb8u6Ofj7dBvtmjBknB3Ucg9iVYigqHoZjNr2aQBtSipxdA6A2eNtG8b?= =?us-ascii?Q?YHU7kO/+SsKaZ2WnM2X7IQdZRsA+rjBaPQSbiZMxc6rUl/ugsnQKAqipKWz1?= =?us-ascii?Q?5Oc2j8oN+CICBJfI6a2LnW1+axxIhk5ZUWlCY2Pgn3+zDXTDDquoVzrh6P1i?= =?us-ascii?Q?PwNDLRkhNgruSkMLVptZT41z38TQnE6aM1mzV5tnkA+MFiSxPX/kj8dJho7L?= =?us-ascii?Q?ilTL00KzGwMfE8QcPvS4ZOsq5B7HW4eXhAYoZ58kFfCSYgu4I6ioMwioyUzH?= =?us-ascii?Q?ITJU+TQbTKUU4hxUCH1b1ya/kqcaxwxpguGFTb263IqOW73ajWTF+xORalXi?= =?us-ascii?Q?+eOn3MFwVj4PquTT9OpUUQQTChLDTeOl3jdYX301ekvKI2Jv3IvqZWBDpPG5?= =?us-ascii?Q?4jDSxvjDPzS5q0FT8jaMoY2QRIPpExROkdAHrD9nAOFad2JS47k5P8Q+pvXo?= =?us-ascii?Q?0IBH+2bZjmh1rf7bYjuML2H0TgBLjCHXHPVKTL1QYva3fZ2mCDIShiQ9+6ER?= =?us-ascii?Q?fCAtTlaewtvgM3MhVjcUyTlzGpVo5bHtQJqxqOqS5NLq1uOvLY8K0cDjmykT?= =?us-ascii?Q?8oPE5C3GtTa+7O4DN3CEckyWgpeiJyii5OhL5jbgJ7YqFLfZyBBFghtxiR58?= =?us-ascii?Q?OUMj3eSN8f7tQNAL/fi4934PY+Ulp0BiGVBH6gRqYKlRK7q++qUjr9W8N32A?= =?us-ascii?Q?Kij+aZFclvYDq3UucQ9I/olCw9srJuWgjyc+Z4NDZC5f+KtZ9zFl1KpaUpkL?= =?us-ascii?Q?KrLs8Lu7wEH36k3x3JLZRaBD8RZ64bPugzgKGV8LILyfEYyL3jVibPNEgYZG?= =?us-ascii?Q?y/yQ9SNbx0LXFH7+gRM2zGqrkvOln0sMLkcrgYp9aa41cIyK0H/e+P7bkp4R?= =?us-ascii?Q?2hM+4t18c4j7Gpi53sm+Mvvz1OxROhz9iau9Ipx1mD7IBNYq1BjxynIcEhKH?= =?us-ascii?Q?kU/4dokesBd/RN0uYSBSUpZHvoHHTVeQF8Uz5YfLMxqdL+3cl/grGD5y91Us?= =?us-ascii?Q?EzcHs/lvwN686pBZC1yaugBQWUizEyxZC1eN1hnCjbE1S8R0L5ZL200+jCcs?= =?us-ascii?Q?fV2LwqlldCvhhRlw5+2wIkbzTrv1cNj5K3yzCR+dNH8Mx2gb65/t+pFeeJJl?= =?us-ascii?Q?/p/SJcJ1QwIRLDw+tY7cltyRCxpK5s/qwfmzl+sLua76bJupGUA2QkTcsgra?= =?us-ascii?Q?iFetOYDSzMWGXHv1Jj6utefIMBZ3g6wmkmUsq9XtluuAyRayr72kQDyDs0jr?= =?us-ascii?Q?JiVL0Mq9RfGmm7N5VDjx9Yv7/7ViIf+qVlH+9BTZ1WicI4C7RMq+ckQ0TX0D?= =?us-ascii?Q?oQudBTaXwMH+NFb9AtByiu/0koMw4TsFTLv3EUzTVqX0x2sqSm9RC7qi8BwK?= =?us-ascii?Q?KlZ3U0oAdqMqGOrgudBdY0c4wwUFVpby2DN3OMaX3fw6b7j8SrTT07prYnof?= =?us-ascii?Q?hQOKT62hPTOpXq+olv3ACqcXKuXNtxUYN5XR7OCE82TB5GcECIzKmnBGpmmR?= =?us-ascii?Q?MIY0wP9Qm8eWq1RVpkNVwmRySSOxsUhwpfRd+w4J?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c19c736c-ccd7-4d26-ac16-08dd31bf7564 X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2025 21:40:53.5688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EHQzgEg5WLmu/K4M2EHBPE3wVdKCoxMY/IBPz6XtocZzWZ79BlY/db/x0Q44aqi+wk7eX8PF5AFVp7y65CyUFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7741 On Fri, Jan 10, 2025 at 11:37:07AM -1000, Tejun Heo wrote: > Hello, > > On Fri, Jan 10, 2025 at 10:23:21PM +0100, Andrea Righi wrote: > ... > > + /* > > + * Update the idle masks: > > + * - for real idle transitions (do_notify == true) > > + * - for idle-to-idle transitions (indicated by the previous task > > + * being the idle thread, managed by pick_task_idle()) > > + * > > + * Skip updating idle masks if the previous task is not the idle > > + * thread, since set_next_task_idle() has already handled it when > > + * transitioning from a task to the idle thread (calling this > > + * function with do_notify == true). > > + * > > + * In this way we can avoid updating the idle masks twice, > > + * unnecessarily. > > + */ > > + if (do_notify || is_idle_task(rq->curr)) > > + update_idle_masks(cpu, idle); > > Sorry about the multiple nitpicks but wouldn't it be better to have the > static_key test before dynamic tests? I'd move scx_builtin_idle_enabled test > out of update_idle_masks() and put that in front of other tests here. Also, > maybe name the function update_builtin_idle() to stay consistent with the > static_key name? Otherwise looks good to me. No problem, all makes sense to me. I'll apply these changes and send a v8. Thanks for the review! -Andrea