From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796AE1BCA1C for ; Sun, 12 Jan 2025 15:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736697335; cv=none; b=KqVj0YK+5pOkZYy6UFDmbjnZivncxF2PMBETSyMSLP8eFCJbUoEawm7U8pG9YAOUJ8qcQBqteSW46OmSMgTohMk5Li5AsZXWkSyH7fg8JLnX53Gm7Bf/CMomTXrk1YkHXgyIxY1j0OpA+llyfRRnXqDr2Txh/dbsJ3ceoYvzS1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736697335; c=relaxed/simple; bh=BQUV4flNKxyB3lH5h8s0kLEUHqjTd2fdC2+E4Gd7RFA=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VoyeqM0l8XSo4Domw6dQTgk5OBSdTq1Cac+buJ6BAhoWnHlZ5zmD/VyP4N+wTwn7WBfG6xXelQ/HEuq6CxQICevAhCHL57uctlHFPImlqOzIb3f5+5ewpdkRsWPuVbUojch/KKfkhAyPxPqtqeQK6nn4cQwH400IbClkk3dxC3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-143.elisa-laajakaista.fi [88.113.25.143]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 7dbb8fd4-d0fd-11ef-9cd8-005056bd6ce9; Sun, 12 Jan 2025 17:54:23 +0200 (EET) From: Andy Shevchenko Date: Sun, 12 Jan 2025 17:54:22 +0200 To: Lothar Rubusch Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, eraretuya@gmail.com Subject: Re: [PATCH v9 2/4] iio: accel: adxl345: initialize FIFO delay value for SPI Message-ID: References: <20241228232949.72487-1-l.rubusch@gmail.com> <20241228232949.72487-3-l.rubusch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241228232949.72487-3-l.rubusch@gmail.com> Sat, Dec 28, 2024 at 11:29:47PM +0000, Lothar Rubusch kirjoitti: > Add the possibility to delay FIFO access when SPI is used. According to > the datasheet this is needed for the adxl345. When initialization > happens over SPI the need for delay is to be signalized, and the delay > will be used. ... > int adxl345_core_probe(struct device *dev, struct regmap *regmap, > + bool fifo_delay_default, > int (*setup)(struct device*, struct regmap*)); Missing spaces, but it seems the original issue. ... > int adxl345_core_probe(struct device *dev, struct regmap *regmap, > + bool fifo_delay_default, > int (*setup)(struct device*, struct regmap*)) Ditto. ... > #define ADXL345_MAX_SPI_FREQ_HZ 5000000 > +#define ADXL345_MAX_FREQ_NO_FIFO_DELAY 1500000 In which units? Usually we add a unit suffix, e.g., _US (for microseconds). -- With Best Regards, Andy Shevchenko