From: Johan Hovold <johan@kernel.org>
To: Zijun Hu <quic_zijuhu@quicinc.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Bjorn Andersson <andersson@kernel.org>,
Steev Klimaszewski <steev@kali.org>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Zijun Hu <zijun_hu@icloud.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
Bjorn Andersson <bjorande@quicinc.com>,
"Aiqun Yu (Maria)" <quic_aiquny@quicinc.com>,
Cheng Jiang <quic_chejiang@quicinc.com>,
Jens Glathe <jens.glathe@oldschoolsolutions.biz>,
stable@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific NVM for WCN6855
Date: Mon, 13 Jan 2025 10:24:24 +0100 [thread overview]
Message-ID: <Z4TbyIfVJL85oVXs@hovoldconsulting.com> (raw)
In-Reply-To: <Z1v8vLWH7TmwwzQl@hovoldconsulting.com>
Hi Luiz,
On Fri, Dec 13, 2024 at 10:22:05AM +0100, Johan Hovold wrote:
> On Sat, Nov 16, 2024 at 07:49:23AM -0800, Zijun Hu wrote:
> > For WCN6855, board ID specific NVM needs to be downloaded once board ID
> > is available, but the default NVM is always downloaded currently, and
> > the wrong NVM causes poor RF performance which effects user experience.
> >
> > Fix by downloading board ID specific NVM if board ID is available.
> > Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> > Cc: stable@vger.kernel.org # 6.4
> > Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
> > Tested-by: Johan Hovold <johan+linaro@kernel.org>
> > Tested-by: Steev Klimaszewski <steev@kali.org>
> > Tested-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> > Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>
> > I will help to backport it to LTS kernels ASAP once this commit
> > is mainlined.
> > ---
> > Changes in v2:
> > - Correct subject and commit message
> > - Temporarily add nvm fallback logic to speed up backport.
> > — Add fix/stable tags as suggested by Luiz and Johan
> > - Link to v1: https://lore.kernel.org/r/20241113-x13s_wcn6855_fix-v1-1-15af0aa2549c@quicinc.com
>
> The board-specific NVM configuration files have now been included in the
> linux-firmware-20241210 release and are making their way into the
> distros (e.g. Arch Linux ARM and Fedora now ship them).
>
> Could we get this merged for 6.13-rc (and backported) so that Lenovo
> ThinkPad X13s users can finally enjoy excellent Bluetooth range? :)
This fix is still pending in your queue (I hope) and I was hoping you
would be able to get it into 6.13-rc. The reason, apart from this being
a crucial fix for users of this chipset, was also to avoid any conflicts
with the new "rampatch" firmware name feature (which will also
complicate backporting somewhat).
Those patches were resent on January 7 and have now been merged for 6.14
(presumably):
https://lore.kernel.org/all/20250107092650.498154-1-quic_chejiang@quicinc.com/
How do we handle this? Can you still get this fix into 6.13 or is it
now, as I assume, too late for that?
Zijun, depending on Luiz' reply, can you look into rebasing on top of the
patches now queued for linux-next?
Johan
next prev parent reply other threads:[~2025-01-13 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 15:49 Zijun Hu
2024-11-18 12:43 ` Johan Hovold
2024-11-19 2:13 ` quic_zijuhu
2024-11-19 7:10 ` Johan Hovold
2024-12-04 4:50 ` quic_zijuhu
2024-12-13 9:22 ` Johan Hovold
2025-01-13 9:24 ` Johan Hovold [this message]
2025-01-13 12:37 ` Zijun Hu
2025-01-13 13:55 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4TbyIfVJL85oVXs@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorande@quicinc.com \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=johan+linaro@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=pmenzel@molgen.mpg.de \
--cc=quic_aiquny@quicinc.com \
--cc=quic_chejiang@quicinc.com \
--cc=quic_zijuhu@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=steev@kali.org \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®