From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E88822A4FE for ; Mon, 13 Jan 2025 12:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736772145; cv=none; b=CS9tTICimgMIl9iYPiHUnJwReujOhGAZqb7CgCyVkVXOefu++Pk31+9O1k2bB0PqCaAz7J7pvbmh31JsVhq4USW4Byr2iKyP5Oa4K1Go4o2UZgLpfHgvWr8By5MAoqm4hU1NOntsPAeEEgZxhePZM4X3zVEJ3oQ8I8wgf4c4uUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736772145; c=relaxed/simple; bh=O8g4Mg96eYG689tC155rLwohHCHRlBMHebjz0QN/N8c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H23oDyVtkzKEjdLfiZwPlOQtEZ9AO/EHSdiJL3I8mD8nX0AkgQqoxJe9WzjH420WtVgyEuQeWpAUss3kggPNv5h6IGq98glN9d+KsPfRk2dSTPVYXQjWGNBEPWRgJi+ozViJKAL+mFkpl0A8zfDuTfzN9a7ZgtThzVlofQpmYZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tXJlf-00063V-Mf; Mon, 13 Jan 2025 13:42:07 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tXJld-000GE6-3B; Mon, 13 Jan 2025 13:42:06 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tXJle-007tyy-1E; Mon, 13 Jan 2025 13:42:06 +0100 Date: Mon, 13 Jan 2025 13:42:06 +0100 From: Oleksij Rempel To: Andrew Lunn Cc: "Russell King (Oracle)" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , Andrew Lunn , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Phil Elwell Subject: Re: [PATCH net-next v1 7/7] net: usb: lan78xx: Enable EEE support with phylink integration Message-ID: References: <20250108121341.2689130-1-o.rempel@pengutronix.de> <20250108121341.2689130-8-o.rempel@pengutronix.de> <80925b27-5302-4253-ad6d-221ba8bf45f4@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <80925b27-5302-4253-ad6d-221ba8bf45f4@lunn.ch> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Thu, Jan 09, 2025 at 08:33:07PM +0100, Andrew Lunn wrote: > > Andrew had a large patch set, which added the phylib core code, and > > fixed up many drivers. This was taken by someone else, and only > > Andrew's core phylib code was merged along with the code for their > > driver, thus breaking a heck of a lot of other drivers. > > As Russell says, i did convert all existing drivers over the new > internal API, and removed some ugly parts of the old EEE core code. > I'm not too happy we only got part way with my patches. Having this in > between state makes the internal APIs much harder to deal with, and as > Russell says, we broke a few MAC drivers because the rest did not get > merged. > > Before we think about extensions to the kAPI, we first need to finish > the refactor. Get all MAC drivers over to the newer internal API and > remove phy_init_eee() which really does need to die. My patches have > probably bit rotted a bit, but i doubt they are unusable. So i would > like to see them merged. I would however leave phylink drivers to > Russell. He went a slight different way than i did, and he should get > to decide how phylink should support this. Hi Andrew, Ok. If I see it correctly, all patches from the v6.4-rc6-net-next-ethtool-eee-v7 branch, which I was working on, have been merged by now. The missing parts are patches from the v6.3-rc3-net-next-ethtool-eee-v5 branch. More precisely, the following non-phylink drivers still need to be addressed: drivers/net/ethernet/broadcom/asp2 drivers/net/ethernet/broadcom/genet drivers/net/ethernet/samsung/sxgbe drivers/net/usb/lan78xx - this one is in progress Unfortunately, I won’t be able to accomplish this before the merge window, as I am currently on sick leave. However, I promise to take care of it as soon as possible. Best regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |