From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7DC198E9B for ; Tue, 14 Jan 2025 16:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736871026; cv=none; b=IXduN9LDUndLgvsCbyEnxJJ7/OoJlF+FWDmDapW11E/RXKlZn8RKajNcyEmovkmlxLzWRpaqGP6HgLGjddWGfDrBS/19U9GxfT3Yc3FCBfPp+zB1A0IUCMc86Lt4EdBXY9pBlR3PSnig4HoXuBjC7pRBzgl14+189T9W5kkMBBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736871026; c=relaxed/simple; bh=hRkIQfcPhQq2KB+mXgPU/2FZFWXV5nu4SPV+LBbRzd4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U4zHYMknGTLUhMocTC84bZGDVNI9g8Po+W1lncToM8aoUd1vwah5tR+o+8S9hHMEI3Sn5h7lCpZrgTTgU3EiUkzKxLSbRmojIltgjiaQeJ7UWrFImY7yi6EPN9tZcC7NPM3fL3Z36/q9VlXXQxG6upf04KqkYHkOfTxwDcnsCtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e9GkMCqt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e9GkMCqt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1D05C4CEDD; Tue, 14 Jan 2025 16:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736871025; bh=hRkIQfcPhQq2KB+mXgPU/2FZFWXV5nu4SPV+LBbRzd4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e9GkMCqtgmjWEfMmTwE7zgxX0+OccqGolW77ETKN7wkLWIgQpczH+hN3Y6TKrA0rS 18OB/PAAJOOv+N3e15iF0zfNl2vOJJnRA20Bpyc93iltX7mxajunrvWMa9yu+X51zZ WJNttWC1OI0GuK8joBcLc9LzcLDX5Z3pxjtIbbNZpja5WJHzCYpO1p2JrQ/U5biQOf X9fDeo7ZWwXvgBgoMMcTHL4MdQSthgy7fji6RXuPjLQnJASZTHpw7gI57K1iXyTDNc z3xGWiAcAjhzgXD8X/3wfXjqnSnRnXoBymnVcY+h0KeWg1DahNh6xLNF7bAyLGauIC Pu77PdC1mvEmg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tXjUq-000000000P2-09nu; Tue, 14 Jan 2025 17:10:28 +0100 Date: Tue, 14 Jan 2025 17:10:28 +0100 From: Johan Hovold To: Daniel Danzberger Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] gnss/usb: Add U-blox 8/M8 device id Message-ID: References: <20241026075857.3651161-1-dd@embedd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Daniel, and sorry about the late follow up on this. On Sat, Nov 23, 2024 at 11:38:42AM +0100, Daniel Danzberger wrote: > this is the lsusb -v output: > -- > root@test1:~# lsusb -v -s 001:002 > > Bus 001 Device 002: ID 1546:01a8 u-blox AG - www.u-blox.com u-blox GNSS receiver > Device Descriptor: > bLength 18 > bDescriptorType 1 > bcdUSB 1.10 > bDeviceClass 2 [unknown] > bDeviceSubClass 0 [unknown] > bDeviceProtocol 0 Not sure why your lsusb says unknown here, but this is a CDC-ACM device: bDeviceClass 2 Communications > bMaxPacketSize0 64 > idVendor 0x1546 u-blox AG - www.u-blox.com > idProduct 0x01a8 u-blox GNSS receiver > bcdDevice 3.01 > iManufacturer 1 u-blox AG - www.u-blox.com > iProduct 2 u-blox GNSS receiver > iSerial 0 > bNumConfigurations 1 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 0 > bAlternateSetting 0 > bNumEndpoints 1 > bInterfaceClass 2 [unknown] > bInterfaceSubClass 2 [unknown] > bInterfaceProtocol 1 bInterfaceClass 2 Communications bInterfaceSubClass 2 Abstract (modem) bInterfaceProtocol 1 AT-commands (v.25ter) > iInterface 0 > CDC Header: > bcdCDC 1.10 > CDC ACM: > bmCapabilities 0x02 > line coding and serial state > CDC Call Management: > bmCapabilities 0x03 > call management > use DataInterface > bDataInterface 1 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x83 EP 3 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 255 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 10 [unknown] > bInterfaceSubClass 0 [unknown] > bInterfaceProtocol 255 bInterfaceClass 10 CDC Data bInterfaceSubClass 0 bInterfaceProtocol 255 Vendor specific > iInterface 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x01 EP 1 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x82 EP 2 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0040 1x 64 bytes > bInterval 0 > Device Status: 0x0001 > Self Powered These device are currently handled by the cdc-acm driver and there is currently no point in moving them to a different driver (and potentially breaking people's setups). I have one of these here myself, and the fact that we already have a driver for them was the reason for me not adding it to the GNSS USB driver already (I even think I used this device when writing the driver). > On Tue, 2024-10-29 at 13:03 +0100, Johan Hovold wrote: > > On Sat, Oct 26, 2024 at 09:58:57AM +0200, Daniel Danzberger wrote: > > > Adds support for U-Blox 8 GNSS devices > > > > Please post the output of lsusb -v (or usb-devices) for this device. > > > > IIRC this is a USB CDC device, which is already managed by the cdc-acm > > driver. Johan