From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30FD913D891 for ; Tue, 14 Jan 2025 18:22:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736878944; cv=none; b=Gkjl80ibuYflVQ0gQH6zNLP5+aKKnKEF+5ift7MyfrokFLdIq2u4xQ15ZDTJ13CmIAWfU+7kqZVhfozv/H+0VgNe75vOMPF7b5rsLJgRkrPkP9WvzEt3at+XyorQknajbhV14ns+41PfRX8Od4E9bGCoK4YYEPs9VuEmluOGEXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736878944; c=relaxed/simple; bh=QgCH66yBKmgIEQvZDPtutVD/4L/gLHteQN6pUfMZWLA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i746Pkt8NObQyR8xFSNPUFqB2+UsiDwAdONhSfJ5yDCgG7c8OjEOV75Eg7OcbYPCsjLkso/4tQTGHLuPyoiaDse1sUkLiBseWePEEaDs0WFkrl/Q3aBurmtvHIJDOYJGCzvGI9jjjnRPYHLfdUbMYAz14/6LXeIvis6pQUuTHuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=N6H2aQfN; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="N6H2aQfN" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QgCH66yBKmgIEQvZDPtutVD/4L/gLHteQN6pUfMZWLA=; b=N6H2aQfNiTui/l1jOMm6NNU7Os n+RoUgxE30I3kNCg9yG7lRZpS2UmJMCGgxosRDJWBZXHhJMvVcTNfC7eKD3BRNc7cs8bUsXs7pOOt zu5WBt6iE1rbdk2gnsxcCnbr0Z+75BpO8E9ixQx/Sdwif+oo61VkxlTDTA/22H1FmambpMcdly82E rgW/blsb9qkO/XWzB3+obxgLbj/2r+kEoRF0rgprhwfKpNpa+FzkJJ3fPKnCiKakjowKrvFibmSae 0T/ToTcoOb4YkYQZRsy4Z1FSlKzIu6u/RAiJIZKT/oH7R2zwUmd9zpqNT3LcM3jkA/ziLt71s4lrZ cg2+MgtA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tXlYM-00000001v5O-0gP6; Tue, 14 Jan 2025 18:22:14 +0000 Date: Tue, 14 Jan 2025 18:22:14 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Yang Shi , arnd@arndb.de, gregkh@linuxfoundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, liushixin2@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] /dev/zero: make private mapping full anonymous mapping Message-ID: References: <20250113223033.4054534-1-yang@os.amperecomputing.com> <2dda50aa-e4a1-4664-b8fa-56ba975db329@lucifer.local> <65691afc-615a-4716-8a2e-1f43bc65111c@os.amperecomputing.com> <3fdcd6a5-27fe-411b-923c-b7410e4cbda9@lucifer.local> <10f5cb31-e9fa-4574-b36d-0e685fec5cda@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10f5cb31-e9fa-4574-b36d-0e685fec5cda@lucifer.local> On Tue, Jan 14, 2025 at 06:19:32PM +0000, Lorenzo Stoakes wrote: > I see shmem_zero_page() does change vma->vm_page, this is broken... ugh. I I think you mean shmem_zero_setup() and vma->vm_file, right?