From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C171D47BD for ; Tue, 14 Jan 2025 23:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736897167; cv=none; b=rlk69bEqlSD/1UihCMTz/H19RyvsPu8OT6CMbiNQhMn3dcE77dcWWtAm1IqtfjchsPIO1ugIb/9wtBTxfIvNQ4/TAol8lSkxmjAYxDjT4C4oXNB7mixhYjdHL2SLZrglkfA8lrwWPQpeTuLxuc0tST4dcOhawkbio5pwQQzAPgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736897167; c=relaxed/simple; bh=M/zA5myD7TcCfQp5oOilhju7M9SI5LbUs6P30WBHxK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iQS7PxZ6O5nLO1Ri6+7D6OmwL8qpEgxUh2SpsBadDyWFobXLhIF5cAJ+FoFw7v3RlaKoy/4b/rdB5SLJU8qK/HbBP0wBndLV2PsdQUL1l1YLEaexN70w6jtptVld1lGFCYTL9+RtvLocbizWzldJtcdle6gZpJDapXvkMUqL+Hc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=nZayV3xB; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="nZayV3xB" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21634338cfdso101300015ad.2 for ; Tue, 14 Jan 2025 15:26:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1736897165; x=1737501965; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=NV4PmVLk16CjHPkaMxzQZluPn2DMGP8myx2jLb4e+Pg=; b=nZayV3xBwQ2gIMwoZXpS8KOs/Y7VgcZn7BL6Tlj9Uy/1J2vH4XNvFgKEXMXpTmKx5O 8rycF5UxSE+KSwrkgDxQu7hxNAWoDM+5EUW+JD8cw30L9cRFl7SJcpsHLyFu8OiOURHe M/BqM+f8QmhfypSSteSuvtcsxgCefShNoOwdQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736897165; x=1737501965; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NV4PmVLk16CjHPkaMxzQZluPn2DMGP8myx2jLb4e+Pg=; b=M8PhbLur50RvrakzSxF+pbHAVcmtnlhrWS8SlJ4/PWmwA6qWh2hPG6lnZP+3C1yNCd ekgI2WaYXru1pLzzXO0TCAC06LHTBYot7VAp2OP2txGD3fP+L/7jgkHj1hUcOMjVjK8E lLWDlP8Up5/KTCmKqpKg36fUOrG5r+CtaQI9jVlKkqjpRfmzSudAAgpOq6P6mdM/9+Lu rvvRDoiWf22Uka4yIg6yxHx8DUpvsvmOIDDco6s8oFkNh7Xq4TG9vzlqI6t+z0sK3JgN gVJvdECCE1G3MFvxyhf3U0sl/l4FTdVD8ti6g+HQgaAyln9ghcj1Khx6dEN+CglyEd9S JBsw== X-Forwarded-Encrypted: i=1; AJvYcCXkGujgigIgl5r8W2r56gB3uzpTatphFcuxo5WOQvdjYaCuWqfhR4D+OgGPJNKM5kR0QiecFvj2hJb1i8s=@vger.kernel.org X-Gm-Message-State: AOJu0YxkDnb6UM++GhHUeUBve1NDAzfqIBgXJRR8kzETkDgjLSB0OfbF /B9GTIdph3eBYpTA8Z3l9pXc+X3akBJf5n3qeNlLp6bG4OX7YM3i3UyZ1MucNtw= X-Gm-Gg: ASbGncspUsUoTwP6SaZJUElpdMj1Y868XW+DahsKIvoZPiTR7aQ40lRDUh8dN0NwLxs 9SE3DW4OfMuKvrhgRgQiU/kqjo/6EM1WlPiH5H0JoxdbUPBTPX4fOR/R95B0FNJPdkSvzI7vUPV Ri0oxqqVPq5GDpXZxbv68tzy17RbfFkr20m9ncJOw3bXMocRgD11wxMSpvlbWR13QOO809eKYg4 qRmhqCY+ms7+1mb8aCYXsD2BoB22xT9hrT1L8xfF8TMtP46zDGphydXgPnOIhHm/fb5ewiTwLXD PqhKf+BHgS25a0dwrNamous= X-Google-Smtp-Source: AGHT+IHFPFr5ciMlkXuJKMpdKsuIG5B3oWU/wQ0JkBhOmdVXMKwtxjYVcUrFRpNdNfwpkhHQYwGirQ== X-Received: by 2002:a17:902:da87:b0:215:9642:4d7a with SMTP id d9443c01a7336-21a83da6a40mr434425125ad.0.1736897165605; Tue, 14 Jan 2025 15:26:05 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21a7f1sm71225625ad.124.2025.01.14.15.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 15:26:05 -0800 (PST) Date: Tue, 14 Jan 2025 15:26:02 -0800 From: Joe Damato To: Daniel Sedlak Cc: Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [Question] Generic way to retrieve IRQ number of Tx/Rx queue Message-ID: Mail-Followup-To: Joe Damato , Daniel Sedlak , Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org References: <20250113131508.79c8511a@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: On Tue, Jan 14, 2025 at 09:32:26AM +0100, Daniel Sedlak wrote: > > > On 1/13/25 10:15 PM, Jakub Kicinski wrote: > > > > We do have an API for that > > https://docs.kernel.org/next/networking/netlink_spec/netdev.html#napi > > but unfortunately the driver needs to support it, and i40e currently > > doesn't: > > Thank you for the link, I somehow missed that part of netlink... > > > $ git grep --files-with-matches netif_napi_set_irq > > drivers/net/ethernet/amazon/ena/ena_netdev.c > > drivers/net/ethernet/broadcom/bnxt/bnxt.c > > drivers/net/ethernet/broadcom/tg3.c > > drivers/net/ethernet/google/gve/gve_utils.c > > drivers/net/ethernet/intel/e1000/e1000_main.c > > drivers/net/ethernet/intel/e1000e/netdev.c > > drivers/net/ethernet/intel/ice/ice_lib.c > > drivers/net/ethernet/intel/igc/igc_main.c > > drivers/net/ethernet/mellanox/mlx4/en_cq.c > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c > > > > Should be easy to add. Let me CC the Intel list in case they already > > have a relevant change queued for i40e.. > > Thank you for directions, will check Intel's mailing list and poke around > with implementing that. I previously tried to add support for this API to i40e [1], but got pulled into other stuff and never picked it back up. Wanted to mention it in case it is useful for you. [1]: https://lore.kernel.org/lkml/20240410043936.206169-1-jdamato@fastly.com/