mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: Uros Bizjak <ubizjak@gmail.com>,
	Laura Nao <laura.nao@collabora.com>,
	bpf@vger.kernel.org, chrome-platform@lists.linux.dev,
	kernel@collabora.com, linux-kernel@vger.kernel.org,
	regressions@lists.linux.dev,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	"dwarves@vger.kernel.org" <dwarves@vger.kernel.org>
Subject: Re: [REGRESSION] module BTF validation failure (Error -22) on next
Date: Wed, 15 Jan 2025 09:38:18 -0800	[thread overview]
Message-ID: <Z4fyijoUoeTnOuDM@pop-os.localdomain> (raw)
In-Reply-To: <c067bc3d-62d6-4677-9daf-17c57f007e67@oracle.com>

On Mon, Dec 16, 2024 at 03:19:01PM +0000, Alan Maguire wrote:
> Seems like there's a few approaches we can take in fixing this:
> 
> 1. designate "__pcpu_" prefix as a variable prefix to filter out. This
> resolves the immediate problem but is too narrowly focused IMO and we
> may end up playing whack-a-mole with other dummy variable prefixes.
> 2. resurrect ELF section variable information fully; i.e. record a list
> of variables per ELF section (or at least per ELF section we care
> about). If variable is not on the list for the ELF section, do not
> encode it.
> 3. midway between the two; for the 0 address case specifically, verify
> that the variable name really _is_ in the associated ELF section. No
> need to create a local ELF table variable representation, we could just
> walk the table in the case of the 0 addresses.
> 
> Diff for approach 3 is as follows

Hi Alan,

Thanks for your detailed analysis.

Is your patch formally submitted and merged? A quick code search with
variable_in_sec() tells me no, but I could very easily miss things here,
hence I am asking you. :)

  parent reply	other threads:[~2025-01-15 17:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 16:08 Laura Nao
2024-11-07 15:05 ` Alan Maguire
2024-11-13  9:37   ` Laura Nao
2024-11-15 17:17     ` Laura Nao
2024-12-04 15:53       ` Laura Nao
2024-12-05  7:36         ` Uros Bizjak
2024-12-14  4:41           ` Cong Wang
2024-12-14 12:15             ` Alan Maguire
2024-12-16 15:19               ` Alan Maguire
2024-12-16 21:28                 ` Stephen Brennan
2024-12-17  8:02                 ` Jiri Olsa
2025-01-15 17:38                 ` Cong Wang [this message]
2025-01-16  9:51                   ` Alan Maguire
2024-12-05 10:33         ` Jiri Olsa
2024-12-05 10:35           ` Uros Bizjak
2024-12-06 12:35       ` Jiri Olsa
2024-12-10 13:55         ` [REGRESSION] module BTF validation failure (Error -22) on Laura Nao
2024-12-11 21:10           ` Jiri Olsa
2024-12-12  9:22             ` Jiri Olsa
2024-12-12 21:49               ` Stephen Brennan
2024-12-13  9:26                 ` Laura Nao
2024-12-10 20:42         ` [REGRESSION] module BTF validation failure (Error -22) on next Kumar Kartikeya Dwivedi
2024-12-05 10:01     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4fyijoUoeTnOuDM@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=alan.maguire@oracle.com \
    --cc=bpf@vger.kernel.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dwarves@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=laura.nao@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stephen.s.brennan@oracle.com \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®