From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDCFC8F77 for ; Wed, 15 Jan 2025 20:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736972009; cv=none; b=aGTc5wfZCzgbPSXDxX/gDh8TFoM8JuyvDM9Dqh5Qz0VA+9Vodn8yZN6aXF+s+Rh8cXq0jftIsA0lZISJpYKV596t/55N7P58K9vmI2Iv7vhsO7DWty3ZufYvzXQlWNozwoQOg8QahwOcL01R3rU7Sd8vfOH6FN+QtDQqM5o440A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736972009; c=relaxed/simple; bh=obL59OqvVsLb3h0JUfcLhYG6T3UZLnSVbdV4KF6DQRQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=laAROzX6z31zgh8VLa3qZd0xIPUOkVLM6yBO/AgG3vyBacqm0BuFqilsMYb670x4E3ViJlxUia/mrGA1vc14loIghFl2zivBKQCU0yYE3K4ojjZxtDsPFS0ActAs30G0URQ2dXEjc1y+XX8Yx52PKODDEku51Ymr8xh3kbSZctM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=siiJZmgn; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="siiJZmgn" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2166360285dso1396465ad.1 for ; Wed, 15 Jan 2025 12:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1736972007; x=1737576807; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=10HfpUL4vbzTE8z3sE1cNiKFmGmMremYjdqrg8+vicQ=; b=siiJZmgnXJHaDwrPsMMx8d9Sz7R1T6/gguYOvfG/LdtmewBKeskJR+LWjcVKRevxRj wAYDMkU586Y0YfZWrQ7SACMY7U+1p2LhU/I30B9z7gZRAQo0upZut97RIVJcB/et9cN/ O422VsIAd4G/0FpgtvvaKye6zN8URPYylIVv23XLMKob/vJPngw6qCMkWBsvFIIAtXH9 9b2rLUp+MamX1I0XxczlDi70CC8UGS1CaKTz3SnPg+ulmCEpQTlbwVrcjierU5ycptkT StOVtAiGSzdX0LZSSmqG/2hbUF751bu5oLKhg353h3M1W/kSyHRsMgRYzdK+u/Cs1jLV 7k8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736972007; x=1737576807; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=10HfpUL4vbzTE8z3sE1cNiKFmGmMremYjdqrg8+vicQ=; b=PmgP7RnNwL4vSZO43L7oxc7Y22jpxnM/LTG5kEExn35oH0qPn7CXTK0GNKe9/iYYq/ 2vbl7K2cKz0IOa2L67Ap17X5Z8TNcVS0xTgTBur0Ds6VPHhHcnVIs+J9/c/qsdZNyofR oxSLSf4jv6rDBLOx2LxA6AkQzcjono9OAvCw3YFaqdb3yIG4l3OVKg1WLIx44vzx3kpg lPBKfWmrXX5DFwCaS3H8k9sI9bHdhyfFwuApC10ch7n/Wtw4m8GpfVm797N21BqoANM9 nJOM2gXWhSR7acF2xbeEFl6BeFGT+Z+DfX6xIuqzyyPEtV1yfVwEwuon4/otqyEPK1q5 kbRg== X-Forwarded-Encrypted: i=1; AJvYcCWPXKClPS8V41XspzBjAByzhWUaS9/s+MacWMHSvjYaMpXDjhSo0LD0KpQju5v+2qM+d41lVHif84GOyIA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf5fNId75dESZ1+MxR4xULp/cyw09ROW23tpdryTh7uEDoxzNu YmI7YM3mPkQPhLg4ViBrwYmQ0Ts50X1iKe5Mutd6Ys1ldpWwE5b9RDDf4qlqjqk= X-Gm-Gg: ASbGncs8rjUZL5oqEsXeNK9f9TWAMsf50w4JfRp5NODc48LzkmIn/QOu9QDKJx5pvVE LRLvIfsUFZ5bA6uAKOVGKLoTb5ECx0/clGlyVYpyGlGtfChKMa2oNoWtkQoCqKh6GJRR10PGLYk ifC7Vt8HXw5jApGyU6Tt5+g2ieYJrILY6dCFaTZ5emLBZy99JyGK1hrCvI9w98b3rpZDHB4rAvS OUPPDU7IR3Zdt+nyroqX84K4DFe7r4r+sd8e81AQmwVHSHh7W/iOCMXZsNiKrfZ1w2UQe7QnR+o TmSiGdBH30PLfmzhDEEiEgFnPKxqpJdH X-Google-Smtp-Source: AGHT+IHnPTYH1M0KygFma+wZwcgjOIPDIchY7x9E9r6aOBRHS7OOYUKAFanmi2DmZuTGwBHC8Eg84w== X-Received: by 2002:a17:903:32ce:b0:215:b8c6:338a with SMTP id d9443c01a7336-21a83f338a5mr470115445ad.4.1736972006983; Wed, 15 Jan 2025 12:13:26 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f219f0dsm86031465ad.139.2025.01.15.12.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 12:13:26 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1tY9lT-00000006JFt-3Jp5; Thu, 16 Jan 2025 07:13:23 +1100 Date: Thu, 16 Jan 2025 07:13:23 +1100 From: Dave Chinner To: Christoph Hellwig Cc: Andrew Morton , Al Viro , Christian Brauner , Gao Xiang , Chao Yu , Andreas Gruenbacher , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org, gfs2@lists.linux.dev Subject: Re: [PATCH 6/8] dcache: use lockref_init for d_lockref Message-ID: References: <20250115094702.504610-1-hch@lst.de> <20250115094702.504610-7-hch@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115094702.504610-7-hch@lst.de> On Wed, Jan 15, 2025 at 10:46:42AM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > fs/dcache.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/dcache.c b/fs/dcache.c > index b4d5e9e1e43d..1a01d7a6a7a9 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -1681,9 +1681,8 @@ static struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name) > /* Make sure we always see the terminating NUL character */ > smp_store_release(&dentry->d_name.name, dname); /* ^^^ */ > > - dentry->d_lockref.count = 1; > dentry->d_flags = 0; > - spin_lock_init(&dentry->d_lock); Looks wrong - dentry->d_lock is not part of dentry->d_lockref... -Dave. > + lockref_init(&dentry->d_lockref, 1); > seqcount_spinlock_init(&dentry->d_seq, &dentry->d_lock); > dentry->d_inode = NULL; > dentry->d_parent = dentry; > -- > 2.45.2 > > > -- Dave Chinner david@fromorbit.com