From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAE5B43AA9 for ; Thu, 16 Jan 2025 05:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737003838; cv=none; b=vAjUv7p7Ht0IRTMrCypCFggbpeGVKvS0na9CM8YfTOCamYpgqiiDVwJVrQCuNiBs8iQWzKMhpdojn4CisEylNp1zTzXqmcRH3VkfaWmlAZnI/CPy3VKw9d8y7W2VKfamtCetwdRaw/pwRVMFu4+2zIUYdP0+6hnEaLMyH6uKfO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737003838; c=relaxed/simple; bh=wELArgmung28UVW6a1djIOqJloxqOE5PObrjaTGmt24=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K8x9/X9+20uRuTka28ngCun7k0l9JrGyzrSZ9q7HDkFyKSL3xbXn/tR3N0f5nQ5HafyqEb1uATl8YCKsjuliDB06+dY78Tpp/zPeOAkUxcYQsL8N+7XzL8l/qHxqzP3XrC3XyN2JU6Xcqv8vaUyTJ5MH6lwMW4a7mRMPsSGS54s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=v0paJONS; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="v0paJONS" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2161eb94cceso5158425ad.2 for ; Wed, 15 Jan 2025 21:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1737003835; x=1737608635; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RQtwcz66cRpnEOfOa/HyiuZRqWSGLaKRKp3+zlxh6e0=; b=v0paJONShVSwTov0vlckCCKx166z0WlVMcBq0nm7xyn3POJk0Y9jS/Im2nI4/GOXhQ csFjAZkT3QQI66xORHtTMnh85IBerAjVLvO5mm6QnbLs0IKsd0yYmmMqTj7hjbhbkBDS SpPlrJVVpJMjWuwidRR7s86gSmShUXs3uaPpJhAc3Pf4h/UprFWOl+1OPQbszhj0d18M zn9D0WMzjDnNxW8jbnSq3r0yryiR0ZZoRQvGbw0VYbPM1rUPGKOGBtIfM29oFE7PsLnf Bi7yBtDxjeTAu2hiXoYBOFTXU15Hc3bBDCA2erw9Gp9QLr71cAI08CbHmv3CovAU3dMa 1aiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737003835; x=1737608635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RQtwcz66cRpnEOfOa/HyiuZRqWSGLaKRKp3+zlxh6e0=; b=QYGnfH7j1wvoF1U666QpU4qzen1JSfTB1LQyd9275cFTtMw8ICxKnjL1WcckFEZ/Lf dYf60LNH1eodaypLg9eA9/85KMcEtQozFfVTCR3fhS9Kk6rqIXDn5mD4EmJWCRtCY0PG dgckgS90sCl4c2Vu0vtMjC2zubFs0gkoRJ2ynlFZ6A4VzPHHflbMVug+aRDyYzjAy1c6 GJwMew6QQD3XjzdBkzFeJviyCDomvjlIWz6Pd6jlzZ9lpxD2AQbqa1ROCLRODAERvejC o/r3ahIHB3MywW2MvS98XkkgK4UJwBZZ+V2u5IpRwX7gKGRMTWjbc05+t1u3JaylVz21 UuAQ== X-Forwarded-Encrypted: i=1; AJvYcCX+PtKYs8Q3mn1sJwhQHxvKEsw7nQPHMg43Odi8dxAD1LI3GObIBa2qB6vm6Fk1ChpwwQ4CQ+tuOSy5R7s=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3/ekQmaH5o4tmCdzUbk2jqxQt7XqlvA82Nc1ar1wPhb/5PNgu sNsT+VdVMj8giMkC067B8HTYcIXcP/77piJhtfvvANv3i5rLY70tWNE5+FvM2MU3p5ri5PnVs2T J X-Gm-Gg: ASbGncuB1Gfo5iiDUXeqOd9YQ3lB6fCfOuJHgmBodF89P8vodJh3xSporgQWGulqLIl ORNBxo0/lRnGNeVy5MBI/oPRNiqXFe1KpPu1O2yEcA08AgGoo08bQyFSputqMzhaGEoNITkx68B eJXHZi4oUycnasKhgHIzSgJEQ00IzZ80EtGEeRXqosuqKQ2tTiJIU/lMj+sOhmSx+ihuJ/NiVaQ ARID+Ge4vVY+Lv7Zyps7hEbDp8S/I9FtBfTUciweqyhGV2RgoEtPQBm3dwNWe/Vtt/6bW0GsFWK 1APtV4LtAdH65R2pizzOyGHjd5BnMgqi X-Google-Smtp-Source: AGHT+IGNOhZ2CDB3dC9ypPRx2+QFrztyTh30xO+H1dvtRXfxPIdj2LE0KDNO2Mwf1ivGr5YrWG2u9A== X-Received: by 2002:a05:6a20:244d:b0:1d9:fbc:457c with SMTP id adf61e73a8af0-1e88d0a4771mr34957994637.36.1737003834927; Wed, 15 Jan 2025 21:03:54 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4067f72dsm10406495b3a.145.2025.01.15.21.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 21:03:54 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1tYI2p-00000006SjT-2V99; Thu, 16 Jan 2025 16:03:51 +1100 Date: Thu, 16 Jan 2025 16:03:51 +1100 From: Dave Chinner To: Al Viro Cc: Christoph Hellwig , Andrew Morton , Christian Brauner , Gao Xiang , Chao Yu , Andreas Gruenbacher , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org, gfs2@lists.linux.dev Subject: Re: [PATCH 6/8] dcache: use lockref_init for d_lockref Message-ID: References: <20250115094702.504610-1-hch@lst.de> <20250115094702.504610-7-hch@lst.de> <20250115203024.GB1977892@ZenIV> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115203024.GB1977892@ZenIV> On Wed, Jan 15, 2025 at 08:30:24PM +0000, Al Viro wrote: > On Thu, Jan 16, 2025 at 07:13:23AM +1100, Dave Chinner wrote: > > On Wed, Jan 15, 2025 at 10:46:42AM +0100, Christoph Hellwig wrote: > > > Signed-off-by: Christoph Hellwig > > > --- > > > fs/dcache.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/fs/dcache.c b/fs/dcache.c > > > index b4d5e9e1e43d..1a01d7a6a7a9 100644 > > > --- a/fs/dcache.c > > > +++ b/fs/dcache.c > > > @@ -1681,9 +1681,8 @@ static struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name) > > > /* Make sure we always see the terminating NUL character */ > > > smp_store_release(&dentry->d_name.name, dname); /* ^^^ */ > > > > > > - dentry->d_lockref.count = 1; > > > dentry->d_flags = 0; > > > - spin_lock_init(&dentry->d_lock); > > > > Looks wrong - dentry->d_lock is not part of dentry->d_lockref... > > include/linux/dcache.h:80:#define d_lock d_lockref.lock Ah, I missed that subtlety (obviously). Carry on! -Dave. -- Dave Chinner david@fromorbit.com