mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "Alexander Hölzl" <alexander.hoelzl@gmx.net>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	robin@protonic.nl, socketcan@hartkopp.net, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	corbet@lwn.net, kernel@pengutronix.de, linux-can@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] j1939: fix unable to send messages with data length zero
Date: Thu, 16 Jan 2025 09:37:52 +0100	[thread overview]
Message-ID: <Z4jFYFLbIyUzA62W@pengutronix.de> (raw)
In-Reply-To: <8412e625-6033-4ea2-84f1-209c82ae5866@gmx.net>

Hi Alexander,

On Tue, Jan 07, 2025 at 06:17:13PM +0100, Alexander Hölzl wrote:
> On 1/7/25 14:48, Marc Kleine-Budde wrote:
> > On 07.01.2025 14:32:17, Alexander Hölzl wrote:
> > > The J1939 standard requires the transmission of messages of length 0.
> > > For example the proprietary messages are specified with a data length
> > > of 0 to 1785. The transmission of such messages was not possible.
> > > Sending such a message resulted in no error being returned but no
> > > corresponding can frame being generated.
> > 
> > What does your patch do? Please describe it here.
> > 
> > Marc
> The patch enables the transmission of zero length J1939 messages.
> In order to facilitate this two changes were necessary.
> 
> First when the transmission of a new message is requested from userspace
> the message is segmented in j1939_sk_send_loop. The segmentation did
> account for zero length messages and terminated immediately without
> queuing the corresponding skb.
> 
> Second when selecting the next skb in j1939_session_skb_get_by_offset to
> transmit for a session, it was not checked that there now might be a
> zero length skb in the queue.
> 
> Also as this is my first real patch I'm submitting please don't hesitate
> to tell me if I'm doing something wrong.

Please resend this patch with updated, more detailed, commit message.

> > > Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net>

Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

Thank you!
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2025-01-16  8:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07 13:32 Alexander Hölzl
2025-01-07 13:48 ` Marc Kleine-Budde
2025-01-07 17:17   ` Alexander Hölzl
2025-01-16  8:37     ` Oleksij Rempel [this message]
2025-02-05 17:46 Alexander Hölzl
2025-02-06  7:57 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4jFYFLbIyUzA62W@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=alexander.hoelzl@gmx.net \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=robin@protonic.nl \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®