From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBF742AE96 for ; Thu, 16 Jan 2025 17:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737047129; cv=none; b=YiUrhUM8xaGXhs7qByPTDs11R9G9k2gld8DUjbF/ulXByIWiw5OBch8Bejd/xBriCRPPUeOAJGcEcyNWfL1hZGmpDOTlyecl9Rg3oFr5q8B2MwPlnORUmD4Bahj9QScyj8izxiynEJOIX32G5JT5/WUQdzv7EhL4cbgXLNexV+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737047129; c=relaxed/simple; bh=fM5I9GHoHMCA0Lg4ON7OCXeTs1Wova5Z+8bR/0rTTQ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HFIDl9PPBN83454svrvgm9dfmEfhW69g5lpRHwcWhzQUPtfZVrdM07qwmVqLWF/jB0wuWnjWgGVi7jm7MRcKTUlS4D26S2U+Jmz7ju90SzNHudOlNrS/TtkGc+KPv4hZcJfWXorqtGSNgAXFucKpOQDpGeIAJ7YksKora2+IOEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CdeE0d38; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CdeE0d38" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-aaeecbb7309so225714466b.0 for ; Thu, 16 Jan 2025 09:05:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737047126; x=1737651926; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WtqkGBz5EldVcum4M1/PkK69H6/PIvSUrlZUqRXKsUI=; b=CdeE0d386JNYN7wRlqYQ80JsxGvM1ocPdcd8PfXO20g2sjMWek1QtNACM9yDZ3mDKM N0X44TRO8a2mIZAsbiyRyJm8HcIb3aW1WbqdWy9GUwUBeHb2du6tvlUek4QsmFUIeaqW caWVpzQtbkSpU4K3nuDp7W5H5CgfzZoeUBxyK7iXielJm+vHXpaP+gcoKepX9ziNU5cL MmIOjOyI6z+Tlk0vHQTWyO6mdJhcygU9FxmsI+EYZUl9eaL0/jr+Lq0eYblN46flsNpx F2zfCzO9iLPVawSOE+2OSKHIzK+zGXtSWuf/MuxLzfRgRNMKC+hBt+CwtQwAzS4DlZcB UIZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737047126; x=1737651926; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WtqkGBz5EldVcum4M1/PkK69H6/PIvSUrlZUqRXKsUI=; b=jrqjLcMBwm1yzNCdVWdJ4Y9goyrpIIO0K5SnfeULIheq5H2XDYWNvn11Ytrlwx8cF0 tZW/2rnloG2e6kLOOZMB7QE4siaSmAX2wizSu3eyOoTF+rcd0LuswJXlCh/+68/kjqJK aXhbec/sJFAMZWC7FSg+NPfM5umHURn8j2y/a55a+C3i1rszGgK8biHsSzLj6ASwG0Y0 UnhYmCa0JjHY5dFqLjt3EQnN7EkWPl5/6dGRTE3O1G+2JA+Z6pLd6ogZBSkVF4UmenZt c/KzC5yzu5zZfn/AC4pcq+/rQ9aIzkpg42yQlPC/6mpoh9nu+XNE0lPZnKZ1erzop2we JM2g== X-Forwarded-Encrypted: i=1; AJvYcCWaYLpk9cR+Jg423g7Blu0B8J7rR+yGpJA9Mz+4qXP68mZRG7BvJoQyTTmX6dSs4lyb+brW/TENBnM2YRg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw13ego2V6YYtaWCOqvaTh/g11L7Izezs+RwEDiTQjpKwVZdju4 XgmG4zj1jEmv19c2fFDmHkvzZ8yEi0PSrmtZ8+Mca3baavRUSF1jA+hXY+S2mcc= X-Gm-Gg: ASbGncuWXX8TNSUwROlYqorV3FmvQivW+KeumRMGBen4ygEn1XAQpfhVugb3Uoubx3b Fh9N1w+SG6tFcat9besuV5D1/AVBbFRsTB+xAtmPc3ohQVWVMjr2CPX1h56yL4JiRqhRIY1cx7C 10qitaUWmpQ2KU18LyuaFnxPhQIwn942X5+IjFx+P2a6AP4Nd7eHzRI8dEV8B2eQ+ibGZHlFwGm cuXAJNOJdCUcAaOMRQn68GhroMcj8tIWaQIsDVm1MoNrQXXK+SvEno3FO2NaXIdB20a X-Google-Smtp-Source: AGHT+IGQwH9VK+ITSXPqiXT+6WmJreamVlwpYOx5oDkYfmjm8Bdo+i6oCALmzIKHRXzb/M/vletJrg== X-Received: by 2002:a17:907:3d89:b0:aac:1ff1:d33d with SMTP id a640c23a62f3a-ab2ab740dd9mr3087672666b.30.1737047125884; Thu, 16 Jan 2025 09:05:25 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef30:d082:eaaf:227f:16cd]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5db73670ddesm195646a12.21.2025.01.16.09.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 09:05:25 -0800 (PST) Date: Thu, 16 Jan 2025 18:05:19 +0100 From: Stephan Gerhold To: Melody Olvera Cc: Krzysztof Kozlowski , Georgi Djakov , Rob Herring , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Satya Durga Srinivasu Prabhala , Trilok Soni , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shivnandan Kumar Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Add BWMONs Message-ID: References: <20250113-sm8750_bwmon_master-v1-0-f082da3a3308@quicinc.com> <20250113-sm8750_bwmon_master-v1-2-f082da3a3308@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250113-sm8750_bwmon_master-v1-2-f082da3a3308@quicinc.com> On Mon, Jan 13, 2025 at 01:08:18PM -0800, Melody Olvera wrote: > From: Shivnandan Kumar > > Add the CPU BWMONs for SM8750 SoCs. > > Signed-off-by: Shivnandan Kumar > Signed-off-by: Melody Olvera > --- > arch/arm64/boot/dts/qcom/sm8750.dtsi | 74 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi > index 3bbd7d18598ee0a3a0d5130c03a3166e1fc14d82..09fe3149da1926b74a98280fe209ae7f423db864 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi > @@ -2802,6 +2802,80 @@ rpmhpd_opp_super_turbo_no_cpr: opp-480 { > }; > }; > > + /* cluster0 */ > + pmu@240b3400 { > + compatible = "qcom,sm8750-cpu-bwmon", "qcom,sdm845-bwmon"; > + reg = <0x0 0x240b3400 0x0 0x600>; > + > + interrupts = ; > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; The start of the interconnect path is QCOM_ICC_TAG_ACTIVE_ONLY, but the destination is QCOM_ICC_TAG_ALWAYS? This is strange. Interconnect used by the CPU should be QCOM_ICC_TAG_ACTIVE_ONLY. Stephan