From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB13C22ACDC for ; Thu, 16 Jan 2025 15:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042844; cv=none; b=UWXzccAG3dPyuQSwV0/7qUEEUK+zqgB1v2tUSRSRFZIcIYFExp4jNajROLlQkT9AebzYsfgMiOCGwGI+AbTOMreW0S3L4DDC1Y43IEXqfKqJxthYjaBY9nqyagx/eauDkmxlG+LSBeRlohZzPdINbgStOh1xeXGdgoRzPbkoRDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042844; c=relaxed/simple; bh=IY6dYo6qITGixI3mFunSaLf1bnjU9looi2fGwuH5LVc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u50u8IkJGLEZblLUBb4SAx2uRKEFlQG+W5OX+tPKKnK+K+udJc0pUtZfBcpPIhnDzNkFIipVaGWlYKLQpe1VyPuAwxph4LI11h3NWmBjRfGx79p4u8Y2aymYBIvpGOjL7eSpGZnWH2GthiP1KE80Uv4cUNFYW1zuYoLWMEfinqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=loDdZBnx; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="loDdZBnx" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3862ca8e0bbso874781f8f.0 for ; Thu, 16 Jan 2025 07:54:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737042841; x=1737647641; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=y6d0AIUCANmrxg6EkzbtG7EaPw/qbwR7hp+uthpgvFE=; b=loDdZBnx2+fiSZkv+Vosvyx3NTjBppM4trYsKsFTbfdWkk5NiVwI4/i7w5OknCspgq 41s/TEoKsnHmhvztezy+rnSRfbg9B5HXyg8rzJ738iW2mHUdjkHSj1oqfh9/Tc5R+wh0 tRP9OVt56Gk6+ABLIdYnzUF8c7omRwDmbFMeusyixcrwevM9YF6+E/WE99cHNBtCCwoP Cb7A36ShLtyQGeIPKk8tZUoH5/McLRZjkw9+pE72P7MGw0k1vFobC9lCzyoEAB4bg/an dqHkVMNpGbSN2hwaU+9AOudyBH3cz+S8N6Z3pHNwhxBXXtM4lsirfmqrjPfFGxCvuZ/i Myvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737042841; x=1737647641; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y6d0AIUCANmrxg6EkzbtG7EaPw/qbwR7hp+uthpgvFE=; b=N5/72EWQGEXKWzA7kO1HgbuLXwUt3QBdMz1eMR1iw3ezqXYqN85m+Fwt8lZdSX+KFh ejZS2BwpI3f+rRVRHh9/Enp4Ih7ABsGItdOz0RsPy2XKB1fswFdpXHynhhK9Kwaf+/j2 9X35wmTTdgKYLce6ebX4VF+KYjmPYIoVUWBn/o21QQ/wMjx96u0pKNkE9kr8X3PGQ8eK UeIbBAfIk7OHOTq1pSK1Fvmx+jY1AYXVizZTM/amUUNhvTpsn6mA+uVTL9tb3GUHK3iY TWCDXi8L86sy/4xsxwqBU6XcLEd6qwDV7wVkNoJiUp/2KMxK5DA2VzBRL4xhGU16K6Cr Fp7A== X-Forwarded-Encrypted: i=1; AJvYcCUapFxBK01dzXgFpijRVUhKSbWbPteV+4LNhEhmfBLxRI6C/e7B68ZUKUj7o5zK16TQpjfblEjQx9LFezU=@vger.kernel.org X-Gm-Message-State: AOJu0YwqlwDo3b3brZvYRuH5vDPoqQUgZEva2m4JjFfyBBPOvxX1byGR 9goPdt7DYA9BEOG0RhQHMcYT1pe2n8D1ZsSsjzijR6v4PocEr0rQ X-Gm-Gg: ASbGncv79WQGFzrLaue6iK25I8p14+UhU7GeoVYMVJeeiLBveCrK/RoLNQj6b/YNXrC EEiZFO5s5NHuEctVuy5C6hGV+3GzDt+GecnlcKOV6UvgQRsspiBe3aAWm9MXw0cfrLsYe1BMQ0G mf4YvIYat3aQGLntbfthMG14NwNL/eZ5u+Q3ofA/nKhIEKMQCZQ7FbAaPPw2hSSV3U8BbcZvhNS wFFqzbsa0zCGQPVPisVG5AJ0Ag1TJAqPYCQpndEGkixMYDjl5GCJZM= X-Google-Smtp-Source: AGHT+IGriCgwafyapYW3f3+L6LKps1+fxUAv0OQOzclfLTVqCL+rQ8MW9tc6ovrRSNXOXuy1lO/Niw== X-Received: by 2002:a05:6000:18a4:b0:38a:9fdb:7307 with SMTP id ffacd0b85a97d-38a9fdb750amr21326769f8f.43.1737042840763; Thu, 16 Jan 2025 07:54:00 -0800 (PST) Received: from fedora ([94.73.34.116]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf32755f0sm186116f8f.76.2025.01.16.07.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 07:54:00 -0800 (PST) Date: Thu, 16 Jan 2025 16:53:57 +0100 From: =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= To: Louis Chauvet Cc: dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, nicolejadeyee@google.com, Rodrigo Siqueira , Melissa Wen , =?iso-8859-1?Q?Ma=EDra?= Canal , Haneen Mohammed , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Simona Vetter Subject: Re: [PATCH v7 7/7] drm/vkms: Switch to managed for writeback connector Message-ID: References: <20250113-google-vkms-managed-v7-0-4f81d1893e0b@bootlin.com> <20250113-google-vkms-managed-v7-7-4f81d1893e0b@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 13, 2025 at 06:12:03PM +0100, Louis Chauvet wrote: > On 13/01/25 - 18:09, Louis Chauvet wrote: > > The current VKMS driver uses non-managed function to create > > writeback connectors. It is not an issue yet, but in order > > to support multiple devices easily, convert this code to > > use drm and device managed helpers. > > > > Reviewed-by: José Expósito > > Hi, > > Sorry José, I forgot to remove your Reviewed-by, the changes made here are > not trivials. Can I keep it or do you have any comments ? Hi Louis, No problem, feel free to keep it. I had a look to v8 and its looking great, sending a few review-by to that version. I'll try to rebase my branch and run all the automated tests I have been writen just in case they catch a bug. Best wishes, Jose > Sorry, > Louis Chauvet > > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/vkms/vkms_drv.h | 3 ++- > > drivers/gpu/drm/vkms/vkms_output.c | 2 +- > > drivers/gpu/drm/vkms/vkms_writeback.c | 21 +++++++++++++-------- > > 3 files changed, 16 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > > index 00541eff3d1b0aa4b374fb94c8fe34932df31509..46ac36aebb27ce8d9018224735007c1b3fe7d0a5 100644 > > --- a/drivers/gpu/drm/vkms/vkms_drv.h > > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > > @@ -179,6 +179,7 @@ struct vkms_output { > > struct drm_encoder encoder; > > struct drm_connector connector; > > struct drm_writeback_connector wb_connector; > > + struct drm_encoder wb_encoder; > > struct hrtimer vblank_hrtimer; > > ktime_t period_ns; > > struct workqueue_struct *composer_workq; > > @@ -275,6 +276,6 @@ void vkms_set_composer(struct vkms_output *out, bool enabled); > > void vkms_writeback_row(struct vkms_writeback_job *wb, const struct line_buffer *src_buffer, int y); > > > > /* Writeback */ > > -int vkms_enable_writeback_connector(struct vkms_device *vkmsdev); > > +int vkms_enable_writeback_connector(struct vkms_device *vkmsdev, struct drm_crtc *crtc); > > > > #endif /* _VKMS_DRV_H_ */ > > diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c > > index ab9affa75b66ce9f00fe025052439405206144ec..de817e2794860f9071a71b3631460691e0d73a85 100644 > > --- a/drivers/gpu/drm/vkms/vkms_output.c > > +++ b/drivers/gpu/drm/vkms/vkms_output.c > > @@ -95,7 +95,7 @@ int vkms_output_init(struct vkms_device *vkmsdev) > > } > > > > if (vkmsdev->config->writeback) { > > - writeback = vkms_enable_writeback_connector(vkmsdev); > > + writeback = vkms_enable_writeback_connector(vkmsdev, crtc); > > if (writeback) > > DRM_ERROR("Failed to init writeback connector\n"); > > } > > diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms/vkms_writeback.c > > index 79918b44fedd7ae2451d1d530fc6d5aabf2d99a3..981975c2b0a0c75e4a3aceca2a965f5876ae0a8f 100644 > > --- a/drivers/gpu/drm/vkms/vkms_writeback.c > > +++ b/drivers/gpu/drm/vkms/vkms_writeback.c > > @@ -24,7 +24,6 @@ static const u32 vkms_wb_formats[] = { > > > > static const struct drm_connector_funcs vkms_wb_connector_funcs = { > > .fill_modes = drm_helper_probe_single_connector_modes, > > - .destroy = drm_connector_cleanup, > > .reset = drm_atomic_helper_connector_reset, > > .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, > > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > > @@ -163,16 +162,22 @@ static const struct drm_connector_helper_funcs vkms_wb_conn_helper_funcs = { > > .atomic_check = vkms_wb_atomic_check, > > }; > > > > -int vkms_enable_writeback_connector(struct vkms_device *vkmsdev) > > +int vkms_enable_writeback_connector(struct vkms_device *vkmsdev, struct drm_crtc *crtc) > > { > > struct drm_writeback_connector *wb = &vkmsdev->output.wb_connector; > > + int ret; > > + > > + ret = drmm_encoder_init(&vkmsdev->drm, &vkmsdev->output.wb_encoder, > > + NULL, DRM_MODE_ENCODER_VIRTUAL, NULL); > > + if (ret) > > + return ret; > > + vkmsdev->output.wb_encoder.possible_crtcs |= drm_crtc_mask(crtc); > > > > drm_connector_helper_add(&wb->base, &vkms_wb_conn_helper_funcs); > > > > - return drm_writeback_connector_init(&vkmsdev->drm, wb, > > - &vkms_wb_connector_funcs, > > - NULL, > > - vkms_wb_formats, > > - ARRAY_SIZE(vkms_wb_formats), > > - 1); > > + return drmm_writeback_connector_init(&vkmsdev->drm, wb, > > + &vkms_wb_connector_funcs, > > + &vkmsdev->output.wb_encoder, > > + vkms_wb_formats, > > + ARRAY_SIZE(vkms_wb_formats)); > > } > > > > -- > > 2.47.1 > >