From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26C4B22D4C3 for ; Thu, 16 Jan 2025 16:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737044696; cv=none; b=PpSno+n/lVSeNJsLWyKGtWv/n7KSCN2J+MxK5tvC93ACrdL7SFVDgS3B8HeUH9lxQwcIt5tHc6hX9boCVvTB+c99WqTWH3UfvUAaEBtJ80H/REVum8vQIqagw1w1ZwrzVpUssCYrjkeu9k8e1Le7pV2qZ6JcWZGwfNUWaHFOjA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737044696; c=relaxed/simple; bh=KV3gvFU1WBDYxiduTNQzimRBpDtFIHfz46S2jt1759w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g476GTp4NfzcgWaOyfF9A7J9b6tQuBtWuPqDNw00yu8FN0jRboN9R9Pbxc3KY4q6gVov0LAxc1rrw2rc7EwnFRVkbEQ3xEUJstpbLYBNxV0sBzNMayL/AoAzE6wgiR7+B7Fo+3AqqeDH/ZY33qSgc99woaKe9t79fRZNcf83JzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jsj951Hr; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jsj951Hr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737044695; x=1768580695; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KV3gvFU1WBDYxiduTNQzimRBpDtFIHfz46S2jt1759w=; b=jsj951Hr4OPkovCVn6vxwjCd2V3BEcVMVIpGs8eTvCKXN3Vc9seCxNFw b+yiu14RhQd6rW1bW6MrVobkNNfT2e0EOjiCR+xSBiYtsN7tYhzjS/p6v ejMBftk23NGziNYXrZhUbJ7GMtcFEojw83+yEhDIRW3K1TUXd/w5+YG8g VLZf37ERTm4YtPdddTFUmtHm7thMaKmlQm0OWWiGofmNtLe1dLq6PPN37 LP2vy8W3niKwlyOQgUdXQ4rjAWgkYWLw/v9tOg3RDZVSeSyzY4Q88wiFU bVLVY/VeXgz4vay6BW3yFy0ED631fPLtn2mEEaLEIJcUNO+R/WBm0FdIK w==; X-CSE-ConnectionGUID: 4Wk1+ddjSoG5YFiRNOuf3w== X-CSE-MsgGUID: w2ibB75nSESzt/nQEAofBg== X-IronPort-AV: E=McAfee;i="6700,10204,11317"; a="47934123" X-IronPort-AV: E=Sophos;i="6.13,209,1732608000"; d="scan'208";a="47934123" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 08:24:55 -0800 X-CSE-ConnectionGUID: 6kg+Hch4SOGehEAEaWRDoQ== X-CSE-MsgGUID: jmDBgnkXQU6R4kS0WuxKYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="109598522" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.154]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 08:24:53 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tYSfq-00000001jbL-3D7p; Thu, 16 Jan 2025 18:24:50 +0200 Date: Thu, 16 Jan 2025 18:24:50 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Subject: Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs Message-ID: References: <20250116124339.3941636-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Jan 16, 2025 at 04:15:05PM +0000, Mark Brown wrote: > On Thu, Jan 16, 2025 at 02:43:30PM +0200, Andy Shevchenko wrote: > > Besides the fact that currently defined devm_*_free() APIs > > are being unused, it's usually a sign of bad design to call > > such explicitly. Drop them and make people pay more attention > > on the misuse of devm_regmap_*() APIs, > > This just seems unhelpful, there's fairly obvious uses for something > like this where we decide we can't actually use some things based on > what we discover during probe. It's an effectively dead code. I rarely see people are using devm_*_free(), and when it's so, it is most likely by misunderstanding of the concept. For what you described I don't remember any _practical_ use case. Theoretically any dead code is useful, but it's not the point, right? -- With Best Regards, Andy Shevchenko