From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tamir Duberstein <tamird@gmail.com>
Cc: David Gow <davidgow@google.com>, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] scanf: convert self-test to KUnit
Date: Fri, 31 Jan 2025 19:11:15 +0200 [thread overview]
Message-ID: <Z50EM7gxqyV0Eois@smile.fi.intel.com> (raw)
In-Reply-To: <20250131-scanf-kunit-convert-v1-1-0976524f0eba@gmail.com>
On Fri, Jan 31, 2025 at 10:47:49AM -0500, Tamir Duberstein wrote:
> Convert the scanf() self-test to a KUnit test.
>
> In the interest of keeping the patch reasonably-sized this doesn't
> rename the file in accordance with usual kunit conventions nor does it
> refactor the tests into proper parameterized tests - it's all one big
> test case.
Rename of the file may be done, but you need to use -M -C when formatting
patch, in such a case the diff will be moderate in side and easy to review.
P.S. The test modules in defconfig is something which puzzling me. I would
remove all of them at once, if somebody wants debug configuration, they would
specify it and use with help of merge_config or alike.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-31 17:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 15:47 Tamir Duberstein
2025-01-31 17:11 ` Andy Shevchenko [this message]
2025-01-31 17:22 ` Tamir Duberstein
2025-01-31 17:25 ` Tamir Duberstein
2025-01-31 17:51 ` Andy Shevchenko
2025-01-31 17:50 ` Andy Shevchenko
2025-01-31 17:58 ` Tamir Duberstein
2025-01-31 19:58 ` Tamir Duberstein
2025-02-03 8:13 ` Geert Uytterhoeven
2025-02-03 8:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z50EM7gxqyV0Eois@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=shuah@kernel.org \
--cc=tamird@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®