mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Michael Jeanson <mjeanson@efficios.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [GIT PULL v2] Scheduler enhancements for v6.14
Date: Tue, 21 Jan 2025 21:57:12 +0100	[thread overview]
Message-ID: <Z5AKKBpk8EUF6MSe@gmail.com> (raw)
In-Reply-To: <f2ea764b-f333-4d01-b73e-c6ec0db0fdfa@efficios.com>


* Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> > > Since I booted the scheduler tree on generic desktops and it was 
> > > tested on other systems as well and nothing appeared to be 
> > > broken, I presume RSEQ_FLAG_UNREGISTER is used only in libc 
> > > syscall-testcases and in specific applications?
> > 
> > Nowadays, rseq unregistration is used by specialized applications 
> > (e.g. tcmalloc) which disable glibc rseq support with the glibc 
> > tunable and register it themselves. 
> > (GLIBC_TUNABLES=glibc.pthread.rseq=0)
> > 
> > A recent glibc (2.35+) don't use explicit rseq unregistration, it's 
> > unregistered implicitly when the thread exits.
> > 
> > I'll make a note to add a test case for 
> > GLIBC_TUNABLES=glibc.pthread.rseq=0 in the rseq selftests and 
> > librseq to improve test coverage when using a recent glibc.
> > 
> > We have all the code in there to use rseq unregistration, but it is 
> > skipped when glibc 2.35+ is handling the registration.
> 
> It turns out that it is covered by both librseq and glibc tests, just 
> not by the kernel rseq selftests:
> 
> librseq test: tests/syscall_errors_test.c
> glibc test: sysdeps/unix/sysv/linux/tst-rseq-disable.c
> 
> We should import the librseq test into the kernel rseq selftests as
> well. CCing Michael Jeanson who will take care of this.

Thank you! Linus just pulled the v2 pull request, so all should be good 
upstream.

	Ingo

  reply	other threads:[~2025-01-21 20:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 11:07 [GIT PULL] " Ingo Molnar
2025-01-20 17:26 ` Mathieu Desnoyers
2025-01-21  7:23   ` [GIT PULL v2] " Ingo Molnar
2025-01-21 11:49     ` Mathieu Desnoyers
2025-01-21 15:37       ` Mathieu Desnoyers
2025-01-21 20:57         ` Ingo Molnar [this message]
2025-01-21 19:40     ` pr-tracker-bot
2025-01-21 19:40 ` [GIT PULL] " pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5AKKBpk8EUF6MSe@gmail.com \
    --to=mingo@kernel.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mgorman@suse.de \
    --cc=mjeanson@efficios.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome