From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonic311-14.consmr.mail.bf2.yahoo.com (sonic311-14.consmr.mail.bf2.yahoo.com [74.6.131.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBC65156C74 for ; Sun, 26 Jan 2025 19:48:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.6.131.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737920892; cv=none; b=GuaAaP3Xc/aG5oW8eiKM45vSq2qRyIkuyrqR0kvkWbN2jfTkcqgtF5WqSjN8Dbwi7RSFMMBypkAGYqdJ9W1OvUEU8xn9HLE4/x9XJX6+hm75r94SBZhSE6X3IIL+/+14Mhb5mzrFdLh6aahehP9Jt+WagF9XlPL6MZ7qfMjdFnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737920892; c=relaxed/simple; bh=uVcpo1bk2yEzaWZpSDhxgFEK5nb/IUwNcZSGVlz8Zrs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=osB3PLrlepneE+RNo6RmzZpgpDectoKOnha5UeV7AVnrexZsyRYuK75bBtPEGXFSN7N9ILhHQ0LpepLpLkwOzTcm+Qjep+KT+Gq655Y0fSuNMdLUThxVZj3/Bsc/H66s2Z6Op8MGfRgOh5GHdoSO0jnPfschLwUa5LZv1h4IMoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=EpBSXfpk; arc=none smtp.client-ip=74.6.131.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="EpBSXfpk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1737920883; bh=esnEHYbr+tA6Hk36266Ao3jle9+dwUmdzcUBmbXjGoA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=EpBSXfpkOb3JkECgMm31noicxGtOnv9h5ZL8BtyLxcE/cE1OhA231/2iGPjuvZqpjZDgB60IYPUXCc36+ZPsx0BXRE2XbOXl8yXYD4AvfTBc2zv3pq+p5PpvUo7knG7w0ZDnkqGoeOMno7VB2ypNYz/bd7pWRW2f1432kZp8ltLrfBgKKtz12nddgd8fn+HYViuB/BuAnrbBCh9FHhEGo+r9IEy3loGpanK5S8EuC9a4Sce9Fh7Ap4bvyVZHZb7fJazWlInss9vqQImkas6B4t+I/7FoUS7fqcaBECpOX5TFBvykkv8ebHxg/HcPRCyUtl+py+fZM0TZbvwb3sKvMQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1737920883; bh=gpe/R1w2Fr2Mhu4JAODz4z8jGkxiTvEMOlW33CJyL+w=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=WtsHthsLxklcynd/7F3zrsMNvRjPRGR+KaPVWS1IAEKTKzeobrg05NljcW86gBwmTvd7/sV3hw8MJFRADuOr8lQq+7G/WD7EdANb4f4ZbRT9jdL5Pk0Z/lmp2Hb3pFOkIyUC6T0PqAKrwce5zgEY1MEy/XyIel2dXS74b9bWvzfKNvr2K2L46lzvsH3+a3P4Zh3p1wCtvE1IQayUJeNjq72YomrvkwCBMJaGHXKhdywzIYmQClKdLllX4Ld6a+owtx7HR/Gf/BQVrI/op22N6j4aQ5ZJTjWsiaQINgpY6/tmlGetABjKUGT7F9TK2wXVxKPd/BHbps1rgIxmPEHbnQ== X-YMail-OSG: 60mDLPUVM1kyH6hLI7tOY5VXYJe300OZNwB6p0pH22pbFWcx6qxp3.QeuI4yC8e vI.J9bsr7E0W6EKOSUuXqCQFZtdjQ_Ez.rsj4f15emMIWStJdBrZ32puTXXd82GaPRqy9vsHFKi9 vsS2g2BlWQiapBjC7U25zE6gFgi2NdJFOuXNUuBEDRuhTAX1Vphl2XGphIEVaoOfAFIAj2JG7Org sPE_qVDfl9bYQabUu6BcgNw9_vw_q.O6DI3B..IrEOKtUNps.M9QwDYUrKbqwIFVUOs4jGNgJYL6 321izCbtBsMyWUn8yqGC.6HElZ1BUjI.B93k8a0B_OceCZrnf19oRYwxA5jC5y1m42JgbFMywXfK z.zMLbIhzpv3EkA0VntmKgKkZ_KEHFQ4aGWlolW4CFnACFZfx1uPbXuuCagRXBuDjdKaHgIwHMnT Lxcyo_bK8DKPH78XokorDAHvlOC1zVwq1TSGBWNIxcD1rqEd6_N209Df8m_gv_1_BVqJ2h6dJvvq .CcYnwqB4azyxn22Oo6YoHjS2DHOlVKtNzh.Hgn4p7AvN5kXMBWYj6qyyLyWsEv9uAxQbh.8t9f7 L4SyYrP55sCCSMOADhtQGQ062rtVwitZn0jAuFYL46ayd48DY3AjoHj65gRhcZFeJF.7ag9d4.Tv aARcwQ6lUOEBYpac2ZNU4C2Nr22V4Tu5x3ibI_CYjEihJqCAhLNLyTE8XCCUtg8juLrOlF8wnHLH x4o_vEqoNLdSsmu50QTmf8TuGX1ZAEPija67D2utJ4fbaNdHuaj0LfODdbNdDaqU.Ep6HvAen8C. Eiu0pisMUNsGbl4PdJv7cCf10tRbzrFuKkAEDS85_QqHeZbU196x0mG8Zj9NMzIMcdpyRYJlvxuL iJH48SI8rJ9vZWo70XnlJzLx_bo1BTNdR63fXgPxTc.qEK_RrNUSjeEvxdj8frAChiMoPKHI1PTV MmoUX4Y83C1Fgfyzmhq6AxYjpjcd50X2Uxd7kDka4JM4z16XySllmhq22E.nKxQDvkvq8W_C9kPD svAQbG5.l8_UmT7uKFALQNR0P_gF9rs4rShNq0E4Bi0wxIKBYE6PrdRc9a9zQurX4ISNMgHkFc8I xE0Vx3lEWqOwd7I3yPsCe1je3DCQIshunbzQJFPQh02Vvp5oIrG2fYfop5TMPiSXlwnt1L7v_Vpb c_0KHB43kQJI5t46vY35KoLrWvHQmifrPlFIXtXWk8M5YISm7W6S7ax6pJB8QFy4mjmjmo6l9tmu kQIpyElwG7fj4kekMfFsbPJishLck9maDMvv27HLvtG9oMyqGbJ9PfLGQ7uQWJqixdMu.aiyp_6W YiB31ygkEv.oyX1ZAFF.CbaZFJaTjWDpIqTEr47XRceWA1QF1RLLl5i5WS1ty8HtBUiNTpKUIpMv KDg7jXpSsoOiHqnXasqOz4hzqVZEve_twVtnnmCsn2.7UtBoDAX8p6.NKJcY9weUHAgs7XfMl.I_ xWwg5xTLHDmUlZMVEuGy_.X9ArJr8d.1XsA123QSOi3qHgAzwEagCMDKJK.naV9ELJ9H0CM76_8x nlgRsFTJvrm152q0FVs7omnhxEz4o5w_99qImg4I7HtS_b8hJcXWArmc50pS0dJp6aLe8u2WKM15 dP3CbdvegAG9q8C1Y9o9Fv_mciRquwnm9KocrAphxkZuOLeo0V.yqU1nfJOjpFbsKUrf1g3QM5WK Ogl.xh8Z5RpqbVXEJ.LwkmtogayWKQgGBkrbT4CWXuB1UNRZzmKobz.CGVFgBWXIYfbOb_ENmUq2 pi.rAVExX2odEE6r.SsbDeufxHVJANlWL2Od03VdJymMtdVf6MyUqzvh.urOa24uTzoy05pJ5F5D PDbOQVRQVE2baU0mM._gm6hr5RHshTS_X3OGQ7bprt.C8Hs9PQFr67rh4nLYfp2MmbGxrFkhhbQZ La6f0rucxEnLTDHFu4wcdZDWkGboUCpONi4lUCpdaGfoWScobiGzjQqy8W8rlZSMmLkUDT5zsLXS x2nBJ7xURud3nl2VCz7frHCM8KgT_a0PNFT.h3MeZ7kgKpGh13hQ3hsZVk6Ds8rbuO9J.mlDkHos XSJxjK92HAAR2LYAjG9tmqGTB9ZxIbh_tWz15an7IaOXsKpcZbSgI1zo3ziE08zHKeC_0G8VmdAn I3_SvQ8FEZXa9Jh1dlllYYFquWGpzXFugic7Jf4G7v1On3VZgOZfLrHazgXzpF1a3M59vUqkCgxV wdFOXWw2IryWG_tPooT5_IfSPzpHuQggWyhir3Fmd4DB1XPkehahFm3h9 X-Sonic-MF: X-Sonic-ID: fe6c9231-8238-4bb7-81e4-337ae316a0ef Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Sun, 26 Jan 2025 19:48:03 +0000 Received: by hermes--production-ir2-c694d79d9-5hgbf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 121b8431dc09d07e9bd18937baffc388; Sun, 26 Jan 2025 19:27:44 +0000 (UTC) Date: Sun, 26 Jan 2025 20:27:41 +0100 From: Jeremy Dean To: Paul Menzel Cc: marcel@holtmann.org, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement Message-ID: References: <20250125165804.11486-1-deaner92.ref@yahoo.com> <20250125165804.11486-1-deaner92@yahoo.com> <62d9db39-5d2b-4980-99e5-f15c4555b57f@molgen.mpg.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <62d9db39-5d2b-4980-99e5-f15c4555b57f@molgen.mpg.de> X-Mailer: WebService/1.1.23187 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Dear Paul, I have changed the subject. Fixes: Coding style, unnecessary braces On Sun, Jan 26, 2025 at 09:02:04AM +0100, Paul Menzel wrote: > Dear Jeremy, > > > Thank you for your patch. Could you please make the summary/title a > statement, and remove the dot/period at the end: > > Bluetooth: Remove unnecessary braces around single line statement > > Am 25.01.25 um 17:58 schrieb deaner92@yahoo.com: > > From: Jeremy Clifton > > > > Warning found with checkpatch.pl script. Removed unnecessary braces. > > I’d use imperative mood for the second sentence: > > Remove unnecessary braces. > > Also please add a Fixes: tag. > > > Signed-off-by: Jeremy Clifton > > --- > > drivers/bluetooth/bfusb.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c > > index cab93935cc7f..0d6ad50da046 100644 > > --- a/drivers/bluetooth/bfusb.c > > +++ b/drivers/bluetooth/bfusb.c > > @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) > > buf += 3; > > } > > - if (count < len) { > > + if (count < len) > > bt_dev_err(data->hdev, "block extends over URB buffer ranges"); > > - } > > if ((hdr & 0xe1) == 0xc1) > > bfusb_recv_block(data, hdr, buf, len); > > Reviewed-by: Paul Menzel > > > Kind regards, > > Paul