From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 901B1158D8B for ; Tue, 28 Jan 2025 09:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738056293; cv=none; b=Yip40xWVqTTvgDInxDcK/ko2C1AJFaogCedSxkLpKL9jW7bli/WKcsecWv7Rm3C5bmZBWHn3SKkWcyu9yUFqXUVOsmrXeeS/+lNzjwHTaZGWOHGPq+F6+wdVlO7vkGPQOR6CNAVNESgRD1KdykRW0cDU8myp4B20FIT9VV3EXx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738056293; c=relaxed/simple; bh=VIt82eoZNWpVRi39QUt00VTIlJRuh+8c0BStMvWCBTM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RRCFJC8ApKUHagjIGT10+CLRqf2YB1ao9pRKJIuNGIxqq8/d/In14dHmmDCTFZZoJI7TcKXUSjCcBBsE2yXMx0PSTWShEvmIVHruhsw263j4vE6XNIwwgxo+uNTy/09BpTq77cwucz6anNylaLrEPYxFEIq9XT6iRvHmTAtVhKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Qfe50Vzz; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Qfe50Vzz" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aa679ad4265so1266291166b.0 for ; Tue, 28 Jan 2025 01:24:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1738056290; x=1738661090; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3D5pqdu2mdyqLKvp3DYnfF8xqiFnuWUD81acNqTKKzg=; b=Qfe50Vzz0GkRLzDrP6PV7l9hyHp+dG7wDrTdCshnOZLfUEwA06GvMgqlDJdsRYOHFP zy9dwEeA0dWI/3SyAFOw4Mcs27ezvab6ptXS8y4P8NweKx1FRgnqNi3/8n/zfckw3uLS sK0gHl1w5mQ21wlevbY2jIJb4ecGYi7/LC7DFUWxPCjk0ZRJbzT5OUaJtj9CO/cz7lKs 7hE5qL8bzWbScgvtrjwKRlJFlXKxgVXJn1TY53vQsaXEX/VIxLx/pbzTg0uhyQQCrsyn PTpFv4Ibk2Z7ywUn8FDlfV7QX2beSonYds1uPMgIJ9RBDVaqHGcPwvubUPK7MMpV7mfT 4OwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738056290; x=1738661090; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3D5pqdu2mdyqLKvp3DYnfF8xqiFnuWUD81acNqTKKzg=; b=Feovmn6f64AVwzDaDJ67qHTuocZ/k0TqKwlgJaKfCKZSFKQTkKVV31cXpQgdA7VNI0 UXkkMPLurz7zm/4wGyilc41dIglBSeMUJlPYS4XGyhPBpxgI4RHGjc4jey5Ll361Cw7k i7lW+yuXmk/Na6tbPq7BI0CBl6oz+wMNXHAj1RkNi6bUTanBnAe6NvZ3KFvX3AAVyNHm XIPmw/IFBz6mAdmUPNc7G3t5jtsVkli7o9wsrjTpMT6NjGFZRvdLwttun+VjaZClS+bc 7QMfqAWkhiHTWP15JE/rkBGVv6NkCgAltg/JAOEumn1ZTrQeR/Sw6Qk6vUoMRZUkFX1H +cyw== X-Forwarded-Encrypted: i=1; AJvYcCW5qULU8/sssbHzogvHivq2ENHuPKJMjogwCF02Gtz9wYqMvHfd8mg8GIdzDdM9Nz2aMpB+50+0Zw+yDZM=@vger.kernel.org X-Gm-Message-State: AOJu0YyS6NDcM34XwxRo0iC1NUUxDMinarcTZG81iH58hSZ/OAwlM0Z+ sE9pZ19qDAVPCo5pguQS/Bl9pS3ZvvDOd9CfbOK2ub4PTzYjJLkYQ1jIhSPeQnb3Jg1QPtEapPI u X-Gm-Gg: ASbGncsiBxRNzqJQcbrHV5ohAZyKWGPxKMXMEO5mmB6tuGptmoaScx5+PbqUxGn1nVE hbQWVxMcTChjP7c3tTiLw3FLQ3Wuz7r3F69AYdDQ8/b5Z+VsyheGlP/L4VvkL3Pn0vD/d2dy5f2 T479hRPCaGIx2nAY6tVaFGgh0d4TilaQJjdp0D1O+OhVTP9lO2wC98jPBpWntG9dObQ3bZ6ZoqU 8dxtKHuWMHQO9VVyIWhWX2sKhiGYDhC5GAVrwam1JUX+LstQ4/qQwsnoKq4C/z1EJI9Co8O4rHn kMuZsas/0vHLNiz7Fg== X-Google-Smtp-Source: AGHT+IGrISwDFvM1xi0gD4SmyIWEd+WxPcD14LGgqhymD1O7Z9Zxg85xnHJpOfHVb6c9HPHvwaIKqw== X-Received: by 2002:a17:907:d8a:b0:ab3:a515:c41 with SMTP id a640c23a62f3a-ab6bbac99a3mr269350766b.16.1738056289847; Tue, 28 Jan 2025 01:24:49 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab69179d7c7sm511538866b.112.2025.01.28.01.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 01:24:49 -0800 (PST) Date: Tue, 28 Jan 2025 10:24:47 +0100 From: Petr Mladek To: Christophe Leroy Cc: Markus Elfring , Jeremy Dean Clifton , kernel-janitors@vger.kernel.org, LKML , Andrew Morton , Geert Uytterhoeven , Huang Shijie , Ingo Molnar , Luis Chamberlain , Masami Hiramatsu , Paul Menzel , Raul Rangel , Tejun Heo , Thomas Gleixner , Yuntao Wang Subject: Re: init: Unnecessary braces around single line statement Message-ID: References: <20250125154139.7565-1-deaner92@yahoo.com> <5033d386-0765-486d-bf5a-68fe790ee455@csgroup.eu> <2ee90f45-0ef2-4c9b-8b0b-79d8c6cde1de@web.de> <55498563-eb4d-4475-bf85-1543a59aed20@csgroup.eu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55498563-eb4d-4475-bf85-1543a59aed20@csgroup.eu> On Tue 2025-01-28 09:59:08, Christophe Leroy wrote: > > > Le 28/01/2025 à 09:45, Markus Elfring a écrit : > > > So ask yourself whether such a change is really worth it. > > Some change combinations can occasionally become more worthwhile, > > can't they? > > Sure that change would be perfect as part of a series which modifies > bootconfig_params(), but as a standalone change I can't see the benefit. I agree here: 1. Cosmetic changes just complicate merging branches with really useful changes. They are complicate backporting fixes to stable kernels. 2. Cosmetic changes are material for bikeshedding. Some people might prefer the original code because it is better readable for them... 3. The authors of cosmetic changes will not learn much by this. Also it will also not help much to gain any reputation. Best Regards, Petr