From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 707B41AA1D2 for ; Tue, 28 Jan 2025 20:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738096657; cv=none; b=Xb/nvApqQDnUmxkjUCaUXXcCHuOmxvWevsVDjkEQm5vvra7UsqjwiEktDFZ6I87ymQ/WAhr+9fzMY5TPBoDflvOvyLevrIAe5Js0f/cakNH3NuECwC60T5nckDQuSEbt52hoK1QOhggMEySQbqUwpZYJe+JYNFuU2zjmBQlBuvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738096657; c=relaxed/simple; bh=a5Qhrx/SfRxIjR2xAsBVyy1NoGiwiSHVyR+SpkdLufM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t98zegLs2eJIES0pBjzLeoieiqK7ZEUB4LU8CHzeuFM2TVQNoGlBM2UOJ3ZfkHJgZLSsP0I0puwtmwtpZ7XRm6lNPCE1BwugweHTmllgh5HBxHOLa30aivvBGLRJNbnS1mfSkZQYxqSmILlmq2eH/t5NOL68qIKAC0ubb2tYYv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y4v5F38/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y4v5F38/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF94AC4CEE2; Tue, 28 Jan 2025 20:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738096656; bh=a5Qhrx/SfRxIjR2xAsBVyy1NoGiwiSHVyR+SpkdLufM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y4v5F38/AK8t9HR3EsRC7BZQmj/NYfYERsKaZS8F4IAfBIMzUyZJAngPRmMhFJNSR +NXHtMAxFegYYMBPvaPweNxXeUjkEw9N7NDw2o6PAy1x06nIvRB2/nS/JVPBdwST9m y4fthtuEc7B3AtFmWD+PqTsUlMgJx1rU06tmwbG2XqETFQ3StSsTcL+JUcHlUegJEN Xfmqbf7Korbwxalb4c11qI2c/i2QVpMEYJQwfeoBPqoHnPfrlHPb/O8JcH6gw1snzz NIYmQLPgaUZu303rKIl0SqcaGEUTWpPrvPO6rhwMtu8lBqVTx/KUMPYy4g2IQAMvSb R4U8D83Our4gw== Date: Tue, 28 Jan 2025 12:37:35 -0800 From: Luis Chamberlain To: Joel Granados , Petr Pavlu Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] tests/module: nix-ify Message-ID: References: <20250122-jag-nix-ify-v1-1-addb3170f93c@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250122-jag-nix-ify-v1-1-addb3170f93c@kernel.org> On Wed, Jan 22, 2025 at 11:33:49AM +0100, Joel Granados wrote: > Use "#!/usr/bin/env bash" instead of "#!/bin/bash". This is necessary > for nix environments as they only provide /usr/bin/env at the standard > location. > > Signed-off-by: Joel Granados Acked-by: Luis Chamberlain This can go through the modules tree. Luis > --- > I just saw this break my allyes test build. I had usually done it in > debian, but now that its on NixOs; this patch corrects the build error. > --- > lib/tests/module/gen_test_kallsyms.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/tests/module/gen_test_kallsyms.sh b/lib/tests/module/gen_test_kallsyms.sh > index 561dcac0f359..31fe4ed63de8 100755 > --- a/lib/tests/module/gen_test_kallsyms.sh > +++ b/lib/tests/module/gen_test_kallsyms.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/usr/bin/env bash > > TARGET=$(basename $1) > DIR=lib/tests/module > > --- > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 > change-id: 20250122-jag-nix-ify-1aa2061c4ad8 > > Best regards, > -- > Joel Granados > >