From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from e2i673.smtp2go.com (e2i673.smtp2go.com [103.2.142.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1257316C854 for ; Wed, 29 Jan 2025 10:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.2.142.161 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738145698; cv=none; b=YOyeWYUNg54LXDWd9QFscGzSakUWY9+uTtuXoF4DIj269zZgxiJvX9awmhQjH5f681m/UUiGfNKA/7blu81wCB8Njq7BxsUHa0Ab4ktcFIRDgrrsdx5MPSL9SWp9l1MR2zHPB30VUsY/3bAsSQ5jJKdup/lvRh/0nUD2YSyqFDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738145698; c=relaxed/simple; bh=jlWqgjHL5N7f8oGkWcnw43c2Ps30GS7ts7AWiFMaylQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OyLI93WI1/AKKy2VarJBaBJF1FTRhmvpCDV+aYVKrH53iQN8/WBUDmKIcUdRv62CnnRorXOzqcsAVsH/pR5H6mdaJvYbygYdqzEFQ3PAeUrjuViIinwAF+X+W+pGFYP4musaLbVpsKDATRvgry5yM0XheXtBm2IUbHDXEpyJMNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu; spf=pass smtp.mailfrom=em1174286.fjasle.eu; dkim=fail (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=JhkPPT0n reason="unknown key version"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=ajsj6+3R; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=lrzTQRN3; arc=none smtp.client-ip=103.2.142.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em1174286.fjasle.eu Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="unknown key version" (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="JhkPPT0n"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="ajsj6+3R"; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="lrzTQRN3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=mp6320.a1-4.dyn; x=1738146585; h=Feedback-ID: X-Smtpcorp-Track:Message-ID:Subject:To:From:Date:Reply-To:Sender: List-Unsubscribe:List-Unsubscribe-Post; bh=yigIz8jogxLpu8Oq/ClpNGnqxPIg8HGpntMDN4L9js0=; b=JhkPPT0nf+Zm4NRLTnGMO2dEaa dByVWxzEUPeny0TCiDlgf9Zdy6wstO8HFaXTVIq6DmIB7dwNmGc6v4F8IcaKurNyMUTqygA4faWu7 nq9WCxHiZD0FG5TlCMbeuMrhftA+a6kVRu0ked3/AcvkFp/6JgsiCe+DV6p1h3Qxxy218Qb+iZOF4 IxFDSOa1HJChJOG3kcxnfU9QrrNLgkhUdMlh+MyVSdezhoN8VcTUsDg3TvRuZo3/qrVrW/vqyGk0c uuVPrQaxDNUYNn7L1wYfOdYIlJcfuOnO9RWP6D9MQ4bU4jmrbA+N1+BFDx5BhBClq80O2ixSLuHKZ XfO3pVsQ==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fjasle.eu; i=@fjasle.eu; q=dns/txt; s=s1174286; t=1738145685; h=from : subject : to : message-id : date; bh=yigIz8jogxLpu8Oq/ClpNGnqxPIg8HGpntMDN4L9js0=; b=ajsj6+3Ru193cTG9MWOWBweLY8hMYjiQHNuiwBWn6QWmKrK1CccfCfKCdn4+WLhj8zhiu CDe3wRfedWJ/BxxaSQW7JJLA0GLC4eVm4dv+onTfrU5xtXEdNDysQG1BjDTxiVTwlHfbEMs hreJ7G9ku9ZGd5IDCeQaa2LGvY7wSMQ2RG6164zuOWvzXW/SEafrMMccsiM8XK4FUlM2/dN XyzWE51tXbjyUOqZmHqleEpAQHdlJOwGKXmD+DXBx9UQn0ZW/Z6OijuiVwyalSdiRqqZpEo WELEqVbdizsToQL2/ljJoadgZi3D1rq6LPWb1yK2YBMSdMO6n9o7AWyYox8w== Received: from [10.139.162.187] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1td541-qt4C2u-7W; Wed, 29 Jan 2025 10:12:53 +0000 Received: from [10.85.249.164] (helo=leknes.fjasle.eu) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97.1-S2G) (envelope-from ) id 1td540-4o5NDgrj3YX-m1RY; Wed, 29 Jan 2025 10:12:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1738145569; bh=jlWqgjHL5N7f8oGkWcnw43c2Ps30GS7ts7AWiFMaylQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lrzTQRN3Tn32FaSlwxsLVco1eX3DaHzg6Z8TRjjS1WIaUVi4Si1yCo3WTUpJh8fdW F+PnOhw5lYOsXu+6n/Tv5PbAbEPZUx/dTzHK5fKxW0mkUPZj8xWlai41nC0rQG6uuT 9SQHPfkpisMCnTaCynW2DaO4AAk9FNYX1ise4kDE= Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 4C4DB3D90C; Wed, 29 Jan 2025 11:12:49 +0100 (CET) Date: Wed, 29 Jan 2025 11:12:49 +0100 From: Nicolas Schier To: Kienan Stewart Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Masahiro Yamada , Nicolas Schier , Nathan Chancellor , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, n.schier@avm.de Subject: Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact Message-ID: References: <20250127-buildfix-extmod-powerpc-v1-1-450012b16263@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Debian GNU/Linux 12.9 X-Smtpcorp-Track: 0sQ7OeFq3_27.c4y-EtZxlYh0.LBeHZg52wFU Feedback-ID: 1174286m:1174286a9YXZ7r:1174286sjo3cYpwpr X-Report-Abuse: Please forward a copy of this message, including all headers, to On Tue 28 Jan 2025 10:53:42 GMT, Kienan Stewart wrote: > Hi, > > I missed a few CCs, looping them in now. Apologies for the extra noise. > > thanks, > kienan > > On 1/27/25 1:47 PM, Kienan Stewart wrote: > > In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b > > ("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts") > > artifacts required for building out-of-tree kernel modules had > > $(objtree) prepended to them to prepare for building in other > > directories. > > > > When building external modules for powerpc, > > arch/powerpc/lib/crtsavres.o is required for certain > > configurations. This artifact is missing the prepended $(objtree). > > > > External modules may work around this omission for v6.13 by setting MO=$KDIR. > > > > Signed-off-by: Kienan Stewart > > --- > > arch/powerpc/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile > > index f3804103c56ccfdb16289468397ccaea71bf721e..9933b98df69d7f7b9aaf33d36155cc61ab4460c7 100644 > > --- a/arch/powerpc/Makefile > > +++ b/arch/powerpc/Makefile > > @@ -58,7 +58,7 @@ ifeq ($(CONFIG_PPC64)$(CONFIG_LD_IS_BFD),yy) > > # There is a corresponding test in arch/powerpc/lib/Makefile > > KBUILD_LDFLAGS_MODULE += --save-restore-funcs > > else > > -KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o > > +KBUILD_LDFLAGS_MODULE += $(objtree)/arch/powerpc/lib/crtsavres.o > > endif > > ifdef CONFIG_CPU_LITTLE_ENDIAN > > > > --- > > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 > > change-id: 20250127-buildfix-extmod-powerpc-a744e1331f83 Thanks! Reviewed-by: Nicolas Schier Tested-by: Nicolas Schier