On Thu, Jan 30, 2025 at 12:44:54PM +0000, Russell King (Oracle) wrote:
> @@ -1123,7 +1126,9 @@ static void xpcs_link_up_sgmii_1000basex(struct dw_xpcs *xpcs,
>  {
>  	int ret;
>  
> -	if (neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED)
> +	if (neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED &&
> +	    !(interface == PHY_INTERFACE_MODE_SGMII &&
> +	      xpcs->sgmii_mode == )
                                  ^ DW_XPCS_SGMII_MODE_MAC_MANUAL

Not sure where that went. :(

>  		return;
>  
>  	if (interface == PHY_INTERFACE_MODE_1000BASEX) {

Note that with this change, we also need to change the xpcs_write() to
BMCR at the end of this function to xpcs_modify() so we don't clear the
AN-enable bit. It's also a good idea in general to only modify the bits
we need to modify.

New patch attached.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!