From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 05/14] pinctrl: cy8c95x0: Use better bitmap APIs where appropriate
Date: Mon, 3 Feb 2025 15:35:58 +0200 [thread overview]
Message-ID: <Z6DGPg6JhhWqnp16@smile.fi.intel.com> (raw)
In-Reply-To: <20250203131506.3318201-6-andriy.shevchenko@linux.intel.com>
On Mon, Feb 03, 2025 at 03:10:31PM +0200, Andy Shevchenko wrote:
> There are bitmap_gather() and bitmap_scatter() that are factually
> reimplemented in the driver. Use better bitmap APIs where appropriate.
...
> + bitmap_gather(tval, val, chip->map, MAX_LINE);
Oh, here is a typo, has to be:
bitmap_gather(val, tval, chip->map, MAX_LINE);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-03 13:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 13:10 [PATCH v2 00/14] pinctrl: cy8c95x0: Bugfixes and cleanups Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 01/14] pinctrl: cy8c95x0: Fix off-by-one in the regmap range settings Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 02/14] pinctrl: cy8c95x0: Avoid accessing reserved registers Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 03/14] pinctrl: cy8c95x0: Enable regmap locking for debug Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 04/14] pinctrl: cy8c95x0: Rename PWMSEL to SELPWM Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 05/14] pinctrl: cy8c95x0: Use better bitmap APIs where appropriate Andy Shevchenko
2025-02-03 13:35 ` Andy Shevchenko [this message]
2025-02-03 13:10 ` [PATCH v2 06/14] pinctrl: cy8c95x0; Switch to use for_each_set_clump8() Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 07/14] pinctrl: cy8c95x0: Transform to cy8c95x0_regmap_read_bits() Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 08/14] pinctrl: cy8c95x0: Remove redundant check in cy8c95x0_regmap_update_bits_base() Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 09/14] pinctrl: cy8c95x0: Replace 'return ret' by 'return 0' in some cases Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 10/14] pinctrl: cy8c95x0: Initialise boolean variable with boolean values Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 11/14] pinctrl: cy8c95x0: Get rid of cy8c95x0_pinmux_direction() forward declaration Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 12/14] pinctrl: cy8c95x0: Drop unneeded casting Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 13/14] pinctrl: cy8c95x0: Separate EEPROM related register definitios Andy Shevchenko
2025-02-03 13:10 ` [PATCH v2 14/14] pinctrl: cy8c95x0: Fix comment style Andy Shevchenko
2025-02-03 13:35 ` [PATCH v2 00/14] pinctrl: cy8c95x0: Bugfixes and cleanups Linus Walleij
2025-02-03 14:33 ` Andy Shevchenko
2025-02-04 17:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6DGPg6JhhWqnp16@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®